Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to ignore applet (gamepad connection window will not appear when it is disconnected) #40

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

Goodfeat
Copy link
Contributor

I made an additional option to ignore the dialog box when disconnecting the gamepad. This option will be useful for those who use the computer as a console (without a keyboard). With this setting, there is no longer a need to connect the keyboard to confirm the changes

I tested it in some games and it works. I also tried to translate the option into different languages

2024-10-23 094052

@github-actions github-actions bot added the gui Affects the Avalonia UI or translations. label Oct 22, 2024
@MetrosexualGarbodor
Copy link
Collaborator

This is a hack, as it makes the emulator ignore intended functionality. The applet should be either emulated fully so that it works just like on Switch, where it prompts to press a button, or for an iffier solution, the emulator should automatically dismiss it if the controller is re-detected after a disconnect.

If Greem really intends to merge this, at the very least it should be moved under "Hacks" in the UI.

Copy link
Owner

@GreemDev GreemDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what @MetrosexualGarbodor said.

src/Ryujinx.UI.Common/Configuration/ConfigurationState.cs Outdated Show resolved Hide resolved
fixed inaccurate description "migrating to version 52" to version 55
@Goodfeat
Copy link
Contributor Author

Goodfeat commented Oct 23, 2024

If Greem really intends to merge this, at the very least it should be moved under "Hacks" in the UI.

image

if necessary and there is an additional request, then the applet setting can be moved to this section, besides, it looks organic here

@Goodfeat
Copy link
Contributor Author

Hi, I tested this on games and the setup doesn't cause any problems. Please tell me if this setup will be merged with the main branch?

@GreemDev GreemDev merged commit e30ee32 into GreemDev:master Oct 24, 2024
11 checks passed
@VeraPhobia
Copy link

VeraPhobia commented Oct 24, 2024

hi i just updated and i think there is one thing missing

Screenshot 2024-10-24 185748

this option doesn't have this context menu like this. while it is an extremely small issue i thought it was worth mentioning

edit, thank you all for the great work by the way

@Goodfeat
Copy link
Contributor Author

this option doesn't have this context menu like this.

I will try to add a description to the context menu, but it will be problematic to translate into some languages. Translations may be incorrect and need spelling checks from the outside

@Goodfeat
Copy link
Contributor Author

How about this description?
image

@VeraPhobia
Copy link

VeraPhobia commented Oct 25, 2024

i think its perfect. thank you for the great work

i hope it will be approved

edit: in the sake of consistency with other context menus how about adding ( leave OFF if unsure )?

@Goodfeat
Copy link
Contributor Author

Я думаю, это идеально. Спасибо за прекрасную работу.
I'm already in the process of translation, where the translator will give a controversial translation, I will leave English

Otozinclus pushed a commit to Otozinclus/Ryujinx that referenced this pull request Oct 30, 2024
* Convert unsupported indexed buffer topologies

* Fix index count and dispatch size

* Cleanup

* Fix typos
WilliamWsyHK pushed a commit to WilliamWsyHK/Ryujinx-GreemDev that referenced this pull request Dec 6, 2024
…GreemDev#40)

Bumps [Microsoft.IdentityModel.JsonWebTokens](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet) from 8.1.1 to 8.1.2.
- [Release notes](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases)
- [Changelog](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/dev/CHANGELOG.md)
- [Commits](AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet@8.1.1...8.1.2)

---
updated-dependencies:
- dependency-name: Microsoft.IdentityModel.JsonWebTokens
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Affects the Avalonia UI or translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants