feat[next]: GTIR as_fieldop fusion pass
#1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p' into gtir_fuse_as_fieldop
tehrengruber
changed the title
as_fieldop fusion passas_fieldop fusion pass
egparedes
reviewed
Oct 11, 2024
| from gt4py.next.type_system import type_info, type_specifications as ts | ||
|
|
||
|
|
||
| def _inline_as_fieldop_arg(arg: itir.Expr, uids: eve_utils.UIDGenerator): |
There was a problem hiding this comment.
Missing return type annotation in some functions of this module (why is mypy not complaining here?)
| for inner_param, inner_arg in zip(stencil.params, inner_args, strict=True): | ||
| if isinstance(inner_arg, itir.SymRef): | ||
| stencil_params.append(inner_param) | ||
| extracted_args[inner_arg.id] = inner_arg |
There was a problem hiding this comment.
If the comment above is not wrong, I think this should be:
Suggested change
| extracted_args[inner_arg.id] = inner_arg | |
| extracted_args[inner_param.id] = inner_arg |
There was a problem hiding this comment.
I changed the comment above. It is the stencil param of the stencil of the outer as_fieldop that the current stencil is being inlined into.
tehrengruber
added a commit
that referenced
this pull request
Oct 18, 2024
New temporary extraction pass. Transforms an `itir.Program` like
```
testee(inp, out) {
out @ c⟨ IDimₕ: [0, 1) ⟩
← as_fieldop(deref, c⟨ IDimₕ: [0, 1) ⟩)(as_fieldop(deref, c⟨ IDimₕ: [0, 1) ⟩)(inp));
}
```
into
```
testee(inp, out) {
__tmp_1 = temporary(domain=c⟨ IDimₕ: [0, 1) ⟩, dtype=float64);
__tmp_1 @ c⟨ IDimₕ: [0, 1) ⟩ ← as_fieldop(deref, c⟨ IDimₕ: [0, 1) ⟩)(inp);
out @ c⟨ IDimₕ: [0, 1) ⟩ ← as_fieldop(deref, c⟨ IDimₕ: [0, 1) ⟩)(__tmp_1);
}
```
Note that this pass intentionally unconditionally extracts. In case you
don't want a temporary you should fuse the `as_fieldop` before. As such
the fusion pass (see #1670)
contains the heuristics on what to fuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pass that transforms expressions like
into