Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WLS license to CI #63

Open
3 tasks
simonbowly opened this issue May 17, 2023 · 4 comments
Open
3 tasks

Add WLS license to CI #63

simonbowly opened this issue May 17, 2023 · 4 comments
Assignees

Comments

@simonbowly
Copy link
Member

simonbowly commented May 17, 2023

This is needed already for the cardinality-constrained regression doctests (quadratic model with >200 variables), and will also be needed for several OPF mod unittests.

To do:

  • Enable full WLS license for doc tests. Change doctest execution to push/main and pull_request_target/labelled
  • Mark tests to skip if the pip license is detected
  • Add an action to run unittest with WLS. Execute on push/main and pull_request_target/labelled
@simonbowly simonbowly self-assigned this May 17, 2023
@simonbowly
Copy link
Member Author

simonbowly commented May 17, 2023

For the release job which runs many platforms and python versions in parallel, the license needs a baseline limit of at least 12

@rluce
Copy link
Member

rluce commented May 25, 2023

Somwhere in the docs we state that all examples are runnable with the vendored pip license. Can we integrate WLS in the CI and still verify that property?

@simonbowly
Copy link
Member Author

Good point, then we should not apply the WLS license to the doctests, only to a secondary run of the unittests.

I can adjust the cardinality-constrained regression mod to respect that limit in doctests, not sure if the OPF mod examples can do the same.

@simonbowly
Copy link
Member Author

FWIW there is a skipif directive in sphinx-doctest which would allow us to do a run of the doctests with and without a full license. But maybe we should wait on that to enforce small examples as long as we can.

@simonbowly simonbowly mentioned this issue Jun 14, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants