From 4c95412a3289b769538c6dfbdd11f6bec878ac5a Mon Sep 17 00:00:00 2001
From: Binh-Minh <bmribler@hdfgroup.org>
Date: Tue, 16 Jul 2024 23:35:26 -0400
Subject: [PATCH 1/9] Add tests for H5R get name APIs

Added functionality tests for the following APIs:
H5Rget_file_name
H5Rget_obj_name
H5Rget_attr_name

Also removed "+1" when returning a name length in H5R__get_attr_name().
The exter "+1" gave an incorrect value for the length of the referenced
object's attribute name.

Fixed GH-4447
---
 src/H5Rint.c  |   2 +-
 test/trefer.c | 434 +++++++++++++++++++++++++++++++++++---------------
 2 files changed, 307 insertions(+), 129 deletions(-)

diff --git a/src/H5Rint.c b/src/H5Rint.c
index 3df70ba48c3..35fc78d83e7 100644
--- a/src/H5Rint.c
+++ b/src/H5Rint.c
@@ -837,7 +837,7 @@ H5R__get_attr_name(const H5R_ref_priv_t *ref, char *buf, size_t size)
         buf[copy_len] = '\0';
     }
 
-    ret_value = (ssize_t)(attr_name_len + 1);
+    ret_value = (ssize_t)(attr_name_len);
 
     FUNC_LEAVE_NOAPI(ret_value)
 } /* end H5R__get_attr_name() */
diff --git a/test/trefer.c b/test/trefer.c
index 5fb78730a80..39b99568cdd 100644
--- a/test/trefer.c
+++ b/test/trefer.c
@@ -33,6 +33,7 @@
 #define FILE_REF_EXT2      "trefer_ext2.h5"
 #define FILE_REF_COMPAT    "trefer_compat.h5"
 
+
 /* 1-D dataset with fixed dimensions */
 #define SPACE1_RANK 1
 #define SPACE1_DIM1 4
@@ -65,11 +66,23 @@ typedef struct s2_t {
     unsigned int dim_idx; /* dimension index of the dataset */
 } s2_t;
 
-#define GROUPNAME  "/group"
-#define GROUPNAME2 "group2"
-#define GROUPNAME3 "group3"
-#define DSETNAME   "/dset"
-#define DSETNAME2  "dset2"
+#define GROUPNAME     "/group"
+#define GROUPNAME2    "group2"
+#define GROUPNAME3    "group3"
+#define DSETNAME      "/dset"
+#define DSETNAME2     "dset2"
+#define DS1_NAME      "Dataset1"
+#define DS2_NAME      "Dataset2"
+#define DS3_NAME      "Dataset3"
+#define DT1_NAME      "Datatype1"
+#define ATTR_NAME     "Attr"
+#define GROUPNAME1    "/Group1"
+#define DS1_REF_OBJ   "/Group1/Dataset1"
+#define DS2_REF_OBJ   "/Group1/Dataset2"
+#define DT1_REF_OBJ   "/Group1/Datatype1"
+#define ATTR1_REF_OBJ "Attr1"
+#define ATTR2_REF_OBJ "Attr2"
+#define ATTR3_REF_OBJ "Attr3"
 #define NAME_SIZE  16
 
 #define MAX_ITER_CREATE 1000
@@ -140,7 +153,7 @@ test_reference_params(void)
     CHECK(dapl_id, H5I_INVALID_HID, "H5Pcreate");
 
     /* Create a group */
-    group = H5Gcreate2(fid1, "Group1", H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    group = H5Gcreate2(fid1, GROUPNAME1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(group, H5I_INVALID_HID, "H5Gcreate2");
 
     if (vol_is_native) {
@@ -150,7 +163,7 @@ test_reference_params(void)
     }
 
     /* Create a dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset1", H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS1_NAME, H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Write selection to disk */
@@ -162,11 +175,11 @@ test_reference_params(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Create another dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset2", H5T_NATIVE_UCHAR, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS2_NAME, H5T_NATIVE_UCHAR, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Create an attribute for the dataset */
-    attr = H5Acreate2(dataset, "Attr", H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT);
+    attr = H5Acreate2(dataset, ATTR_NAME, H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(attr, H5I_INVALID_HID, "H5Acreate2");
 
     /* Write attribute to disk */
@@ -196,7 +209,7 @@ test_reference_params(void)
     CHECK(ret, FAIL, "H5Tinsert");
 
     /* Save datatype for later */
-    ret = H5Tcommit2(group, "Datatype1", tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    ret = H5Tcommit2(group, DT1_NAME, tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(ret, FAIL, "H5Tcommit2");
 
     /* Close datatype */
@@ -208,19 +221,19 @@ test_reference_params(void)
     CHECK(ret, FAIL, "H5Gclose");
 
     /* Create a dataset */
-    dataset = H5Dcreate2(fid1, "Dataset3", H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(fid1, DS3_NAME, H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(ret, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Test parameters to H5Rcreate_object */
     H5E_BEGIN_TRY
     {
-        ret = H5Rcreate_object(fid1, "/Group1/Dataset1", H5P_DEFAULT, NULL);
+        ret = H5Rcreate_object(fid1, DS1_REF_OBJ, H5P_DEFAULT, NULL);
     }
     H5E_END_TRY
     VERIFY(ret, FAIL, "H5Rcreate_object ref");
     H5E_BEGIN_TRY
     {
-        ret = H5Rcreate_object(H5I_INVALID_HID, "/Group1/Dataset1", H5P_DEFAULT, &wbuf[0]);
+        ret = H5Rcreate_object(H5I_INVALID_HID, DS1_REF_OBJ, H5P_DEFAULT, &wbuf[0]);
     }
     H5E_END_TRY
     VERIFY(ret, FAIL, "H5Rcreate_object loc_id");
@@ -240,13 +253,13 @@ test_reference_params(void)
     /* Test parameters to H5Rcreate_region */
     H5E_BEGIN_TRY
     {
-        ret = H5Rcreate_region(fid1, "/Group1/Dataset1", sid1, H5P_DEFAULT, NULL);
+        ret = H5Rcreate_region(fid1, DS1_REF_OBJ, sid1, H5P_DEFAULT, NULL);
     }
     H5E_END_TRY
     VERIFY(ret, FAIL, "H5Rcreate_region ref");
     H5E_BEGIN_TRY
     {
-        ret = H5Rcreate_region(H5I_INVALID_HID, "/Group1/Dataset1", sid1, H5P_DEFAULT, &wbuf[0]);
+        ret = H5Rcreate_region(H5I_INVALID_HID, DS1_REF_OBJ, sid1, H5P_DEFAULT, &wbuf[0]);
     }
     H5E_END_TRY
     VERIFY(ret, FAIL, "H5Rcreate_region loc_id");
@@ -258,7 +271,7 @@ test_reference_params(void)
     VERIFY(ret, FAIL, "H5Rcreate_region name");
     H5E_BEGIN_TRY
     {
-        ret = H5Rcreate_region(fid1, "/Group1/Dataset1", H5I_INVALID_HID, H5P_DEFAULT, &wbuf[0]);
+        ret = H5Rcreate_region(fid1, DS1_REF_OBJ, H5I_INVALID_HID, H5P_DEFAULT, &wbuf[0]);
     }
     H5E_END_TRY
     VERIFY(ret, FAIL, "H5Rcreate_region dataspace");
@@ -266,25 +279,25 @@ test_reference_params(void)
     /* Test parameters to H5Rcreate_attr */
     H5E_BEGIN_TRY
     {
-        ret = H5Rcreate_attr(fid1, "/Group1/Dataset2", "Attr", H5P_DEFAULT, NULL);
+        ret = H5Rcreate_attr(fid1, DS2_REF_OBJ, ATTR_NAME, H5P_DEFAULT, NULL);
     }
     H5E_END_TRY
     VERIFY(ret, FAIL, "H5Rcreate_attr ref");
     H5E_BEGIN_TRY
     {
-        ret = H5Rcreate_attr(H5I_INVALID_HID, "/Group1/Dataset2", "Attr", H5P_DEFAULT, &wbuf[0]);
+        ret = H5Rcreate_attr(H5I_INVALID_HID, DS2_REF_OBJ, ATTR_NAME, H5P_DEFAULT, &wbuf[0]);
     }
     H5E_END_TRY
     VERIFY(ret, FAIL, "H5Rcreate_attr loc_id");
     H5E_BEGIN_TRY
     {
-        ret = H5Rcreate_attr(fid1, NULL, "Attr", H5P_DEFAULT, &wbuf[0]);
+        ret = H5Rcreate_attr(fid1, NULL, ATTR_NAME, H5P_DEFAULT, &wbuf[0]);
     }
     H5E_END_TRY
     VERIFY(ret, FAIL, "H5Rcreate_attr name");
     H5E_BEGIN_TRY
     {
-        ret = H5Rcreate_attr(fid1, "/Group1/Dataset2", NULL, H5P_DEFAULT, &wbuf[0]);
+        ret = H5Rcreate_attr(fid1, DS2_REF_OBJ, NULL, H5P_DEFAULT, &wbuf[0]);
     }
     H5E_END_TRY
     VERIFY(ret, FAIL, "H5Rcreate_attr attr_name");
@@ -433,7 +446,10 @@ test_reference_obj(void)
 {
     hid_t fid1;       /* HDF5 File IDs                    */
     hid_t dataset,    /* Dataset ID                       */
-        dset2;        /* Dereferenced dataset ID          */
+        ds1_from_name,/* Dataset ID returned by H5Dopen2 using a dataset name */
+        ds2_from_name,/* Dataset ID returned by H5Dopen2 using a dataset name */
+        ref_ds1,      /* Dereferenced dataset ID          */
+        ref_ds2;      /* Dereferenced dataset ID          */
     hid_t      group; /* Group ID                         */
     hid_t      sid1;  /* Dataspace ID                     */
     hid_t      tid1;  /* Datatype ID                      */
@@ -444,10 +460,10 @@ test_reference_obj(void)
     H5R_ref_t *wbuf_cp; /* copy buffer                      */
     unsigned  *ibuf, *obuf;
     unsigned   i, j;     /* Counters                         */
+    ssize_t    namelen;  /* String buffer size return value  */
+    char       *namebuf; /* Buffer for attribute's or dataset's name */
     H5O_type_t obj_type; /* Object type                      */
     herr_t     ret;      /* Generic return value             */
-    ssize_t    namelen;  /* String buffer size return value  */
-    char       buf[100];
 
     /* Output message about test being performed */
     MESSAGE(5, ("Testing Object Reference Functions\n"));
@@ -474,11 +490,11 @@ test_reference_obj(void)
     CHECK(dapl_id, H5I_INVALID_HID, "H5Pcreate");
 
     /* Create a group */
-    group = H5Gcreate2(fid1, "Group1", H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    group = H5Gcreate2(fid1, GROUPNAME1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(group, H5I_INVALID_HID, "H5Gcreate2");
 
     /* Create a dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset1", H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS1_NAME, H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Write selection to disk */
@@ -490,7 +506,7 @@ test_reference_obj(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Create another dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset2", H5T_NATIVE_UCHAR, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS2_NAME, H5T_NATIVE_UCHAR, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, FAIL, "H5Dcreate2");
 
     /* Close Dataset */
@@ -512,7 +528,7 @@ test_reference_obj(void)
     CHECK(ret, FAIL, "H5Tinsert");
 
     /* Save datatype for later */
-    ret = H5Tcommit2(group, "Datatype1", tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    ret = H5Tcommit2(group, DT1_NAME, tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(ret, FAIL, "H5Tcommit2");
 
     /* Close datatype */
@@ -524,32 +540,32 @@ test_reference_obj(void)
     CHECK(ret, FAIL, "H5Gclose");
 
     /* Create a dataset */
-    dataset = H5Dcreate2(fid1, "Dataset3", H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(fid1, DS3_NAME, H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Create reference to dataset */
-    ret = H5Rcreate_object(fid1, "/Group1/Dataset1", H5P_DEFAULT, &wbuf[0]);
+    ret = H5Rcreate_object(fid1, DS1_REF_OBJ, H5P_DEFAULT, &wbuf[0]);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&wbuf[0], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_DATASET, "H5Rget_obj_type3");
 
     /* Create reference to dataset */
-    ret = H5Rcreate_object(fid1, "/Group1/Dataset2", H5P_DEFAULT, &wbuf[1]);
+    ret = H5Rcreate_object(fid1, DS2_REF_OBJ, H5P_DEFAULT, &wbuf[1]);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&wbuf[1], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_DATASET, "H5Rget_obj_type3");
 
     /* Create reference to group */
-    ret = H5Rcreate_object(fid1, "/Group1", H5P_DEFAULT, &wbuf[2]);
+    ret = H5Rcreate_object(fid1, GROUPNAME1, H5P_DEFAULT, &wbuf[2]);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&wbuf[2], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_GROUP, "H5Rget_obj_type3");
 
     /* Create reference to named datatype */
-    ret = H5Rcreate_object(fid1, "/Group1/Datatype1", H5P_DEFAULT, &wbuf[3]);
+    ret = H5Rcreate_object(fid1, DT1_REF_OBJ, H5P_DEFAULT, &wbuf[3]);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&wbuf[3], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
@@ -612,33 +628,130 @@ test_reference_obj(void)
     VERIFY(namelen, strlen(FILE_REF_OBJ), "H5Dget_file_name");
 
     /* Get the file name for the reference */
-    namelen = H5Rget_file_name(&rbuf[0], (char *)buf, sizeof(buf));
+    namebuf = (char *) malloc((size_t)namelen + 1);
+    namelen = H5Rget_file_name(&rbuf[0], (char *)namebuf, (size_t)namelen + 1);
     CHECK(namelen, FAIL, "H5Dget_file_name");
 
-    ret = !((strcmp(buf, FILE_REF_OBJ) == 0) && (namelen == strlen(FILE_REF_OBJ)));
+    ret = !((strcmp(namebuf, FILE_REF_OBJ) == 0) && (namelen == strlen(FILE_REF_OBJ)));
     CHECK(ret, FAIL, "H5Literate");
 
+    /* Testing Dataset1 */
+
+    /* Getting the name of the referenced object and verify it */
+    namelen = H5Rget_obj_name(&rbuf[0], H5P_DEFAULT, NULL, 0);
+    CHECK(namelen, FAIL, "H5Rget_obj_name");
+    VERIFY(namelen, strlen(DS1_REF_OBJ), "H5Rget_obj_name");
+
+    namebuf = (char *) malloc((size_t)namelen + 1);
+    namelen = H5Rget_obj_name(&rbuf[0], H5P_DEFAULT, namebuf, (size_t)namelen+1);
+    CHECK(namelen, FAIL, "H5Rget_obj_name");
+    VERIFY(strcmp(namebuf, DS1_REF_OBJ), 0, "strcmp namebuf vs DS1_REF_OBJ");
+
     /* Open dataset object */
-    dset2 = H5Ropen_object(&rbuf[0], H5P_DEFAULT, dapl_id);
-    CHECK(dset2, H5I_INVALID_HID, "H5Ropen_object");
+    ref_ds1 = H5Ropen_object(&rbuf[0], H5P_DEFAULT, dapl_id);
+    CHECK(ref_ds1, H5I_INVALID_HID, "H5Ropen_object");
 
     /* Check information in referenced dataset */
-    sid1 = H5Dget_space(dset2);
+    sid1 = H5Dget_space(ref_ds1);
     CHECK(sid1, H5I_INVALID_HID, "H5Dget_space");
 
     ret = (int)H5Sget_simple_extent_npoints(sid1);
     VERIFY(ret, SPACE1_DIM1, "H5Sget_simple_extent_npoints");
 
     /* Read from disk */
-    ret = H5Dread(dset2, H5T_NATIVE_UINT, H5S_ALL, H5S_ALL, H5P_DEFAULT, ibuf);
+    ret = H5Dread(ref_ds1, H5T_NATIVE_UINT, H5S_ALL, H5S_ALL, H5P_DEFAULT, ibuf);
     CHECK(ret, FAIL, "H5Dread");
 
     for (i = 0; i < SPACE1_DIM1; i++)
         VERIFY(ibuf[i], i * 3, "Data");
 
     /* Close dereferenced Dataset */
-    ret = H5Dclose(dset2);
+    ret = H5Dclose(ref_ds1);
+    CHECK(ret, FAIL, "H5Dclose");
+
+    /* Open dataset using the name from the referenced object */
+    ds1_from_name = H5Dopen(fid1, namebuf, H5P_DEFAULT);
+    CHECK(ds1_from_name, H5I_INVALID_HID, "H5Dopen");
+
+    /* Check information in the dataset */
+    sid1 = H5Dget_space(ds1_from_name);
+    CHECK(sid1, H5I_INVALID_HID, "H5Dget_space");
+
+    ret = (int)H5Sget_simple_extent_npoints(sid1);
+    VERIFY(ret, SPACE1_DIM1, "H5Sget_simple_extent_npoints");
+
+    /* Read dataset data from disk */
+    ret = H5Dread(ds1_from_name, H5T_NATIVE_UINT, H5S_ALL, H5S_ALL, H5P_DEFAULT, ibuf);
+    CHECK(ret, FAIL, "H5Dread");
+
+    for (i = 0; i < SPACE1_DIM1; i++)
+        VERIFY(ibuf[i], i * 3, "Data");
+
+    /* Release resources  */
+    ret = H5Sclose(sid1);
+    CHECK(ret, FAIL, "H5Sclose");
+    ret = H5Dclose(ds1_from_name);
     CHECK(ret, FAIL, "H5Dclose");
+    free(namebuf);
+
+    /* Testing Dataset2 */
+
+    /* Getting the name of the referenced object and verify it */
+    namelen = H5Rget_obj_name(&rbuf[1], H5P_DEFAULT, NULL, 0);
+    CHECK(namelen, FAIL, "H5Rget_obj_name");
+    VERIFY(namelen, strlen(DS2_REF_OBJ), "H5Rget_obj_name");
+
+    namebuf = (char *) malloc((size_t)namelen + 1);
+    namelen = H5Rget_obj_name(&rbuf[1], H5P_DEFAULT, namebuf, (size_t)namelen+1);
+    CHECK(namelen, FAIL, "H5Rget_obj_name");
+    VERIFY(strcmp(namebuf, DS2_REF_OBJ), 0, "strcmp namebuf vs DS2_REF_OBJ");
+
+    /* Open dataset object */
+    ref_ds2 = H5Ropen_object(&rbuf[1], H5P_DEFAULT, dapl_id);
+    CHECK(ref_ds2, H5I_INVALID_HID, "H5Ropen_object");
+
+    /* Check information in referenced dataset */
+    sid1 = H5Dget_space(ref_ds2);
+    CHECK(sid1, H5I_INVALID_HID, "H5Dget_space");
+
+    ret = (int)H5Sget_simple_extent_npoints(sid1);
+    VERIFY(ret, SPACE1_DIM1, "H5Sget_simple_extent_npoints");
+
+    /* Read from disk */
+    ret = H5Dread(ref_ds2, H5T_NATIVE_UINT, H5S_ALL, H5S_ALL, H5P_DEFAULT, ibuf);
+    CHECK(ret, FAIL, "H5Dread");
+
+    for (i = 0; i < SPACE1_DIM1; i++)
+        VERIFY(ibuf[i], 0, "Data");
+
+    /* Close dereferenced Dataset */
+    ret = H5Dclose(ref_ds2);
+    CHECK(ret, FAIL, "H5Dclose");
+
+    /* Open dataset using the name from the referenced object */
+    ds2_from_name = H5Dopen(fid1, namebuf, H5P_DEFAULT);
+    CHECK(ds2_from_name, H5I_INVALID_HID, "H5Dopen");
+
+    /* Check information in the dataset */
+    sid1 = H5Dget_space(ds2_from_name);
+    CHECK(sid1, H5I_INVALID_HID, "H5Dget_space");
+
+    ret = (int)H5Sget_simple_extent_npoints(sid1);
+    VERIFY(ret, SPACE1_DIM1, "H5Sget_simple_extent_npoints");
+
+    /* Read dataset data from disk */
+    ret = H5Dread(ds2_from_name, H5T_NATIVE_UINT, H5S_ALL, H5S_ALL, H5P_DEFAULT, ibuf);
+    CHECK(ret, FAIL, "H5Dread");
+
+    for (i = 0; i < SPACE1_DIM1; i++)
+        VERIFY(ibuf[i], 0, "Data");
+
+    /* Release resources  */
+    ret = H5Sclose(sid1);
+    CHECK(ret, FAIL, "H5Sclose");
+    ret = H5Dclose(ds2_from_name);
+    CHECK(ret, FAIL, "H5Dclose");
+    free(namebuf);
 
     /* Open group object.  GAPL isn't supported yet.  But it's harmless to pass in */
     group = H5Ropen_object(&rbuf[2], H5P_DEFAULT, H5P_DEFAULT);
@@ -745,11 +858,11 @@ test_reference_vlen_obj(void)
     CHECK(dapl_id, H5I_INVALID_HID, "H5Pcreate");
 
     /* Create a group */
-    group = H5Gcreate2(fid1, "Group1", H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    group = H5Gcreate2(fid1, GROUPNAME1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(group, H5I_INVALID_HID, "H5Gcreate2");
 
     /* Create a dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset1", H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS1_NAME, H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Write selection to disk */
@@ -761,7 +874,7 @@ test_reference_vlen_obj(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Create another dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset2", H5T_NATIVE_UCHAR, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS2_NAME, H5T_NATIVE_UCHAR, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, FAIL, "H5Dcreate2");
 
     /* Close Dataset */
@@ -787,7 +900,7 @@ test_reference_vlen_obj(void)
     CHECK(ret, FAIL, "H5Tinsert");
 
     /* Save datatype for later */
-    ret = H5Tcommit2(group, "Datatype1", tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    ret = H5Tcommit2(group, DT1_NAME, tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(ret, FAIL, "H5Tcommit2");
 
     /* Close datatype */
@@ -807,18 +920,18 @@ test_reference_vlen_obj(void)
     CHECK(sid1, H5I_INVALID_HID, "H5Screate_simple");
 
     /* Create a dataset */
-    dataset = H5Dcreate2(fid1, "Dataset3", tid1, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(fid1, DS3_NAME, tid1, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Create reference to dataset */
-    ret = H5Rcreate_object(fid1, "/Group1/Dataset1", H5P_DEFAULT, &wbuf[0]);
+    ret = H5Rcreate_object(fid1, DS1_REF_OBJ, H5P_DEFAULT, &wbuf[0]);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&wbuf[0], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_DATASET, "H5Rget_obj_type3");
 
     /* Create reference to dataset */
-    ret = H5Rcreate_object(fid1, "/Group1/Dataset2", H5P_DEFAULT, &wbuf[1]);
+    ret = H5Rcreate_object(fid1, DS2_REF_OBJ, H5P_DEFAULT, &wbuf[1]);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&wbuf[1], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
@@ -832,7 +945,7 @@ test_reference_vlen_obj(void)
     VERIFY(obj_type, H5O_TYPE_GROUP, "H5Rget_obj_type3");
 
     /* Create reference to named datatype */
-    ret = H5Rcreate_object(fid1, "/Group1/Datatype1", H5P_DEFAULT, &wbuf[3]);
+    ret = H5Rcreate_object(fid1, DT1_REF_OBJ, H5P_DEFAULT, &wbuf[3]);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&wbuf[3], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
@@ -1008,11 +1121,11 @@ test_reference_cmpnd_obj(void)
     CHECK(dapl_id, H5I_INVALID_HID, "H5Pcreate");
 
     /* Create a group */
-    group = H5Gcreate2(fid1, "Group1", H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    group = H5Gcreate2(fid1, GROUPNAME1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(group, H5I_INVALID_HID, "H5Gcreate2");
 
     /* Create a dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset1", H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS1_NAME, H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Write selection to disk */
@@ -1024,7 +1137,7 @@ test_reference_cmpnd_obj(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Create another dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset2", H5T_NATIVE_UCHAR, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS2_NAME, H5T_NATIVE_UCHAR, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, FAIL, "H5Dcreate2");
 
     /* Close Dataset */
@@ -1050,7 +1163,7 @@ test_reference_cmpnd_obj(void)
     CHECK(ret, FAIL, "H5Tinsert");
 
     /* Save datatype for later */
-    ret = H5Tcommit2(group, "Datatype1", tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    ret = H5Tcommit2(group, DT1_NAME, tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(ret, FAIL, "H5Tcommit2");
 
     /* Close datatype */
@@ -1086,21 +1199,21 @@ test_reference_cmpnd_obj(void)
     CHECK(sid1, H5I_INVALID_HID, "H5Screate_simple");
 
     /* Create a dataset */
-    dataset = H5Dcreate2(fid1, "Dataset3", tid1, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(fid1, DS3_NAME, tid1, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Reset buffer for writing */
     memset(&cmpnd_wbuf, 0, sizeof(cmpnd_wbuf));
 
     /* Create reference to dataset */
-    ret = H5Rcreate_object(fid1, "/Group1/Dataset1", H5P_DEFAULT, &cmpnd_wbuf.ref0);
+    ret = H5Rcreate_object(fid1, DS1_REF_OBJ, H5P_DEFAULT, &cmpnd_wbuf.ref0);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&cmpnd_wbuf.ref0, H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_DATASET, "H5Rget_obj_type3");
 
     /* Create reference to dataset */
-    ret = H5Rcreate_object(fid1, "/Group1/Dataset2", H5P_DEFAULT, &cmpnd_wbuf.ref1);
+    ret = H5Rcreate_object(fid1, DS2_REF_OBJ, H5P_DEFAULT, &cmpnd_wbuf.ref1);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&cmpnd_wbuf.ref1, H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
@@ -1114,7 +1227,7 @@ test_reference_cmpnd_obj(void)
     VERIFY(obj_type, H5O_TYPE_GROUP, "H5Rget_obj_type3");
 
     /* Create reference to named datatype */
-    ret = H5Rcreate_object(fid1, "/Group1/Datatype1", H5P_DEFAULT, &cmpnd_wbuf.ref3);
+    ret = H5Rcreate_object(fid1, DT1_REF_OBJ, H5P_DEFAULT, &cmpnd_wbuf.ref3);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&cmpnd_wbuf.ref3, H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
@@ -1327,7 +1440,7 @@ test_reference_region(H5F_libver_t libver_low, H5F_libver_t libver_high)
     CHECK(dapl_id, H5I_INVALID_HID, "H5Pcreate");
 
     /* Create a dataset */
-    dset2 = H5Dcreate2(fid1, "Dataset2", H5T_STD_U8LE, sid2, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dset2 = H5Dcreate2(fid1, DS2_NAME, H5T_STD_U8LE, sid2, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dset2, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Write selection to disk */
@@ -1345,7 +1458,7 @@ test_reference_region(H5F_libver_t libver_low, H5F_libver_t libver_high)
     /* Create a dataset */
     H5E_BEGIN_TRY
     {
-        dset1 = H5Dcreate2(fid1, "Dataset1", H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+        dset1 = H5Dcreate2(fid1, DS1_NAME, H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     }
     H5E_END_TRY
 
@@ -1783,7 +1896,7 @@ test_reference_region_1D(H5F_libver_t libver_low, H5F_libver_t libver_high)
     CHECK(dapl_id, H5I_INVALID_HID, "H5Pcreate");
 
     /* Create a dataset */
-    dset3 = H5Dcreate2(fid1, "Dataset2", H5T_STD_U8LE, sid3, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dset3 = H5Dcreate2(fid1, DS2_NAME, H5T_STD_U8LE, sid3, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dset3, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Write selection to disk */
@@ -1801,7 +1914,7 @@ test_reference_region_1D(H5F_libver_t libver_low, H5F_libver_t libver_high)
     /* Create a dataset */
     H5E_BEGIN_TRY
     {
-        dset1 = H5Dcreate2(fid1, "Dataset1", H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+        dset1 = H5Dcreate2(fid1, DS1_NAME, H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     }
     H5E_END_TRY
 
@@ -2086,7 +2199,7 @@ test_reference_obj_deleted(void)
     CHECK(sid1, H5I_INVALID_HID, "H5Screate_simple");
 
     /* Create a dataset to reference (deleted later) */
-    dataset = H5Dcreate2(fid1, "Dataset1", H5T_NATIVE_INT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(fid1, DS1_NAME, H5T_NATIVE_INT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Close Dataset */
@@ -2094,7 +2207,7 @@ test_reference_obj_deleted(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Create a dataset */
-    dataset = H5Dcreate2(fid1, "Dataset2", H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(fid1, DS2_NAME, H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Create reference to dataset */
@@ -2346,12 +2459,18 @@ test_reference_attr(void)
     hid_t     attr;    /* Attribute ID */
     hid_t     sid;     /* Dataspace ID */
     hid_t     tid;     /* Datatype ID */
+    hid_t     attr1_from_name; /* Attribute ID returned by H5Aopen using an attribute name */
+    hid_t     attr2_from_name; /* Attribute ID returned by H5Aopen using an attribute name */
+    hid_t     ref_attr1;      /* Dereferenced attribute ID          */
+    hid_t     ref_attr3;      /* Dereferenced attribute ID          */
     hsize_t   dims[] = {SPACE1_DIM1};
     hid_t     dapl_id;               /* Dataset access property list */
     H5R_ref_t ref_wbuf[SPACE1_DIM1], /* Buffer to write to disk */
         ref_rbuf[SPACE1_DIM1];       /* Buffer read from disk */
     unsigned   wbuf[SPACE1_DIM1], rbuf[SPACE1_DIM1];
     unsigned   i;        /* Local index variables */
+    ssize_t    namelen;  /* String buffer size return value  */
+    char       *namebuf; /* Buffer for attribute's or dataset's name */
     H5O_type_t obj_type; /* Object type */
     herr_t     ret;      /* Generic return value */
 
@@ -2371,11 +2490,11 @@ test_reference_attr(void)
     CHECK(dapl_id, H5I_INVALID_HID, "H5Pcreate");
 
     /* Create a group */
-    group = H5Gcreate2(fid, "Group1", H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    group = H5Gcreate2(fid, GROUPNAME1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(group, H5I_INVALID_HID, "H5Gcreate2");
 
     /* Create an attribute for the dataset */
-    attr = H5Acreate2(group, "Attr2", H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT);
+    attr = H5Acreate2(group, ATTR2_REF_OBJ, H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(attr, H5I_INVALID_HID, "H5Acreate2");
 
     for (i = 0; i < SPACE1_DIM1; i++)
@@ -2390,11 +2509,11 @@ test_reference_attr(void)
     CHECK(ret, FAIL, "H5Aclose");
 
     /* Create a dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset1", H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS1_NAME, H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Create an attribute for the dataset */
-    attr = H5Acreate2(dataset, "Attr1", H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT);
+    attr = H5Acreate2(dataset, ATTR1_REF_OBJ, H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(attr, H5I_INVALID_HID, "H5Acreate2");
 
     for (i = 0; i < SPACE1_DIM1; i++)
@@ -2413,7 +2532,7 @@ test_reference_attr(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Create another dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset2", H5T_NATIVE_UCHAR, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS2_NAME, H5T_NATIVE_UCHAR, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Close Dataset */
@@ -2435,7 +2554,7 @@ test_reference_attr(void)
     CHECK(ret, FAIL, "H5Tinsert");
 
     /* Save datatype for later */
-    ret = H5Tcommit2(group, "Datatype1", tid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    ret = H5Tcommit2(group, DT1_NAME, tid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(ret, FAIL, "H5Tcommit2");
 
     /* Create an attribute for the datatype */
@@ -2462,32 +2581,32 @@ test_reference_attr(void)
     CHECK(ret, FAIL, "H5Gclose");
 
     /* Create a dataset */
-    dataset = H5Dcreate2(fid, "Dataset3", H5T_STD_REF, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(fid, DS3_NAME, H5T_STD_REF, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Create reference to dataset1 attribute */
-    ret = H5Rcreate_attr(fid, "/Group1/Dataset1", "Attr1", H5P_DEFAULT, &ref_wbuf[0]);
+    ret = H5Rcreate_attr(fid, DS1_REF_OBJ, ATTR1_REF_OBJ, H5P_DEFAULT, &ref_wbuf[0]);
     CHECK(ret, FAIL, "H5Rcreate_attr");
     ret = H5Rget_obj_type3(&ref_wbuf[0], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_DATASET, "H5Rget_obj_type3");
 
     /* Create reference to dataset2 attribute */
-    ret = H5Rcreate_attr(fid, "/Group1/Dataset2", "Attr1", H5P_DEFAULT, &ref_wbuf[1]);
+    ret = H5Rcreate_attr(fid, DS2_REF_OBJ, ATTR1_REF_OBJ, H5P_DEFAULT, &ref_wbuf[1]);
     CHECK(ret, FAIL, "H5Rcreate_attr");
     ret = H5Rget_obj_type3(&ref_wbuf[1], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_DATASET, "H5Rget_obj_type3");
 
     /* Create reference to group attribute */
-    ret = H5Rcreate_attr(fid, "/Group1", "Attr2", H5P_DEFAULT, &ref_wbuf[2]);
+    ret = H5Rcreate_attr(fid, "/Group1", ATTR2_REF_OBJ, H5P_DEFAULT, &ref_wbuf[2]);
     CHECK(ret, FAIL, "H5Rcreate_attr");
     ret = H5Rget_obj_type3(&ref_wbuf[2], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_GROUP, "H5Rget_obj_type3");
 
     /* Create reference to named datatype attribute */
-    ret = H5Rcreate_attr(fid, "/Group1/Datatype1", "Attr3", H5P_DEFAULT, &ref_wbuf[3]);
+    ret = H5Rcreate_attr(fid, DT1_REF_OBJ, "Attr3", H5P_DEFAULT, &ref_wbuf[3]);
     CHECK(ret, FAIL, "H5Rcreate_attr");
     ret = H5Rget_obj_type3(&ref_wbuf[3], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
@@ -2521,63 +2640,122 @@ test_reference_attr(void)
     ret = H5Dread(dataset, H5T_STD_REF, H5S_ALL, H5S_ALL, H5P_DEFAULT, ref_rbuf);
     CHECK(ret, FAIL, "H5Dread");
 
+    /* Testing "Attr1" */
+
+    /* Getting the name of the referenced attribute and verify it */
+    namelen = H5Rget_attr_name(&ref_rbuf[0], NULL, 0);
+    CHECK(namelen, FAIL, "H5Rget_attr_name");
+    VERIFY(namelen, strlen(ATTR1_REF_OBJ), "H5Rget_obj_name");
+
+    namebuf = (char *) malloc((size_t)namelen + 1);
+    namelen = H5Rget_attr_name(&ref_rbuf[0], namebuf, (size_t)namelen+1);
+    CHECK(namelen, FAIL, "H5Rget_attr_name");
+    VERIFY(strcmp(namebuf, ATTR1_REF_OBJ), 0, "strcmp namebuf vs ATTR1_REF_OBJ");
+
     /* Open attribute on dataset object */
-    attr = H5Ropen_attr(&ref_rbuf[0], H5P_DEFAULT, H5P_DEFAULT);
-    CHECK(attr, H5I_INVALID_HID, "H5Ropen_attr");
+    ref_attr1 = H5Ropen_attr(&ref_rbuf[0], H5P_DEFAULT, H5P_DEFAULT);
+    CHECK(ref_attr1, H5I_INVALID_HID, "H5Ropen_attr");
 
-    /* Check information in referenced dataset */
-    sid = H5Aget_space(attr);
+    /* Check information in referenced attribute */
+    sid = H5Aget_space(ref_attr1);
     CHECK(sid, H5I_INVALID_HID, "H5Aget_space");
 
     ret = (int)H5Sget_simple_extent_npoints(sid);
     VERIFY(ret, SPACE1_DIM1, "H5Sget_simple_extent_npoints");
 
-    /* Read from disk */
-    ret = H5Aread(attr, H5T_NATIVE_UINT, rbuf);
+    /* Read attribute data from disk */
+    ret = H5Aread(ref_attr1, H5T_NATIVE_UINT, rbuf);
     CHECK(ret, FAIL, "H5Aread");
 
     for (i = 0; i < SPACE1_DIM1; i++)
         VERIFY(rbuf[i], i * 3, "Data");
 
-    /* Close dereferenced Dataset */
-    ret = H5Aclose(attr);
+    /* Close dereferenced attribute */
+    ret = H5Aclose(ref_attr1);
     CHECK(ret, FAIL, "H5Aclose");
 
-    /* Open attribute on group object */
-    attr = H5Ropen_attr(&ref_rbuf[2], H5P_DEFAULT, H5P_DEFAULT);
-    CHECK(attr, H5I_INVALID_HID, "H5Ropen_attr");
+    /* Open attribute using the name from the referenced object */
+    attr1_from_name = H5Aopen_by_name(fid, "Group1/Dataset1", namebuf, H5P_DEFAULT, H5P_DEFAULT);
+    CHECK(attr1_from_name, H5I_INVALID_HID, "H5Aopen_by_name");
+
+    /* Check information in referenced attribute */
+    sid = H5Aget_space(attr1_from_name);
+    CHECK(sid, H5I_INVALID_HID, "H5Aget_space");
+
+    ret = (int)H5Sget_simple_extent_npoints(sid);
+    VERIFY(ret, SPACE1_DIM1, "H5Sget_simple_extent_npoints");
+
+    /* Read attribute data from disk */
+    ret = H5Aread(attr1_from_name, H5T_NATIVE_UINT, rbuf);
+    CHECK(ret, FAIL, "H5Aread");
+
+    for (i = 0; i < SPACE1_DIM1; i++)
+        VERIFY(rbuf[i], i * 3, "Data");
+
+    /* Close resources */
+    free(namebuf);
+    ret = H5Sclose(sid);
+    CHECK(ret, FAIL, "H5Sclose");
+    ret = H5Aclose(attr1_from_name);
+    CHECK(ret, FAIL, "H5Aclose");
+
+    /* Testing "Attr2" */
+
+    /* Getting the name of the referenced attribute and verify it */
+    namelen = H5Rget_attr_name(&ref_rbuf[2], NULL, 0);
+    CHECK(namelen, FAIL, "H5Rget_attr_name");
+    VERIFY(namelen, strlen(ATTR2_REF_OBJ), "H5Rget_obj_name");
+
+    namebuf = (char *) malloc((size_t)namelen + 1);
+    namelen = H5Rget_attr_name(&ref_rbuf[2], namebuf, (size_t)namelen+1);
+    CHECK(namelen, FAIL, "H5Rget_attr_name");
+    VERIFY(strcmp(namebuf, ATTR2_REF_OBJ), 0, "strcmp namebuf vs ATTR2_REF_OBJ");
+
+    /* Open attribute using the name from the referenced object */
+    attr2_from_name = H5Aopen_by_name(fid, GROUPNAME1, namebuf, H5P_DEFAULT, H5P_DEFAULT);
+    CHECK(attr2_from_name, H5I_INVALID_HID, "H5Aopen_by_name");
 
     /* Read from disk */
-    ret = H5Aread(attr, H5T_NATIVE_UINT, rbuf);
+    ret = H5Aread(attr2_from_name, H5T_NATIVE_UINT, rbuf);
     CHECK(ret, FAIL, "H5Aread");
 
     for (i = 0; i < SPACE1_DIM1; i++)
         VERIFY(rbuf[i], (i * 3) + 1, "Data");
 
-    /* Close attribute  */
-    ret = H5Aclose(attr);
+    /* Release resources  */
+    free(namebuf);
+    ret = H5Aclose(attr2_from_name);
     CHECK(ret, FAIL, "H5Aclose");
 
+    /* Testing "Attr3" */
+
+    /* Getting the name of the referenced attribute and verify it */
+    namelen = H5Rget_attr_name(&ref_rbuf[3], NULL, 0);
+    CHECK(namelen, FAIL, "H5Rget_attr_name");
+    VERIFY(namelen, strlen(ATTR3_REF_OBJ), "H5Rget_obj_name");
+
+    namebuf = (char *) malloc((size_t)namelen + 1);
+    namelen = H5Rget_attr_name(&ref_rbuf[3], namebuf, (size_t)namelen+1);
+    CHECK(namelen, FAIL, "H5Rget_attr_name");
+    VERIFY(strcmp(namebuf, ATTR3_REF_OBJ), 0, "strcmp namebuf vs ATTR3_REF_OBJ");
+
     /* Open attribute on named datatype object */
-    attr = H5Ropen_attr(&ref_rbuf[3], H5P_DEFAULT, H5P_DEFAULT);
-    CHECK(attr, H5I_INVALID_HID, "H5Ropen_attr");
+    ref_attr3 = H5Ropen_attr(&ref_rbuf[3], H5P_DEFAULT, H5P_DEFAULT);
+    CHECK(ref_attr3, H5I_INVALID_HID, "H5Ropen_attr");
 
     /* Read from disk */
-    ret = H5Aread(attr, H5T_NATIVE_UINT, rbuf);
+    ret = H5Aread(ref_attr3, H5T_NATIVE_UINT, rbuf);
     CHECK(ret, FAIL, "H5Aread");
 
     for (i = 0; i < SPACE1_DIM1; i++)
         VERIFY(rbuf[i], (i * 3) + 2, "Data");
 
-    /* Close attribute  */
-    ret = H5Aclose(attr);
+    /* Release resources  */
+    free(namebuf);
+    ret = H5Aclose(ref_attr3);
     CHECK(ret, FAIL, "H5Aclose");
-
-    /* Close dataset */
     ret = H5Dclose(dataset);
     CHECK(ret, FAIL, "H5Dclose");
-
-    /* Close dataset access property list */
     ret = H5Pclose(dapl_id);
     CHECK(ret, FAIL, "H5Pclose");
 
@@ -2634,11 +2812,11 @@ test_reference_external(void)
     CHECK(dapl_id, H5I_INVALID_HID, "H5Pcreate");
 
     /* Create a group */
-    group = H5Gcreate2(fid1, "Group1", H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    group = H5Gcreate2(fid1, GROUPNAME1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(group, H5I_INVALID_HID, "H5Gcreate2");
 
     /* Create an attribute for the dataset */
-    attr = H5Acreate2(group, "Attr2", H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT);
+    attr = H5Acreate2(group, ATTR2_REF_OBJ, H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(attr, H5I_INVALID_HID, "H5Acreate2");
 
     for (i = 0; i < SPACE1_DIM1; i++)
@@ -2653,11 +2831,11 @@ test_reference_external(void)
     CHECK(ret, FAIL, "H5Aclose");
 
     /* Create a dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset1", H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS1_NAME, H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Create an attribute for the dataset */
-    attr = H5Acreate2(dataset, "Attr1", H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT);
+    attr = H5Acreate2(dataset, ATTR1_REF_OBJ, H5T_NATIVE_UINT, sid, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(attr, H5I_INVALID_HID, "H5Acreate2");
 
     for (i = 0; i < SPACE1_DIM1; i++)
@@ -2676,7 +2854,7 @@ test_reference_external(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Create another dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset2", H5T_NATIVE_UCHAR, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS2_NAME, H5T_NATIVE_UCHAR, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Close Dataset */
@@ -2698,7 +2876,7 @@ test_reference_external(void)
     CHECK(ret, FAIL, "H5Tinsert");
 
     /* Save datatype for later */
-    ret = H5Tcommit2(group, "Datatype1", tid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    ret = H5Tcommit2(group, DT1_NAME, tid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(ret, FAIL, "H5Tcommit2");
 
     /* Create an attribute for the datatype */
@@ -2725,28 +2903,28 @@ test_reference_external(void)
     CHECK(ret, FAIL, "H5Gclose");
 
     /* Create reference to dataset1 attribute */
-    ret = H5Rcreate_attr(fid1, "/Group1/Dataset1", "Attr1", H5P_DEFAULT, &ref_wbuf[0]);
+    ret = H5Rcreate_attr(fid1, DS1_REF_OBJ, ATTR1_REF_OBJ, H5P_DEFAULT, &ref_wbuf[0]);
     CHECK(ret, FAIL, "H5Rcreate_attr");
     ret = H5Rget_obj_type3(&ref_wbuf[0], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_DATASET, "H5Rget_obj_type3");
 
     /* Create reference to dataset2 attribute */
-    ret = H5Rcreate_attr(fid1, "/Group1/Dataset2", "Attr1", H5P_DEFAULT, &ref_wbuf[1]);
+    ret = H5Rcreate_attr(fid1, DS2_REF_OBJ, ATTR1_REF_OBJ, H5P_DEFAULT, &ref_wbuf[1]);
     CHECK(ret, FAIL, "H5Rcreate_attr");
     ret = H5Rget_obj_type3(&ref_wbuf[1], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_DATASET, "H5Rget_obj_type3");
 
     /* Create reference to group attribute */
-    ret = H5Rcreate_attr(fid1, "/Group1", "Attr2", H5P_DEFAULT, &ref_wbuf[2]);
+    ret = H5Rcreate_attr(fid1, "/Group1", ATTR2_REF_OBJ, H5P_DEFAULT, &ref_wbuf[2]);
     CHECK(ret, FAIL, "H5Rcreate_attr");
     ret = H5Rget_obj_type3(&ref_wbuf[2], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
     VERIFY(obj_type, H5O_TYPE_GROUP, "H5Rget_obj_type3");
 
     /* Create reference to named datatype attribute */
-    ret = H5Rcreate_attr(fid1, "/Group1/Datatype1", "Attr3", H5P_DEFAULT, &ref_wbuf[3]);
+    ret = H5Rcreate_attr(fid1, DT1_REF_OBJ, "Attr3", H5P_DEFAULT, &ref_wbuf[3]);
     CHECK(ret, FAIL, "H5Rcreate_attr");
     ret = H5Rget_obj_type3(&ref_wbuf[3], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
@@ -2769,7 +2947,7 @@ test_reference_external(void)
     CHECK(sid, H5I_INVALID_HID, "H5Screate_simple");
 
     /* Create a dataset */
-    dataset = H5Dcreate2(fid2, "Dataset3", H5T_STD_REF, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(fid2, DS3_NAME, H5T_STD_REF, sid, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Write selection to disk */
@@ -2937,11 +3115,11 @@ test_reference_compat_conv(void)
     CHECK(sid3, H5I_INVALID_HID, "H5Screate_simple");
 
     /* Create a group */
-    group = H5Gcreate2(fid1, "Group1", H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    group = H5Gcreate2(fid1, GROUPNAME1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(group, H5I_INVALID_HID, "H5Gcreate2");
 
     /* Create a dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset1", H5T_NATIVE_UINT, sid2, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS1_NAME, H5T_NATIVE_UINT, sid2, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Close Dataset */
@@ -2949,7 +3127,7 @@ test_reference_compat_conv(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Create another dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset2", H5T_NATIVE_UCHAR, sid2, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS2_NAME, H5T_NATIVE_UCHAR, sid2, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Close Dataset */
@@ -2971,7 +3149,7 @@ test_reference_compat_conv(void)
     CHECK(ret, FAIL, "H5Tinsert");
 
     /* Save datatype for later */
-    ret = H5Tcommit2(group, "Datatype1", tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    ret = H5Tcommit2(group, DT1_NAME, tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(ret, FAIL, "H5Tcommit2");
 
     /* Close datatype */
@@ -2983,15 +3161,15 @@ test_reference_compat_conv(void)
     CHECK(ret, FAIL, "H5Gclose");
 
     /* Create a dataset with object reference datatype */
-    dataset = H5Dcreate2(fid1, "Dataset3", H5T_STD_REF_OBJ, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(fid1, DS3_NAME, H5T_STD_REF_OBJ, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Create reference to dataset */
-    ret = H5Rcreate(&wbuf_obj[0], fid1, "/Group1/Dataset1", H5R_OBJECT, H5I_INVALID_HID);
+    ret = H5Rcreate(&wbuf_obj[0], fid1, DS1_REF_OBJ, H5R_OBJECT, H5I_INVALID_HID);
     CHECK(ret, FAIL, "H5Rcreate");
 
     /* Create reference to dataset */
-    ret = H5Rcreate(&wbuf_obj[1], fid1, "/Group1/Dataset2", H5R_OBJECT, H5I_INVALID_HID);
+    ret = H5Rcreate(&wbuf_obj[1], fid1, DS2_REF_OBJ, H5R_OBJECT, H5I_INVALID_HID);
     CHECK(ret, FAIL, "H5Rcreate");
 
     /* Create reference to group */
@@ -2999,7 +3177,7 @@ test_reference_compat_conv(void)
     CHECK(ret, FAIL, "H5Rcreate");
 
     /* Create reference to named datatype */
-    ret = H5Rcreate(&wbuf_obj[3], fid1, "/Group1/Datatype1", H5R_OBJECT, H5I_INVALID_HID);
+    ret = H5Rcreate(&wbuf_obj[3], fid1, DT1_REF_OBJ, H5R_OBJECT, H5I_INVALID_HID);
     CHECK(ret, FAIL, "H5Rcreate");
 
     /* Write references to disk */
@@ -3027,7 +3205,7 @@ test_reference_compat_conv(void)
     CHECK(ret, FAIL, "H5Sselect_hyperslab");
 
     /* Create first dataset region */
-    ret = H5Rcreate(&wbuf_reg[0], fid1, "/Group1/Dataset1", H5R_DATASET_REGION, sid2);
+    ret = H5Rcreate(&wbuf_reg[0], fid1, DS1_REF_OBJ, H5R_DATASET_REGION, sid2);
     CHECK(ret, FAIL, "H5Rcreate");
 
     /* Select sequence of ten points for second reference */
@@ -3055,7 +3233,7 @@ test_reference_compat_conv(void)
     CHECK(ret, FAIL, "H5Sselect_elements");
 
     /* Create second dataset region */
-    ret = H5Rcreate(&wbuf_reg[1], fid1, "/Group1/Dataset2", H5R_DATASET_REGION, sid2);
+    ret = H5Rcreate(&wbuf_reg[1], fid1, DS2_REF_OBJ, H5R_DATASET_REGION, sid2);
     CHECK(ret, FAIL, "H5Rcreate");
 
     /* Write selection to disk */
@@ -3259,11 +3437,11 @@ test_reference_perf(void)
     CHECK(dapl_id, H5I_INVALID_HID, "H5Pcreate");
 
     /* Create a group */
-    group = H5Gcreate2(fid1, "Group1", H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    group = H5Gcreate2(fid1, GROUPNAME1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(group, H5I_INVALID_HID, "H5Gcreate2");
 
     /* Create a dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset1", H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS1_NAME, H5T_NATIVE_UINT, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     /* Write selection to disk */
@@ -3275,7 +3453,7 @@ test_reference_perf(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Create another dataset (inside Group1) */
-    dataset = H5Dcreate2(group, "Dataset2", H5T_NATIVE_UCHAR, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(group, DS2_NAME, H5T_NATIVE_UCHAR, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, FAIL, "H5Dcreate2");
 
     /* Close Dataset */
@@ -3297,7 +3475,7 @@ test_reference_perf(void)
     CHECK(ret, FAIL, "H5Tinsert");
 
     /* Save datatype for later */
-    ret = H5Tcommit2(group, "Datatype1", tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    ret = H5Tcommit2(group, DT1_NAME, tid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(ret, FAIL, "H5Tcommit2");
 
     /* Close datatype */
@@ -3309,13 +3487,13 @@ test_reference_perf(void)
     CHECK(ret, FAIL, "H5Gclose");
 
     /* Create a dataset */
-    dataset = H5Dcreate2(fid1, "Dataset3", H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
+    dataset = H5Dcreate2(fid1, DS3_NAME, H5T_STD_REF, sid1, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
     CHECK(dataset, H5I_INVALID_HID, "H5Dcreate2");
 
     t = 0;
     for (i = 0; i < MAX_ITER_CREATE; i++) {
         t1  = H5_get_time();
-        ret = H5Rcreate_object(fid1, "/Group1/Dataset1", H5P_DEFAULT, &wbuf[0]);
+        ret = H5Rcreate_object(fid1, DS1_REF_OBJ, H5P_DEFAULT, &wbuf[0]);
         CHECK(ret, FAIL, "H5Rcreate_object");
         t2 = H5_get_time();
         t += t2 - t1;
@@ -3326,7 +3504,7 @@ test_reference_perf(void)
         printf("--- Object reference create time: %lfs\n", t / MAX_ITER_CREATE);
 
     /* Create reference to dataset */
-    ret = H5Rcreate_object(fid1, "/Group1/Dataset1", H5P_DEFAULT, &wbuf[0]);
+    ret = H5Rcreate_object(fid1, DS1_REF_OBJ, H5P_DEFAULT, &wbuf[0]);
     CHECK(ret, FAIL, "H5Rcreate_object");
     ret = H5Rget_obj_type3(&wbuf[0], H5P_DEFAULT, &obj_type);
     CHECK(ret, FAIL, "H5Rget_obj_type3");
@@ -3356,7 +3534,7 @@ test_reference_perf(void)
         t = 0;
         for (i = 0; i < MAX_ITER_CREATE; i++) {
             t1  = H5_get_time();
-            ret = H5Rcreate(&wbuf_deprec[0], fid1, "/Group1/Dataset1", H5R_OBJECT1, H5I_INVALID_HID);
+            ret = H5Rcreate(&wbuf_deprec[0], fid1, DS1_REF_OBJ, H5R_OBJECT1, H5I_INVALID_HID);
             CHECK(ret, FAIL, "H5Rcreate");
             t2 = H5_get_time();
             t += t2 - t1;
@@ -3365,7 +3543,7 @@ test_reference_perf(void)
             printf("--- Deprecated object reference create time: %lfs\n", t / MAX_ITER_CREATE);
 
         /* Create reference to dataset */
-        ret = H5Rcreate(&wbuf_deprec[0], fid1, "/Group1/Dataset1", H5R_OBJECT1, H5I_INVALID_HID);
+        ret = H5Rcreate(&wbuf_deprec[0], fid1, DS1_REF_OBJ, H5R_OBJECT1, H5I_INVALID_HID);
         CHECK(ret, FAIL, "H5Rcreate");
 
         t = 0;
@@ -3393,7 +3571,7 @@ test_reference_perf(void)
     for (i = 0; i < MAX_ITER_CREATE; i++) {
         t1 = H5_get_time();
         /* Store first dataset region */
-        ret = H5Rcreate_region(fid1, "/Group1/Dataset1", sid1, H5P_DEFAULT, &wbuf_reg[0]);
+        ret = H5Rcreate_region(fid1, DS1_REF_OBJ, sid1, H5P_DEFAULT, &wbuf_reg[0]);
         CHECK(ret, FAIL, "H5Rcreate_region");
         t2 = H5_get_time();
         t += t2 - t1;
@@ -3404,7 +3582,7 @@ test_reference_perf(void)
         printf("--- Region reference create time: %lfs\n", t / MAX_ITER_CREATE);
 
     /* Store first dataset region */
-    ret = H5Rcreate_region(fid1, "/Group1/Dataset1", sid1, H5P_DEFAULT, &wbuf_reg[0]);
+    ret = H5Rcreate_region(fid1, DS1_REF_OBJ, sid1, H5P_DEFAULT, &wbuf_reg[0]);
     CHECK(ret, FAIL, "H5Rcreate_region");
 
     t = 0;
@@ -3433,7 +3611,7 @@ test_reference_perf(void)
         for (i = 0; i < MAX_ITER_CREATE; i++) {
             t1 = H5_get_time();
             /* Store first dataset region */
-            ret = H5Rcreate(&wbuf_reg_deprec[0], fid1, "/Group1/Dataset1", H5R_DATASET_REGION1, sid1);
+            ret = H5Rcreate(&wbuf_reg_deprec[0], fid1, DS1_REF_OBJ, H5R_DATASET_REGION1, sid1);
             CHECK(ret, FAIL, "H5Rcreate");
             t2 = H5_get_time();
             t += t2 - t1;

From 0756fc059bd19c6ae849e542714f29bd74bf4afb Mon Sep 17 00:00:00 2001
From: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Date: Wed, 17 Jul 2024 03:49:44 +0000
Subject: [PATCH 2/9] Committing clang-format changes

---
 test/trefer.c | 63 +++++++++++++++++++++++++--------------------------
 1 file changed, 31 insertions(+), 32 deletions(-)

diff --git a/test/trefer.c b/test/trefer.c
index 39b99568cdd..0b03b644012 100644
--- a/test/trefer.c
+++ b/test/trefer.c
@@ -33,7 +33,6 @@
 #define FILE_REF_EXT2      "trefer_ext2.h5"
 #define FILE_REF_COMPAT    "trefer_compat.h5"
 
-
 /* 1-D dataset with fixed dimensions */
 #define SPACE1_RANK 1
 #define SPACE1_DIM1 4
@@ -83,7 +82,7 @@ typedef struct s2_t {
 #define ATTR1_REF_OBJ "Attr1"
 #define ATTR2_REF_OBJ "Attr2"
 #define ATTR3_REF_OBJ "Attr3"
-#define NAME_SIZE  16
+#define NAME_SIZE     16
 
 #define MAX_ITER_CREATE 1000
 #define MAX_ITER_WRITE  MAX_ITER_CREATE
@@ -444,15 +443,15 @@ test_reference_params(void)
 static void
 test_reference_obj(void)
 {
-    hid_t fid1;       /* HDF5 File IDs                    */
-    hid_t dataset,    /* Dataset ID                       */
-        ds1_from_name,/* Dataset ID returned by H5Dopen2 using a dataset name */
-        ds2_from_name,/* Dataset ID returned by H5Dopen2 using a dataset name */
-        ref_ds1,      /* Dereferenced dataset ID          */
-        ref_ds2;      /* Dereferenced dataset ID          */
-    hid_t      group; /* Group ID                         */
-    hid_t      sid1;  /* Dataspace ID                     */
-    hid_t      tid1;  /* Datatype ID                      */
+    hid_t fid1;        /* HDF5 File IDs                    */
+    hid_t dataset,     /* Dataset ID                       */
+        ds1_from_name, /* Dataset ID returned by H5Dopen2 using a dataset name */
+        ds2_from_name, /* Dataset ID returned by H5Dopen2 using a dataset name */
+        ref_ds1,       /* Dereferenced dataset ID          */
+        ref_ds2;       /* Dereferenced dataset ID          */
+    hid_t      group;  /* Group ID                         */
+    hid_t      sid1;   /* Dataspace ID                     */
+    hid_t      tid1;   /* Datatype ID                      */
     hsize_t    dims1[] = {SPACE1_DIM1};
     hid_t      dapl_id; /* Dataset access property list     */
     H5R_ref_t *wbuf,    /* buffer to write to disk          */
@@ -461,7 +460,7 @@ test_reference_obj(void)
     unsigned  *ibuf, *obuf;
     unsigned   i, j;     /* Counters                         */
     ssize_t    namelen;  /* String buffer size return value  */
-    char       *namebuf; /* Buffer for attribute's or dataset's name */
+    char      *namebuf;  /* Buffer for attribute's or dataset's name */
     H5O_type_t obj_type; /* Object type                      */
     herr_t     ret;      /* Generic return value             */
 
@@ -628,7 +627,7 @@ test_reference_obj(void)
     VERIFY(namelen, strlen(FILE_REF_OBJ), "H5Dget_file_name");
 
     /* Get the file name for the reference */
-    namebuf = (char *) malloc((size_t)namelen + 1);
+    namebuf = (char *)malloc((size_t)namelen + 1);
     namelen = H5Rget_file_name(&rbuf[0], (char *)namebuf, (size_t)namelen + 1);
     CHECK(namelen, FAIL, "H5Dget_file_name");
 
@@ -642,8 +641,8 @@ test_reference_obj(void)
     CHECK(namelen, FAIL, "H5Rget_obj_name");
     VERIFY(namelen, strlen(DS1_REF_OBJ), "H5Rget_obj_name");
 
-    namebuf = (char *) malloc((size_t)namelen + 1);
-    namelen = H5Rget_obj_name(&rbuf[0], H5P_DEFAULT, namebuf, (size_t)namelen+1);
+    namebuf = (char *)malloc((size_t)namelen + 1);
+    namelen = H5Rget_obj_name(&rbuf[0], H5P_DEFAULT, namebuf, (size_t)namelen + 1);
     CHECK(namelen, FAIL, "H5Rget_obj_name");
     VERIFY(strcmp(namebuf, DS1_REF_OBJ), 0, "strcmp namebuf vs DS1_REF_OBJ");
 
@@ -701,8 +700,8 @@ test_reference_obj(void)
     CHECK(namelen, FAIL, "H5Rget_obj_name");
     VERIFY(namelen, strlen(DS2_REF_OBJ), "H5Rget_obj_name");
 
-    namebuf = (char *) malloc((size_t)namelen + 1);
-    namelen = H5Rget_obj_name(&rbuf[1], H5P_DEFAULT, namebuf, (size_t)namelen+1);
+    namebuf = (char *)malloc((size_t)namelen + 1);
+    namelen = H5Rget_obj_name(&rbuf[1], H5P_DEFAULT, namebuf, (size_t)namelen + 1);
     CHECK(namelen, FAIL, "H5Rget_obj_name");
     VERIFY(strcmp(namebuf, DS2_REF_OBJ), 0, "strcmp namebuf vs DS2_REF_OBJ");
 
@@ -2453,16 +2452,16 @@ test_reference_group(void)
 static void
 test_reference_attr(void)
 {
-    hid_t     fid;     /* HDF5 File ID */
-    hid_t     dataset; /* Dataset ID */
-    hid_t     group;   /* Group ID */
-    hid_t     attr;    /* Attribute ID */
-    hid_t     sid;     /* Dataspace ID */
-    hid_t     tid;     /* Datatype ID */
+    hid_t     fid;             /* HDF5 File ID */
+    hid_t     dataset;         /* Dataset ID */
+    hid_t     group;           /* Group ID */
+    hid_t     attr;            /* Attribute ID */
+    hid_t     sid;             /* Dataspace ID */
+    hid_t     tid;             /* Datatype ID */
     hid_t     attr1_from_name; /* Attribute ID returned by H5Aopen using an attribute name */
     hid_t     attr2_from_name; /* Attribute ID returned by H5Aopen using an attribute name */
-    hid_t     ref_attr1;      /* Dereferenced attribute ID          */
-    hid_t     ref_attr3;      /* Dereferenced attribute ID          */
+    hid_t     ref_attr1;       /* Dereferenced attribute ID          */
+    hid_t     ref_attr3;       /* Dereferenced attribute ID          */
     hsize_t   dims[] = {SPACE1_DIM1};
     hid_t     dapl_id;               /* Dataset access property list */
     H5R_ref_t ref_wbuf[SPACE1_DIM1], /* Buffer to write to disk */
@@ -2470,7 +2469,7 @@ test_reference_attr(void)
     unsigned   wbuf[SPACE1_DIM1], rbuf[SPACE1_DIM1];
     unsigned   i;        /* Local index variables */
     ssize_t    namelen;  /* String buffer size return value  */
-    char       *namebuf; /* Buffer for attribute's or dataset's name */
+    char      *namebuf;  /* Buffer for attribute's or dataset's name */
     H5O_type_t obj_type; /* Object type */
     herr_t     ret;      /* Generic return value */
 
@@ -2647,8 +2646,8 @@ test_reference_attr(void)
     CHECK(namelen, FAIL, "H5Rget_attr_name");
     VERIFY(namelen, strlen(ATTR1_REF_OBJ), "H5Rget_obj_name");
 
-    namebuf = (char *) malloc((size_t)namelen + 1);
-    namelen = H5Rget_attr_name(&ref_rbuf[0], namebuf, (size_t)namelen+1);
+    namebuf = (char *)malloc((size_t)namelen + 1);
+    namelen = H5Rget_attr_name(&ref_rbuf[0], namebuf, (size_t)namelen + 1);
     CHECK(namelen, FAIL, "H5Rget_attr_name");
     VERIFY(strcmp(namebuf, ATTR1_REF_OBJ), 0, "strcmp namebuf vs ATTR1_REF_OBJ");
 
@@ -2706,8 +2705,8 @@ test_reference_attr(void)
     CHECK(namelen, FAIL, "H5Rget_attr_name");
     VERIFY(namelen, strlen(ATTR2_REF_OBJ), "H5Rget_obj_name");
 
-    namebuf = (char *) malloc((size_t)namelen + 1);
-    namelen = H5Rget_attr_name(&ref_rbuf[2], namebuf, (size_t)namelen+1);
+    namebuf = (char *)malloc((size_t)namelen + 1);
+    namelen = H5Rget_attr_name(&ref_rbuf[2], namebuf, (size_t)namelen + 1);
     CHECK(namelen, FAIL, "H5Rget_attr_name");
     VERIFY(strcmp(namebuf, ATTR2_REF_OBJ), 0, "strcmp namebuf vs ATTR2_REF_OBJ");
 
@@ -2734,8 +2733,8 @@ test_reference_attr(void)
     CHECK(namelen, FAIL, "H5Rget_attr_name");
     VERIFY(namelen, strlen(ATTR3_REF_OBJ), "H5Rget_obj_name");
 
-    namebuf = (char *) malloc((size_t)namelen + 1);
-    namelen = H5Rget_attr_name(&ref_rbuf[3], namebuf, (size_t)namelen+1);
+    namebuf = (char *)malloc((size_t)namelen + 1);
+    namelen = H5Rget_attr_name(&ref_rbuf[3], namebuf, (size_t)namelen + 1);
     CHECK(namelen, FAIL, "H5Rget_attr_name");
     VERIFY(strcmp(namebuf, ATTR3_REF_OBJ), 0, "strcmp namebuf vs ATTR3_REF_OBJ");
 

From f5690de5b814886b58ef970c6aec660a69c87558 Mon Sep 17 00:00:00 2001
From: Binh-Minh <bmribler@hdfgroup.org>
Date: Wed, 17 Jul 2024 00:54:16 -0400
Subject: [PATCH 3/9] Fix typo

---
 test/trefer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/trefer.c b/test/trefer.c
index 39b99568cdd..f46f09d6ff4 100644
--- a/test/trefer.c
+++ b/test/trefer.c
@@ -670,7 +670,7 @@ test_reference_obj(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Open dataset using the name from the referenced object */
-    ds1_from_name = H5Dopen(fid1, namebuf, H5P_DEFAULT);
+    ds1_from_name = H5Dopen2(fid1, namebuf, H5P_DEFAULT);
     CHECK(ds1_from_name, H5I_INVALID_HID, "H5Dopen");
 
     /* Check information in the dataset */

From 49404be856b70c77c8aed546cb4de80e878a6f86 Mon Sep 17 00:00:00 2001
From: Binh-Minh <bmribler@hdfgroup.org>
Date: Wed, 17 Jul 2024 01:06:35 -0400
Subject: [PATCH 4/9] Fix typo

---
 test/trefer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/trefer.c b/test/trefer.c
index 0d3171fe6a3..66961c09ea3 100644
--- a/test/trefer.c
+++ b/test/trefer.c
@@ -728,7 +728,7 @@ test_reference_obj(void)
     CHECK(ret, FAIL, "H5Dclose");
 
     /* Open dataset using the name from the referenced object */
-    ds2_from_name = H5Dopen(fid1, namebuf, H5P_DEFAULT);
+    ds2_from_name = H5Dopen2(fid1, namebuf, H5P_DEFAULT);
     CHECK(ds2_from_name, H5I_INVALID_HID, "H5Dopen");
 
     /* Check information in the dataset */

From a596716d86e89ebec6c3b75d7158dec43d95b3e3 Mon Sep 17 00:00:00 2001
From: Binh-Minh <bmribler@hdfgroup.org>
Date: Wed, 17 Jul 2024 03:11:29 -0400
Subject: [PATCH 5/9] Fix Fortran test

The C API H5Rget_attr_name incorrectly added 1 to the length of the
referenced object's attribute name, so the Fortran API h5rget_attr_name_f
removed 1 from the returned value to accommodate the incorrectness.
This PR fixes H5Rget_attr_name so this workaround in h5rget_attr_name_f
is no longer needed.
---
 fortran/src/H5Rff.F90 | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fortran/src/H5Rff.F90 b/fortran/src/H5Rff.F90
index ab803a7596a..cad9d3c8a0e 100644
--- a/fortran/src/H5Rff.F90
+++ b/fortran/src/H5Rff.F90
@@ -1180,8 +1180,6 @@ END FUNCTION H5Rget_attr_name
        c_name(1:1)(1:1) = C_NULL_CHAR
        name_len = H5Rget_attr_name(ref_ptr, c_name, 1_SIZE_T)
        IF(name_len.LT.0_SIZE_T) hdferr = H5I_INVALID_HID_F
-       ! Don't include the NULL term in the size
-       name_len = name_len - 1
     ELSE
        l = INT(LEN(name)+1,SIZE_T)
        IF(H5Rget_attr_name(ref_ptr, c_name, l) .LT. 0_SIZE_T)THEN

From 9d57f6a47997340ca1aa1906aee09f5816ffc3c3 Mon Sep 17 00:00:00 2001
From: Binh-Minh <bmribler@hdfgroup.org>
Date: Sun, 11 Aug 2024 14:29:00 -0400
Subject: [PATCH 6/9] Add test H5Aget_name against H5Rget_attr_name

---
 test/trefer.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/test/trefer.c b/test/trefer.c
index 66961c09ea3..43c42ce1066 100644
--- a/test/trefer.c
+++ b/test/trefer.c
@@ -2470,6 +2470,8 @@ test_reference_attr(void)
     unsigned   i;        /* Local index variables */
     ssize_t    namelen;  /* String buffer size return value  */
     char      *namebuf;  /* Buffer for attribute's or dataset's name */
+    char   *attr_name = NULL; /* name of attribute, from H5A */
+    ssize_t attr_name_size;   /* size of attribute name */
     H5O_type_t obj_type; /* Object type */
     herr_t     ret;      /* Generic return value */
 
@@ -2684,6 +2686,27 @@ test_reference_attr(void)
     ret = (int)H5Sget_simple_extent_npoints(sid);
     VERIFY(ret, SPACE1_DIM1, "H5Sget_simple_extent_npoints");
 
+    /* Verify attribute name */
+    attr_name_size = H5Aget_name(attr1_from_name, (size_t)0, NULL);
+    CHECK(attr_name_size, FAIL, "H5Aget_name");
+
+    if (attr_name_size > 0) {
+        attr_name = (char *)calloc((size_t)(attr_name_size + 1), sizeof(char));
+        CHECK_PTR(attr_name, "calloc");
+
+        if (attr_name) {
+            ret = (herr_t)H5Aget_name(attr1_from_name, (size_t)(attr_name_size + 1), attr_name);
+            CHECK(ret, FAIL, "H5Aget_name");
+
+            /* Verify the name info between the H5A and H5R APIs */
+            ret = strcmp(attr_name, namebuf);
+            VERIFY(ret, 0, "H5Aget_name vs H5Rget_attr_name");
+            VERIFY(attr_name_size, namelen, "H5Aget_name vs H5Rget_attr_name");
+
+            free(attr_name);
+        } /* end if */
+    }     /* end if */
+
     /* Read attribute data from disk */
     ret = H5Aread(attr1_from_name, H5T_NATIVE_UINT, rbuf);
     CHECK(ret, FAIL, "H5Aread");

From 8be015adb4887e989c185da5f056903419f95d9d Mon Sep 17 00:00:00 2001
From: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Date: Sun, 11 Aug 2024 18:39:55 +0000
Subject: [PATCH 7/9] Committing clang-format changes

---
 test/trefer.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/test/trefer.c b/test/trefer.c
index 43c42ce1066..fcd0a21484a 100644
--- a/test/trefer.c
+++ b/test/trefer.c
@@ -2467,13 +2467,13 @@ test_reference_attr(void)
     H5R_ref_t ref_wbuf[SPACE1_DIM1], /* Buffer to write to disk */
         ref_rbuf[SPACE1_DIM1];       /* Buffer read from disk */
     unsigned   wbuf[SPACE1_DIM1], rbuf[SPACE1_DIM1];
-    unsigned   i;        /* Local index variables */
-    ssize_t    namelen;  /* String buffer size return value  */
-    char      *namebuf;  /* Buffer for attribute's or dataset's name */
-    char   *attr_name = NULL; /* name of attribute, from H5A */
-    ssize_t attr_name_size;   /* size of attribute name */
-    H5O_type_t obj_type; /* Object type */
-    herr_t     ret;      /* Generic return value */
+    unsigned   i;                /* Local index variables */
+    ssize_t    namelen;          /* String buffer size return value  */
+    char      *namebuf;          /* Buffer for attribute's or dataset's name */
+    char      *attr_name = NULL; /* name of attribute, from H5A */
+    ssize_t    attr_name_size;   /* size of attribute name */
+    H5O_type_t obj_type;         /* Object type */
+    herr_t     ret;              /* Generic return value */
 
     /* Output message about test being performed */
     MESSAGE(5, ("Testing Attribute Reference Functions\n"));

From da125e2997db4a1c3fdd8baa9d39a50e16beccbf Mon Sep 17 00:00:00 2001
From: Binh-Minh <bmribler@hdfgroup.org>
Date: Mon, 12 Aug 2024 01:13:10 -0400
Subject: [PATCH 8/9] Update documentation

---
 release_docs/RELEASE.txt | 9 +++++++++
 src/H5Rpublic.h          | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt
index 22e9eead0b6..debdbd9c37b 100644
--- a/release_docs/RELEASE.txt
+++ b/release_docs/RELEASE.txt
@@ -811,6 +811,15 @@ Bug Fixes since HDF5-1.14.0 release
 ===================================
     Library
     -------
+    - Fixed H5Rget_attr_name to return the length of the attribute's name
+      without the null terminator
+
+      H5Rget_file_name and H5Rget_obj_name both return the name's length
+      without the null termintor.  H5Rget_attr_name now behaves consistently
+      with the other two APIs.  Going forward, all the get character string
+      APIs in HDF5 will be modified/written in this manner, regarding the
+      length of a character string.
+
     - Fixed library to allow usage of page buffering feature for serial file
       access with parallel builds of HDF5
 
diff --git a/src/H5Rpublic.h b/src/H5Rpublic.h
index 53472f933ab..9e1f73f1c00 100644
--- a/src/H5Rpublic.h
+++ b/src/H5Rpublic.h
@@ -589,7 +589,7 @@ H5_DLL ssize_t H5Rget_obj_name(H5R_ref_t *ref_ptr, hid_t rapl_id, char *name, si
  * \details H5Rget_attr_name() retrieves the attribute name for the
  *          attribute reference pointed to by \p ref_ptr.
  *
- *          \details_namelen_plusone{attribute,H5Rget_attr_name}
+ *          \details_namelen{attribute,H5Rget_attr_name}
  *
  * \since 1.12.0
  *

From 6edb92ada7955d28a756b5473b6e3f5e59afd53b Mon Sep 17 00:00:00 2001
From: Binh-Minh <bmribler@hdfgroup.org>
Date: Mon, 12 Aug 2024 01:15:51 -0400
Subject: [PATCH 9/9] Fix typo

---
 release_docs/RELEASE.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt
index debdbd9c37b..5712638eb21 100644
--- a/release_docs/RELEASE.txt
+++ b/release_docs/RELEASE.txt
@@ -815,7 +815,7 @@ Bug Fixes since HDF5-1.14.0 release
       without the null terminator
 
       H5Rget_file_name and H5Rget_obj_name both return the name's length
-      without the null termintor.  H5Rget_attr_name now behaves consistently
+      without the null terminator.  H5Rget_attr_name now behaves consistently
       with the other two APIs.  Going forward, all the get character string
       APIs in HDF5 will be modified/written in this manner, regarding the
       length of a character string.