Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to XCode 11.7 #134

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Switch to XCode 11.7 #134

merged 1 commit into from
Nov 4, 2020

Conversation

cjh1
Copy link
Contributor

@cjh1 cjh1 commented Nov 4, 2020

pycifrw will not build with the latest version of XCode so downgrade to 11.7.

@cjh1
Copy link
Contributor Author

cjh1 commented Nov 4, 2020

@saransh13 This fixes #133. The problem was caused by this upgrade. There is update upstream that fixes the package to build with the latest XCode, but its not in a release yet. I have requested the maintainer pushes a new release. For now this will get the CI back passing.

@cjh1 cjh1 requested review from psavery and saransh13 November 4, 2020 22:01
@@ -31,6 +31,12 @@ jobs:
run:
shell: bash
steps:
- name: Use XCode 12.0 so pycifrw will build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "11.7" instead of "12.0"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I tried 12.0 first :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

pycifrw will not build with the latest version of XCode so downgrade
to 11.7.
Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saransh13
Copy link
Member

@psavery Thanks! Merging this.

@cjh1 cjh1 merged commit 3980835 into master Nov 4, 2020
@cjh1 cjh1 deleted the pycifrw branch November 5, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants