-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to XCode 11.7 #134
Switch to XCode 11.7 #134
Conversation
@saransh13 This fixes #133. The problem was caused by this upgrade. There is update upstream that fixes the package to build with the latest XCode, but its not in a release yet. I have requested the maintainer pushes a new release. For now this will get the CI back passing. |
.github/workflows/test.yml
Outdated
@@ -31,6 +31,12 @@ jobs: | |||
run: | |||
shell: bash | |||
steps: | |||
- name: Use XCode 12.0 so pycifrw will build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "11.7" instead of "12.0"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I tried 12.0 first :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
pycifrw will not build with the latest version of XCode so downgrade to 11.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@psavery Thanks! Merging this. |
pycifrw will not build with the latest version of XCode so downgrade to 11.7.