From 7c58783c9240d36e7651d43430f848b5ec1c6a45 Mon Sep 17 00:00:00 2001 From: Josh Salisbury Date: Tue, 16 Mar 2021 12:54:07 -0500 Subject: [PATCH 1/8] Small MVP fixes * Report table context menu for approved reports changed from "edit" to "view" * Error message state lifted up to the activity report * Not editable alert for submitted reports duplicated below "reset to draft" button * Accordion items auto expanded for non-draft/needs action reports * Resources used is now a textarea * Title and other verbiage tweaked for next steps * Report status tag capitalized and green if report is approved --- .../components/Navigator/__tests__/index.js | 1 + .../components/Navigator/components/SideNav.js | 2 +- .../Navigator/components/__tests__/SideNav.js | 2 +- frontend/src/components/Navigator/index.js | 6 +++++- .../Pages/Review/Submitter/Submitted.js | 11 +++++++++++ .../pages/ActivityReport/Pages/Review/index.js | 11 +++++++++-- .../Pages/__tests__/nextSteps.js | 8 ++++---- .../Pages/components/Objective.css | 4 ---- .../Pages/components/ResourceSelector.js | 10 +++------- .../components/__tests__/ResourceSelector.js | 18 ++++-------------- .../pages/ActivityReport/Pages/nextSteps.js | 17 +++++++++-------- frontend/src/pages/ActivityReport/index.css | 9 +++++++++ frontend/src/pages/ActivityReport/index.js | 8 ++++++-- frontend/src/pages/Landing/__tests__/index.js | 2 +- frontend/src/pages/Landing/index.js | 4 ++-- 15 files changed, 66 insertions(+), 47 deletions(-) diff --git a/frontend/src/components/Navigator/__tests__/index.js b/frontend/src/components/Navigator/__tests__/index.js index bc0d4b3f42..48604e8ca7 100644 --- a/frontend/src/components/Navigator/__tests__/index.js +++ b/frontend/src/components/Navigator/__tests__/index.js @@ -83,6 +83,7 @@ describe('Navigator', () => { onFormSubmit={onSubmit} updatePage={updatePage} onSave={onSave} + updateErrorMessage={() => {}} />, ); }; diff --git a/frontend/src/components/Navigator/components/SideNav.js b/frontend/src/components/Navigator/components/SideNav.js index 5fa6f267dd..333c2cd7fd 100644 --- a/frontend/src/components/Navigator/components/SideNav.js +++ b/frontend/src/components/Navigator/components/SideNav.js @@ -29,7 +29,7 @@ const tagClass = (state) => { case REPORT_STATUSES.SUBMITTED: return 'smart-hub--tag-submitted'; case REPORT_STATUSES.APPROVED: - return 'smart-hub--tag-submitted'; + return 'smart-hub--tag-approved'; case REPORT_STATUSES.NEEDS_ACTION: return 'smart-hub--tag-needs-action'; default: diff --git a/frontend/src/components/Navigator/components/__tests__/SideNav.js b/frontend/src/components/Navigator/components/__tests__/SideNav.js index 76d995042f..ebd3ce9eb4 100644 --- a/frontend/src/components/Navigator/components/__tests__/SideNav.js +++ b/frontend/src/components/Navigator/components/__tests__/SideNav.js @@ -64,7 +64,7 @@ describe('SideNav', () => { it('approved', () => { renderNav(REPORT_STATUSES.APPROVED); const complete = screen.getByText('Approved'); - expect(complete).toHaveClass('smart-hub--tag-submitted'); + expect(complete).toHaveClass('smart-hub--tag-approved'); expect(complete).toBeVisible(); }); diff --git a/frontend/src/components/Navigator/index.js b/frontend/src/components/Navigator/index.js index f07cba6583..39d03129d1 100644 --- a/frontend/src/components/Navigator/index.js +++ b/frontend/src/components/Navigator/index.js @@ -46,8 +46,9 @@ function Navigator({ updateLastSaveTime, showValidationErrors, updateShowValidationErrors, + errorMessage, + updateErrorMessage, }) { - const [errorMessage, updateErrorMessage] = useState(); const [showSavedDraft, updateShowSavedDraft] = useState(false); const page = pages.find((p) => p.path === currentPage); @@ -235,6 +236,8 @@ Navigator.propTypes = { pageState: PropTypes.shape({}), }).isRequired, updateFormData: PropTypes.func.isRequired, + errorMessage: PropTypes.string, + updateErrorMessage: PropTypes.func.isRequired, lastSaveTime: PropTypes.instanceOf(moment), updateLastSaveTime: PropTypes.func.isRequired, showValidationErrors: PropTypes.bool.isRequired, @@ -267,6 +270,7 @@ Navigator.defaultProps = { additionalData: {}, autoSaveInterval: 1000 * 60 * 2, lastSaveTime: null, + errorMessage: '', reportCreator: { name: null, role: null, diff --git a/frontend/src/pages/ActivityReport/Pages/Review/Submitter/Submitted.js b/frontend/src/pages/ActivityReport/Pages/Review/Submitter/Submitted.js index 0f39821bc7..e954ea1b7f 100644 --- a/frontend/src/pages/ActivityReport/Pages/Review/Submitter/Submitted.js +++ b/frontend/src/pages/ActivityReport/Pages/Review/Submitter/Submitted.js @@ -5,6 +5,16 @@ import { Alert, Button, } from '@trussworks/react-uswds'; +const NotEditableAlert = () => ( + + Report is not editable +
+ This report is no longer editable while it is waiting for manager approval. + If you wish to update this report click "Reset to Draft" to + move the report back to draft mode. + +); + const Submitted = ({ additionalNotes, approvingManager, @@ -31,6 +41,7 @@ const Submitted = ({ {' '}

+ ); diff --git a/frontend/src/pages/ActivityReport/Pages/Review/index.js b/frontend/src/pages/ActivityReport/Pages/Review/index.js index 02a475e274..3b06d073ed 100644 --- a/frontend/src/pages/ActivityReport/Pages/Review/index.js +++ b/frontend/src/pages/ActivityReport/Pages/Review/index.js @@ -8,6 +8,7 @@ import { Helmet } from 'react-helmet'; import Submitter from './Submitter'; import Approver from './Approver'; import PrintSummary from '../PrintSummary'; +import { REPORT_STATUSES } from '../../../../Constants'; import './index.css'; const ReviewSubmit = ({ @@ -61,6 +62,12 @@ const ReviewSubmit = ({ } }; + const editing = status === REPORT_STATUSES.DRAFT || status === REPORT_STATUSES.NEEDS_ACTION; + const items = editing ? reviewItems : reviewItems.map((ri) => ({ + ...ri, + expanded: true, + })); + return ( <> @@ -79,7 +86,7 @@ const ReviewSubmit = ({ error={error} onSaveForm={onSaveForm} > - + )} {approvingManager @@ -92,7 +99,7 @@ const ReviewSubmit = ({ error={error} formData={formData} > - + )} diff --git a/frontend/src/pages/ActivityReport/Pages/__tests__/nextSteps.js b/frontend/src/pages/ActivityReport/Pages/__tests__/nextSteps.js index 2a9e72a75c..670e558615 100644 --- a/frontend/src/pages/ActivityReport/Pages/__tests__/nextSteps.js +++ b/frontend/src/pages/ActivityReport/Pages/__tests__/nextSteps.js @@ -7,12 +7,12 @@ import { FormProvider, useForm } from 'react-hook-form/dist/index.ie11'; import nextSteps from '../nextSteps'; -const SPECIALIST_NEXT_STEPS = 'Specialist Next Steps'; +const SPECIALIST_NEXT_STEPS = 'Specialist next steps'; const SPECIALIST_INPUT = 'specialistNextSteps-input'; const SPECIALIST_BUTTON = 'specialistNextSteps-button'; const SPECIALIST_CANCEL_BUTTON = 'specialistNextSteps-cancel-button'; -const GRANTEE_NEXT_STEPS = 'Grantees Next Steps'; +const GRANTEE_NEXT_STEPS = 'What has the grantee agreed to do next'; const GRANTEE_INPUT = 'granteeNextSteps-input'; const GRANTEE_BUTTON = 'granteeNextSteps-button'; const GRANTEE_CANCEL_BUTTON = 'granteeNextSteps-cancel-button'; @@ -125,7 +125,7 @@ describe('next steps', () => { renderNextSteps( [{ note: 'pikachu', id: 1 }, { note: 'bulbasaur', id: 30 }], ); - const newEntry = await screen.findByText('Add New Follow Up'); + const newEntry = await screen.findByText('Add New Next Step'); userEvent.click(newEntry); // When the user presses cancel to change their mind @@ -143,7 +143,7 @@ describe('next steps', () => { [], [{ note: 'pikachu', id: 1 }, { note: 'bulbasaur', id: 30 }], ); - const newEntry = await screen.findByText('Add New Follow Up'); + const newEntry = await screen.findByText('Add New Next Step'); userEvent.click(newEntry); // When the user presses cancel to change their mind diff --git a/frontend/src/pages/ActivityReport/Pages/components/Objective.css b/frontend/src/pages/ActivityReport/Pages/components/Objective.css index c043028181..8dc3347c4e 100644 --- a/frontend/src/pages/ActivityReport/Pages/components/Objective.css +++ b/frontend/src/pages/ActivityReport/Pages/components/Objective.css @@ -13,7 +13,3 @@ .usa-form .smart-hub--button__no-margin { margin-top: 0; } - -.smart-hub--text-area__resize-vertical { - resize: vertical; -} \ No newline at end of file diff --git a/frontend/src/pages/ActivityReport/Pages/components/ResourceSelector.js b/frontend/src/pages/ActivityReport/Pages/components/ResourceSelector.js index 73e1c26a2d..0d25366ba1 100644 --- a/frontend/src/pages/ActivityReport/Pages/components/ResourceSelector.js +++ b/frontend/src/pages/ActivityReport/Pages/components/ResourceSelector.js @@ -3,7 +3,7 @@ import PropTypes from 'prop-types'; import { useFormContext, useFieldArray } from 'react-hook-form/dist/index.ie11'; -import { Button, TextInput } from '@trussworks/react-uswds'; +import { Button, Textarea } from '@trussworks/react-uswds'; import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; import { faPlus, faTrash } from '@fortawesome/free-solid-svg-icons'; import { faCircle } from '@fortawesome/free-regular-svg-icons'; @@ -31,16 +31,12 @@ const ResourceSelector = ({ name, ariaName }) => { <> {fields.map((item, index) => (
- { - if (e.key === 'Enter') { - onAddNewResource(); - } - }} /> {canDelete && ( )} @@ -159,6 +159,7 @@ const NoteEntries = ({ name, humanName }) => { NoteEntries.propTypes = { name: PropTypes.string.isRequired, humanName: PropTypes.string.isRequired, + title: PropTypes.string.isRequired, }; const NextSteps = () => ( @@ -168,10 +169,10 @@ const NextSteps = () => (
- +
- + ); @@ -181,14 +182,14 @@ const sections = [ title: 'Specialist next steps', anchor: 'specialist-next-steps', items: [ - { label: 'What have you agreed to do next?', name: 'specialistNextSteps', path: 'note' }, + { label: 'Add New Next Step', name: 'specialistNextSteps', path: 'note' }, ], }, { title: 'Grantee next steps', anchor: 'grantee-next-steps', items: [ - { label: 'What have you agreed to do next?', name: 'granteeNextSteps', path: 'note' }, + { label: 'What has the grantee agreed to do next', name: 'granteeNextSteps', path: 'note' }, ], }, ]; diff --git a/frontend/src/pages/ActivityReport/index.css b/frontend/src/pages/ActivityReport/index.css index 90ea4db663..ad55c723cd 100644 --- a/frontend/src/pages/ActivityReport/index.css +++ b/frontend/src/pages/ActivityReport/index.css @@ -74,4 +74,13 @@ height: 50px; text-align: center; vertical-align: bottom; +} + +.smart-hub--tag-approved { + background-color: #f0fcf4; + color: #148439 +} + +.smart-hub--text-area__resize-vertical { + resize: vertical; } \ No newline at end of file diff --git a/frontend/src/pages/ActivityReport/index.js b/frontend/src/pages/ActivityReport/index.js index bb7373625b..be477831c3 100644 --- a/frontend/src/pages/ActivityReport/index.js +++ b/frontend/src/pages/ActivityReport/index.js @@ -4,7 +4,7 @@ */ import React, { useState, useEffect, useRef } from 'react'; import PropTypes from 'prop-types'; -import _ from 'lodash'; +import _, { startCase } from 'lodash'; import { Helmet } from 'react-helmet'; import ReactRouterPropTypes from 'react-router-prop-types'; import { useHistory, Redirect } from 'react-router-dom'; @@ -78,6 +78,7 @@ function ActivityReport({ const [editable, updateEditable] = useState(false); const [lastSaveTime, updateLastSaveTime] = useState(); const [showValidationErrors, updateShowValidationErrors] = useState(false); + const [errorMessage, updateErrorMessage] = useState(); const reportId = useRef(); const showLastUpdatedTime = (location.state && location.state.showLastUpdatedTime) || false; @@ -238,6 +239,7 @@ function ActivityReport({ }; const reportCreator = { name: user.name, role: user.role }; + const tagClass = formData.status === REPORT_STATUSES.APPROVED ? 'smart-hub--tag-approved' : ''; return (
@@ -252,7 +254,7 @@ function ActivityReport({ {formData.status && ( -
{formData.status}
+
{startCase(formData.status)}
)} @@ -276,6 +278,8 @@ function ActivityReport({ onResetToDraft={onResetToDraft} approvingManager={approvingManager} onReview={onReview} + errorMessage={errorMessage} + updateErrorMessage={updateErrorMessage} />
); diff --git a/frontend/src/pages/Landing/__tests__/index.js b/frontend/src/pages/Landing/__tests__/index.js index 3564bd136a..2a226be864 100644 --- a/frontend/src/pages/Landing/__tests__/index.js +++ b/frontend/src/pages/Landing/__tests__/index.js @@ -153,7 +153,7 @@ describe('Landing Page', () => { test('displays the options buttons', async () => { const optionButtons = await screen.findAllByRole('button', { - name: /edit activity report r14-ar-2/i, + name: /view activity report r14-ar-2/i, }); expect(optionButtons.length).toBe(1); diff --git a/frontend/src/pages/Landing/index.js b/frontend/src/pages/Landing/index.js index 3cf4e16f9b..4afc412294 100644 --- a/frontend/src/pages/Landing/index.js +++ b/frontend/src/pages/Landing/index.js @@ -99,11 +99,11 @@ function renderReports(reports, history) { const menuItems = [ { - label: 'Edit', + label: 'View', onClick: () => { history.push(`/activity-reports/${id}`); }, }, ]; - const contextMenuLabel = `Edit activity report ${displayId}`; + const contextMenuLabel = `View activity report ${displayId}`; const linkTarget = legacyId ? `/activity-reports/legacy/${legacyId}` : `/activity-reports/${id}`; From 8f5411fa6837edf0ad7c3aae2e990d1efc9b1396 Mon Sep 17 00:00:00 2001 From: Josh Salisbury Date: Tue, 16 Mar 2021 13:10:37 -0500 Subject: [PATCH 2/8] Set sandbox branch --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d7e019a7a0..6577658148 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -160,7 +160,7 @@ parameters: default: "main" type: string sandbox_git_branch: # change to feature branch to test deployment - default: "js-338-383-frontend-tweaks" + default: "js-392-small-fixes" type: string prod_new_relic_app_id: default: "877570491" From 9c68e4160910dbec06d2b1605bc0953aa8b5beca Mon Sep 17 00:00:00 2001 From: Josh Salisbury Date: Tue, 16 Mar 2021 13:25:18 -0500 Subject: [PATCH 3/8] Add some tests --- .../src/fetchers/__tests__/activityReports.js | 38 ++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/frontend/src/fetchers/__tests__/activityReports.js b/frontend/src/fetchers/__tests__/activityReports.js index 50fd354180..c649d4397a 100644 --- a/frontend/src/fetchers/__tests__/activityReports.js +++ b/frontend/src/fetchers/__tests__/activityReports.js @@ -2,12 +2,48 @@ import join from 'url-join'; import fetchMock from 'fetch-mock'; import { - submitReport, saveReport, reviewReport, resetToDraft, legacyReportById, + submitReport, + saveReport, + reviewReport, + resetToDraft, + legacyReportById, + getReports, + getReportAlerts, } from '../activityReports'; describe('activityReports fetcher', () => { afterEach(() => fetchMock.restore()); + describe('getReports', () => { + it('defaults query params', async () => { + const query = { + sortBy: 'updatedAt', + sortDir: 'desc', + offset: 0, + limit: 10, + }; + + fetchMock.get(join('api', 'activity-reports'), [], { query }); + await getReports(); + expect(fetchMock.called()).toBeTruthy(); + }); + }); + + describe('getReportAlerts', () => { + it('defaults query params', async () => { + const query = { + sortBy: 'startDate', + sortDir: 'asc', + offset: 0, + limit: 10, + }; + + fetchMock.get(join('api', 'activity-reports', 'alerts'), [], { query }); + await getReportAlerts(); + expect(fetchMock.called()).toBeTruthy(); + }); + }); + describe('legacyReportById', () => { it('returns the report', async () => { const expected = { id: 1 }; From ba5896cdbec277134d6af194e4b2f8256b6dbf11 Mon Sep 17 00:00:00 2001 From: kryswisnaskas Date: Tue, 16 Mar 2021 15:33:26 -0400 Subject: [PATCH 4/8] Change Edit option --- frontend/src/pages/Landing/index.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/frontend/src/pages/Landing/index.js b/frontend/src/pages/Landing/index.js index 3cf4e16f9b..8ccd0282a4 100644 --- a/frontend/src/pages/Landing/index.js +++ b/frontend/src/pages/Landing/index.js @@ -97,15 +97,14 @@ function renderReports(reports, history) { )); + const linkTarget = legacyId ? `/activity-reports/legacy/${legacyId}` : `/activity-reports/${id}`; const menuItems = [ { - label: 'Edit', - onClick: () => { history.push(`/activity-reports/${id}`); }, + label: 'View', + onClick: () => { history.push(linkTarget); }, }, ]; - const contextMenuLabel = `Edit activity report ${displayId}`; - - const linkTarget = legacyId ? `/activity-reports/legacy/${legacyId}` : `/activity-reports/${id}`; + const contextMenuLabel = `View activity report ${displayId}`; return ( From adfa03327e79999cd403ecd55016de30210b4ab5 Mon Sep 17 00:00:00 2001 From: kryswisnaskas Date: Tue, 16 Mar 2021 15:58:27 -0400 Subject: [PATCH 5/8] Reduce context menu outline on the landing page --- frontend/src/pages/Landing/index.css | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/frontend/src/pages/Landing/index.css b/frontend/src/pages/Landing/index.css index 5a5160aee2..96c9ded90f 100644 --- a/frontend/src/pages/Landing/index.css +++ b/frontend/src/pages/Landing/index.css @@ -147,6 +147,11 @@ h1.landing { background-color: #148439; } +.landing > .smart-hub--context-menu-button:hover { + max-width: 20px; + padding: 2px; +} + .usa-table tr:nth-child(odd) { background-color:#F8F8F8; } @@ -199,7 +204,7 @@ h1.landing { overflow: hidden; text-overflow: ellipsis; display: inline-block; - width: 180px; + width: 173.5px; vertical-align: middle; } From bbec523933f2c57c366820ebc2b3e2ea1e39db73 Mon Sep 17 00:00:00 2001 From: Josh Salisbury Date: Tue, 16 Mar 2021 15:03:01 -0500 Subject: [PATCH 6/8] Fix next steps Read the issue wrong and changed the wrong labels. Switch labels back and renamed the field that actually needed to be renamed --- .../Pages/__tests__/nextSteps.js | 4 ++-- .../pages/ActivityReport/Pages/nextSteps.js | 23 +++++++++++-------- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/frontend/src/pages/ActivityReport/Pages/__tests__/nextSteps.js b/frontend/src/pages/ActivityReport/Pages/__tests__/nextSteps.js index 670e558615..96bae506c7 100644 --- a/frontend/src/pages/ActivityReport/Pages/__tests__/nextSteps.js +++ b/frontend/src/pages/ActivityReport/Pages/__tests__/nextSteps.js @@ -7,12 +7,12 @@ import { FormProvider, useForm } from 'react-hook-form/dist/index.ie11'; import nextSteps from '../nextSteps'; -const SPECIALIST_NEXT_STEPS = 'Specialist next steps'; +const SPECIALIST_NEXT_STEPS = 'Specialist Next Steps'; const SPECIALIST_INPUT = 'specialistNextSteps-input'; const SPECIALIST_BUTTON = 'specialistNextSteps-button'; const SPECIALIST_CANCEL_BUTTON = 'specialistNextSteps-cancel-button'; -const GRANTEE_NEXT_STEPS = 'What has the grantee agreed to do next'; +const GRANTEE_NEXT_STEPS = 'Grantees Next Steps'; const GRANTEE_INPUT = 'granteeNextSteps-input'; const GRANTEE_BUTTON = 'granteeNextSteps-button'; const GRANTEE_CANCEL_BUTTON = 'granteeNextSteps-cancel-button'; diff --git a/frontend/src/pages/ActivityReport/Pages/nextSteps.js b/frontend/src/pages/ActivityReport/Pages/nextSteps.js index dfbfaa4041..9e5d856ca3 100644 --- a/frontend/src/pages/ActivityReport/Pages/nextSteps.js +++ b/frontend/src/pages/ActivityReport/Pages/nextSteps.js @@ -12,7 +12,7 @@ import FormItem from '../../../components/FormItem'; import ReviewPage from './Review/ReviewPage'; const NoteEntry = ({ - onEntry, onCancel, name, isRequired = false, defaultValue = '', + onEntry, onCancel, name, isRequired = false, defaultValue = '', label, }) => { const [input, updateInput] = useState(defaultValue); @@ -30,7 +30,7 @@ const NoteEntry = ({ @@ -43,6 +43,7 @@ NoteEntry.propTypes = { onEntry: PropTypes.func.isRequired, onCancel: PropTypes.func.isRequired, name: PropTypes.string.isRequired, + label: PropTypes.string.isRequired, defaultValue: PropTypes.string, isRequired: PropTypes.bool, }; @@ -52,7 +53,7 @@ NoteEntry.defaultProps = { defaultValue: '', }; -const NoteEntries = ({ name, humanName, title }) => { +const NoteEntries = ({ name, humanName, label }) => { const { register, control, setValue, trigger, } = useFormContext(); @@ -92,13 +93,14 @@ const NoteEntries = ({ name, humanName, title }) => { if (notes.length === 0) { return ( -
+
onEntry(value, 0)} isRequired name={name} onCancel={onCancel} humanName={humanName} + label={label} />
); @@ -109,7 +111,7 @@ const NoteEntries = ({ name, humanName, title }) => { return ( <> -
+
    {notes.map((item, index) => (
  • @@ -141,6 +143,7 @@ const NoteEntries = ({ name, humanName, title }) => { name={name} humanName={humanName} defaultValue={defaultValue} + label={label} />
) @@ -159,7 +162,7 @@ const NoteEntries = ({ name, humanName, title }) => { NoteEntries.propTypes = { name: PropTypes.string.isRequired, humanName: PropTypes.string.isRequired, - title: PropTypes.string.isRequired, + label: PropTypes.string.isRequired, }; const NextSteps = () => ( @@ -169,10 +172,10 @@ const NextSteps = () => (
- +
- + ); @@ -182,14 +185,14 @@ const sections = [ title: 'Specialist next steps', anchor: 'specialist-next-steps', items: [ - { label: 'Add New Next Step', name: 'specialistNextSteps', path: 'note' }, + { label: 'What have you agreed to do next?', name: 'specialistNextSteps', path: 'note' }, ], }, { title: 'Grantee next steps', anchor: 'grantee-next-steps', items: [ - { label: 'What has the grantee agreed to do next', name: 'granteeNextSteps', path: 'note' }, + { label: 'What has the grantee agreed to do next?', name: 'granteeNextSteps', path: 'note' }, ], }, ]; From 6d9899af2ed81f013d738828d0dddcf980977beb Mon Sep 17 00:00:00 2001 From: kryswisnaskas Date: Tue, 16 Mar 2021 16:04:58 -0400 Subject: [PATCH 7/8] Reduce context menu outline on the landing page --- frontend/src/pages/Landing/index.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/pages/Landing/index.css b/frontend/src/pages/Landing/index.css index 96c9ded90f..d0a4bf63f2 100644 --- a/frontend/src/pages/Landing/index.css +++ b/frontend/src/pages/Landing/index.css @@ -147,7 +147,7 @@ h1.landing { background-color: #148439; } -.landing > .smart-hub--context-menu-button:hover { +.landing .smart-hub--context-menu-button { max-width: 20px; padding: 2px; } From 1946d611906cf2ee9fd294481a9cbc0d045451d4 Mon Sep 17 00:00:00 2001 From: Josh Salisbury Date: Wed, 17 Mar 2021 09:30:01 -0500 Subject: [PATCH 8/8] Remove max width from context menu --- frontend/src/pages/Landing/index.css | 1 - 1 file changed, 1 deletion(-) diff --git a/frontend/src/pages/Landing/index.css b/frontend/src/pages/Landing/index.css index d0a4bf63f2..e315f8d804 100644 --- a/frontend/src/pages/Landing/index.css +++ b/frontend/src/pages/Landing/index.css @@ -148,7 +148,6 @@ h1.landing { } .landing .smart-hub--context-menu-button { - max-width: 20px; padding: 2px; }