From 9405594f7d424c28ee8867337e42e79a86152b7e Mon Sep 17 00:00:00 2001
From: hbeni <beni@hallinger.org>
Date: Sat, 27 Jul 2024 17:45:55 +0200
Subject: [PATCH 1/2] Magnetic Compass: Switched to exposed magnetic compass
 props for simulating roll and pitch axis

---
 Models/Instruments/Compass.xml |  6 +--
 Systems/instruments.xml        | 93 +++++++++++++++++++---------------
 2 files changed, 56 insertions(+), 43 deletions(-)

diff --git a/Models/Instruments/Compass.xml b/Models/Instruments/Compass.xml
index 4745cf45..c6f11685 100644
--- a/Models/Instruments/Compass.xml
+++ b/Models/Instruments/Compass.xml
@@ -34,7 +34,7 @@
 			<property>instrumentation/magnetic-compass/roll-deg-final</property>
 		</clip>
 	</expression>
-	<factor>0.5</factor>
+	<factor>1.0</factor>
 	<axis>
 		<x> 1.0 </x>
 		<y> 0.0 </y>
@@ -51,10 +51,10 @@
 			<property>instrumentation/magnetic-compass/pitch-deg-final</property>
 		</clip>
 	</expression>
-	<factor>0.5</factor>
+	<factor>1.0</factor>
 	<axis>
 		<x>  0.0 </x>
-		<y> -1.0 </y>
+		<y>  1.0 </y>
 		<z>  0.0 </z>
 	</axis>
 </animation>
diff --git a/Systems/instruments.xml b/Systems/instruments.xml
index 34f6ffa6..a86c3b7e 100644
--- a/Systems/instruments.xml
+++ b/Systems/instruments.xml
@@ -686,47 +686,60 @@
             <property>/instrumentation/magnetic-compass/deviation-deg</property>
         </output>
     </filter>
-    <filter>
-        <name>Magnetic compass pivot mounting</name>
-        <type>exponential</type>
-        <filter-time>5.0</filter-time>
-        <input>
-          <expression>
-            <product>
-              <property>/orientation/pitch-deg</property>
-              <value>-1</value>
-            </product>
-          </expression>
-        </input>
-        <output>
-            <property>/instrumentation/magnetic-compass/pitch-offset-deg</property>
-        </output>
-        <min> <property>instrumentation/magnetic-compass/pitch-limit-down</property> </min>
-        <max> <property>instrumentation/magnetic-compass/pitch-limit-up</property> </max>
-    </filter>
     <filter>
         <name>Magnetic compass stuck</name>
         <type>gain</type>
         <input>
             <condition>
-              <or>
-                <less-than>
-                  <property>/orientation/pitch-deg</property>
-                  <property>instrumentation/magnetic-compass/pitch-limit-down</property>
-                </less-than>
-                <greater-than>
-                  <property>/orientation/pitch-deg</property>
-                  <property>instrumentation/magnetic-compass/pitch-limit-up</property>
-                </greater-than>
-                <less-than>
-                  <property>/orientation/roll-deg</property>
-                  <property>instrumentation/magnetic-compass/roll-limit-left</property>
-                </less-than>
-                <greater-than>
-                  <property>/orientation/roll-deg</property>
-                  <property>instrumentation/magnetic-compass/roll-limit-right</property>
-                </greater-than>
-              </or>
+              <!-- not stuck: look at current animation props -->
+              <and>
+                <not><property>instrumentation/magnetic-compass/stuck</property></not>
+                <or>
+                  <less-than>
+                    <property>/instrumentation/magnetic-compass/pitch-deg-final</property>
+                    <property>instrumentation/magnetic-compass/pitch-limit-down</property>
+                  </less-than>
+                  <greater-than>
+                    <property>/instrumentation/magnetic-compass/pitch-deg-final</property>
+                    <property>instrumentation/magnetic-compass/pitch-limit-up</property>
+                  </greater-than>
+                  <less-than>
+                    <property>/instrumentation/magnetic-compass/roll-deg-final</property>
+                    <property>instrumentation/magnetic-compass/roll-limit-left</property>
+                  </less-than>
+                  <greater-than>
+                    <property>/instrumentation/magnetic-compass/roll-deg-final</property>
+                    <property>instrumentation/magnetic-compass/roll-limit-right</property>
+                  </greater-than>
+                </or>
+              </and>
+            </condition>
+            <value>1</value>
+        </input>
+        <input>
+            <condition>
+              <!-- stuck: look if normal props are not above limits anymore -->
+              <and>
+                <property>instrumentation/magnetic-compass/stuck</property>
+                <or>
+                  <less-than>
+                    <property>/instrumentation/magnetic-compass/pitch-deg</property>
+                    <property>instrumentation/magnetic-compass/pitch-limit-down</property>
+                  </less-than>
+                  <greater-than>
+                    <property>/instrumentation/magnetic-compass/pitch-deg</property>
+                    <property>instrumentation/magnetic-compass/pitch-limit-up</property>
+                  </greater-than>
+                  <less-than>
+                    <property>/instrumentation/magnetic-compass/roll-deg</property>
+                    <property>instrumentation/magnetic-compass/roll-limit-left</property>
+                  </less-than>
+                  <greater-than>
+                    <property>/instrumentation/magnetic-compass/roll-deg</property>
+                    <property>instrumentation/magnetic-compass/roll-limit-right</property>
+                  </greater-than>
+                </or>
+              </and>
             </condition>
             <value>1</value>
         </input>
@@ -774,7 +787,7 @@
     <filter>
         <name>Magnetic compass pitch</name>
         <type>exponential</type>
-        <filter-time>0.25</filter-time> <!-- simulate damping fluid -->
+        <filter-time>0.5</filter-time> <!-- simulate damping fluid -->
         <input>
             <condition>
                 <property>instrumentation/magnetic-compass/stuck</property>
@@ -782,7 +795,7 @@
             <property>instrumentation/magnetic-compass/pitch-deg-final</property>
         </input>
         <input>
-            <property>orientation/pitch-deg</property>
+            <property>/instrumentation/magnetic-compass/pitch-deg</property>
         </input>
         <output>
             <property>instrumentation/magnetic-compass/pitch-deg-final</property>
@@ -791,7 +804,7 @@
     <filter>
         <name>Magnetic compass roll</name>
         <type>exponential</type>
-        <filter-time>0.25</filter-time> <!-- simulate damping fluid -->
+        <filter-time>0.5</filter-time> <!-- simulate damping fluid -->
         <input>
             <condition>
                 <property>instrumentation/magnetic-compass/stuck</property>
@@ -799,7 +812,7 @@
             <property>instrumentation/magnetic-compass/roll-deg-final</property>
         </input>
         <input>
-            <property>orientation/roll-deg</property>
+            <property>/instrumentation/magnetic-compass/roll-deg</property>
         </input>
         <output>
             <property>instrumentation/magnetic-compass/roll-deg-final</property>

From 07b0ec4b9a6d2a51f3bf5320704a87624d98d514 Mon Sep 17 00:00:00 2001
From: hbeni <beni@hallinger.org>
Date: Mon, 12 Aug 2024 17:37:13 +0200
Subject: [PATCH 2/2] Switched compass pitch/roll to daped c++ values

---
 Models/Instruments/Compass.xml |  4 ++--
 Systems/instruments.xml        | 42 ++++------------------------------
 2 files changed, 6 insertions(+), 40 deletions(-)

diff --git a/Models/Instruments/Compass.xml b/Models/Instruments/Compass.xml
index c6f11685..7e145bfb 100644
--- a/Models/Instruments/Compass.xml
+++ b/Models/Instruments/Compass.xml
@@ -31,7 +31,7 @@
 		<clip>
 			<clipMin>-25</clipMin>
 			<clipMax>25</clipMax>
-			<property>instrumentation/magnetic-compass/roll-deg-final</property>
+			<property>instrumentation/magnetic-compass/roll-deg</property>
 		</clip>
 	</expression>
 	<factor>1.0</factor>
@@ -48,7 +48,7 @@
 		<clip>
 			<clipMin>-9</clipMin>
 			<clipMax>9</clipMax>
-			<property>instrumentation/magnetic-compass/pitch-deg-final</property>
+			<property>instrumentation/magnetic-compass/pitch-deg</property>
 		</clip>
 	</expression>
 	<factor>1.0</factor>
diff --git a/Systems/instruments.xml b/Systems/instruments.xml
index a86c3b7e..3048a02a 100644
--- a/Systems/instruments.xml
+++ b/Systems/instruments.xml
@@ -696,19 +696,19 @@
                 <not><property>instrumentation/magnetic-compass/stuck</property></not>
                 <or>
                   <less-than>
-                    <property>/instrumentation/magnetic-compass/pitch-deg-final</property>
+                    <property>/instrumentation/magnetic-compass/pitch-deg</property>
                     <property>instrumentation/magnetic-compass/pitch-limit-down</property>
                   </less-than>
                   <greater-than>
-                    <property>/instrumentation/magnetic-compass/pitch-deg-final</property>
+                    <property>/instrumentation/magnetic-compass/pitch-deg</property>
                     <property>instrumentation/magnetic-compass/pitch-limit-up</property>
                   </greater-than>
                   <less-than>
-                    <property>/instrumentation/magnetic-compass/roll-deg-final</property>
+                    <property>/instrumentation/magnetic-compass/roll-deg</property>
                     <property>instrumentation/magnetic-compass/roll-limit-left</property>
                   </less-than>
                   <greater-than>
-                    <property>/instrumentation/magnetic-compass/roll-deg-final</property>
+                    <property>/instrumentation/magnetic-compass/roll-deg</property>
                     <property>instrumentation/magnetic-compass/roll-limit-right</property>
                   </greater-than>
                 </or>
@@ -784,40 +784,6 @@
             <property>instrumentation/magnetic-compass/indicated-heading-deg-final</property>
         </output>
     </filter>
-    <filter>
-        <name>Magnetic compass pitch</name>
-        <type>exponential</type>
-        <filter-time>0.5</filter-time> <!-- simulate damping fluid -->
-        <input>
-            <condition>
-                <property>instrumentation/magnetic-compass/stuck</property>
-            </condition>
-            <property>instrumentation/magnetic-compass/pitch-deg-final</property>
-        </input>
-        <input>
-            <property>/instrumentation/magnetic-compass/pitch-deg</property>
-        </input>
-        <output>
-            <property>instrumentation/magnetic-compass/pitch-deg-final</property>
-        </output>
-    </filter>
-    <filter>
-        <name>Magnetic compass roll</name>
-        <type>exponential</type>
-        <filter-time>0.5</filter-time> <!-- simulate damping fluid -->
-        <input>
-            <condition>
-                <property>instrumentation/magnetic-compass/stuck</property>
-            </condition>
-            <property>instrumentation/magnetic-compass/roll-deg-final</property>
-        </input>
-        <input>
-            <property>/instrumentation/magnetic-compass/roll-deg</property>
-        </input>
-        <output>
-            <property>instrumentation/magnetic-compass/roll-deg-final</property>
-        </output>
-    </filter>
 
     <!-- VSI damper -->
     <!-- To dampen the needle a bit more, especially at very tiny changes (like parking) -->