Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiMDCellService modifies MolecularDynamicsConfiguration #37

Open
Thinkpiet opened this issue Feb 1, 2024 · 1 comment
Open

MultiMDCellService modifies MolecularDynamicsConfiguration #37

Thinkpiet opened this issue Feb 1, 2024 · 1 comment
Assignees

Comments

@Thinkpiet
Copy link
Member

In coupling/services/MultiMDCellService.h simplemd::configurations::MolecularDynamicsConfiguration mdConfiguration is passed as a non-const reference, and lines 128-132 in the constructor modify the initFromCheckpoint setting. While modifying this setting is intended behavior, it it unexpected that the simpleMDConfig object outside MultiMDCellService changes. mdConfiguration should be const, and the checkpoint settings should be somewhere in InstanceHandling or so, not in the config object

@Thinkpiet
Copy link
Member Author

I just realized the checkpoint settings have to be in the configuration object, since we pass that from MaMiCo to the MD simulation... However, there should be two separate MD configurations. One 'high-level' / external mdConfig e.g. for CouetteScenario and a separate one that is used internally by InstanceHandling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants