Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the safe filter to include content that may contain HTML #615

Conversation

borisschapira
Copy link
Contributor

No description provided.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo I think?

Not sure why the > was not escaped before but you’re right - we should probably be consistent.

On that point should we use nbsp in English versions as well to prevent % going to second line? Or do you feel that’s only relevant for French versions?

src/templates/en/2019/index.html Outdated Show resolved Hide resolved
@borisschapira
Copy link
Contributor Author

On that point should we use nbsp in English versions as well to prevent % going to second line?

Without a space between the number and the %, it's never going to happen, so no, I don't think so.

@tunetheweb
Copy link
Member

OK so confused why it’s needed in the French version then? I thought main reason was to avoid an unwanted line break? Or is there another reason?

@tunetheweb
Copy link
Member

tunetheweb commented Jan 3, 2020

And btw you’re happy with the change from:

Lire le chapitre sur les Tierces Parties

to:

Lire le chapitre: Tierces Parties

?

Trying to make this generic so it works for all chapter names to removed “sur les”.

Also removed the “(3P)” from heading name for same reason.

@borisschapira
Copy link
Contributor Author

OK so confused why it’s needed in the French version then? I thought main reason was to avoid an unwanted line break? Or is there another reason?

In french you have a space between a number and what follows (symbol, measurement unit…), so orphan % is a possibility, that's why we use non-break spaces to avoid this. No space, no risk.

@tunetheweb
Copy link
Member

OK so confused why it’s needed in the French version then? I thought main reason was to avoid an unwanted line break? Or is there another reason?

In french you have a space between a number and what follows (symbol, measurement unit…), so orphan % is a possibility, that's why we use non-break spaces to avoid this. No space, no risk.

Ah gotcha! Missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants