Watchers and modules vs resource efficiency #3437
Replies: 2 comments 18 replies
-
|
Yep, this is one of the most significant architectural shortcomings in Hammerspoon, and frankly is one of the big reasons why I've been reluctant to just call a 1.0 release. What I would like to do is rewrite all of the modules that have watchers to use http://www.hammerspoon.org/docs/hs.watchable.html in such a way that the watchers are started and stopped automatically depending on whether there are any subscribers. I don't know if we'll ever actually get to that though, and if we did, even though we're <1.0 I would expect to get a lot of whinging about broken configs! |
Beta Was this translation helpful? Give feedback.
-
That's a very neat idea. I see the code is a tad above my current understanding of Hammerspoon/Lua, but I'm doing something very similar in a Docking handling setup. Just that it's spagettied into a single init.lua. But that also means it's a darn mess. This is a good idea. Guess I'll get to working on using hs.watchable to centralize all watchers. sigh ;) |
Beta Was this translation helpful? Give feedback.
-
|
I started playing with this, but I ran into an issue. When using hs.watchable for watchers of various kinds, there is a problem: If a watcher receives the same value twice in a row, which is fed into a watcher table, the watchers will not be notified the second time since the value technically doesn't change into something else. How could I work around this? I need to be notified of EVERY set, even if it is the same value as the old value. |
Beta Was this translation helpful? Give feedback.
-
|
@tigersoul925: not sure if this helps, but, you might have to enable external changes in the new contructor: https://www.hammerspoon.org/docs/hs.watchable.html#new Maybe that'll let you watch anytime an update happens, if you do that, maybe you can explicitly call the |
Beta Was this translation helpful? Give feedback.
-
That idea didn't work for me, might be doing something wrong as I get an error trying it. The code below did work, but I feel it's not the best workaround: |
Beta Was this translation helpful? Give feedback.
-
|
I'd have to defer to @cmsj or @asmagill for this one! I'll be keeping a watch on it, too though, as I imagine I'd maybe get bitten by this, too, at some point. |
Beta Was this translation helpful? Give feedback.
-
|
See #3440 As an example of its use in the console: edit: stupid it's... -- for this example, note that I have a function `finspect` that takes an arbitrary number
-- of arguments and runs `hs.inspect({ ... }, { newline = " ", indent = "" })` on the list
> obj = hs.watchable.new("test")
w1 = hs.watchable.watch("test.key", function(...) print("w1", finspect(...)) end)
w2 = hs.watchable.watch("test.key", function(...) print("w2", finspect(...)) end)
-- Loading extension: watchable
> obj.key = "hello"
w1 { { -- hs.watchable.watcher for path test.key _active = true, _alwaysNotify = false, _callback = <function 1>, _objKey = "key", _objPath = "test", _path = "test.key" }, "test", "key", nil, "hello" }
w2 { { -- hs.watchable.watcher for path test.key _active = true, _alwaysNotify = false, _callback = <function 1>, _objKey = "key", _objPath = "test", _path = "test.key" }, "test", "key", nil, "hello" }
> obj.key = "hello"
> w1:alwaysNotify(true)
hs.watchable.watcher for path test.key
> obj.key = "hello"
w1 { { -- hs.watchable.watcher for path test.key _active = true, _alwaysNotify = true, _callback = <function 1>, _objKey = "key", _objPath = "test", _path = "test.key" }, "test", "key", "hello", "hello" }
> obj.key = "hello"
w1 { { -- hs.watchable.watcher for path test.key _active = true, _alwaysNotify = true, _callback = <function 1>, _objKey = "key", _objPath = "test", _path = "test.key" }, "test", "key", "hello", "hello" }
> obj.key = "goober"
w1 { { -- hs.watchable.watcher for path test.key _active = true, _alwaysNotify = true, _callback = <function 1>, _objKey = "key", _objPath = "test", _path = "test.key" }, "test", "key", "hello", "goober" }
w2 { { -- hs.watchable.watcher for path test.key _active = true, _alwaysNotify = false, _callback = <function 1>, _objKey = "key", _objPath = "test", _path = "test.key" }, "test", "key", "hello", "goober" }
|
Beta Was this translation helpful? Give feedback.
-
Shit, how didn't I see that link? smacks head into desk Awesome, changes coming then! great!! |
Beta Was this translation helpful? Give feedback.
-
|
Tested alwaysNotify by injecting updated watchable.lua - works beautifully! |
Beta Was this translation helpful? Give feedback.
-
|
A minor remark that I noticed is that hs.watchable interacts with my global function named "error". I should probably not name a function that way, but if anyone does, it clashes with hs.watchable for some reason. |
Beta Was this translation helpful? Give feedback.
-
|
Because It's likely that you'll have issues with other lua-based modules or spoons as well at some point. |
Beta Was this translation helpful? Give feedback.
-
Oh crap. I've got some fixing to do. Thanks. |
Beta Was this translation helpful? Give feedback.
-
I've recently moved toward putting things into separate modules. This is helpful for readability and keeping things separate, but the fun ends when the need arise for watchers that are shared between several modules.
The natural thing to do is adding a seperate watcher object to every module, but will I use up extra resources this way rather than having a single watcher object and sending signals to modules (or however I would resolve it)?
Beta Was this translation helpful? Give feedback.
All reactions