Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name ‘identifier’ is somewhat confusing #42

Open
ddeboer opened this issue May 4, 2020 · 1 comment
Open

Name ‘identifier’ is somewhat confusing #42

ddeboer opened this issue May 4, 2020 · 1 comment

Comments

@ddeboer
Copy link
Contributor

ddeboer commented May 4, 2020

First of all, thanks for this package! It’s a good step towards versioning and interoperability of messages.

While this may be somewhat subjective, I find the name identifier a bit confusing. Identifier suggests a unique id for an individual message. Think of the response you get from AWS when you publish a message:

{
    "MessageId": "e0733b15-fae4-596e-bf81-6c3c271aed0c"
}

I think what you meant is not the identifier but the type of the message: as in a typing system, each (product) type is the combination of properties; in this case the keys in the message payload.

What about renaming identifier to type? Of course, this would be a BC break.

@Nyholm
Copy link
Member

Nyholm commented Dec 2, 2020

Hm.. Interesting.

Just because it is an "identifier", it does not mean it is a "unique identifier".
Im on the fence. You are correct that "type" os more clear. But is it worth the BC break?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants