Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revamp tokens ui #338

Merged
merged 22 commits into from
Nov 5, 2024

Conversation

julia-eileen
Copy link
Contributor

Acceptance Criteria

  • This PR includes the revamp of the following screens:
    • See All - Tx & Blocks
    • Tokens List
    • Tokens Balance
  • Since many of these screens were originally written using class component definitions, we had to duplicate the class files, adopting the naming convention NewUi<component_name>.js, as we couldn't access the feature flag hook inside them. The logic for determining which files to load is handled in the higher-level functional component.
  • We made some styling adjustments on the home page to closely match the Figma design.
  • The fix for the li warning on the home page is still pending. This refactor will be included in the next PR.

Security Checklist

  • Ensure that no new dependencies were added unless strictly necessary, and no development dependencies were included as production ones, as this could increase the risk of dependency hijacking.
see.all.-.dark.mode.mp4
see.all.-.light.mode.mp4
token.balance.-.dark.mode.mp4
token.balance.-.light.mode.mp4
token.list.-.dark.mode.mp4
token.list.-.light.mode.mp4

@julia-eileen julia-eileen requested a review from r4mmer as a code owner October 24, 2024 17:00
@julia-eileen julia-eileen changed the title feat: revamp tokens UI feat: revamp tokens ui Oct 24, 2024
@tuliomir tuliomir self-assigned this Oct 25, 2024
src/components/CustomSelect.js Outdated Show resolved Hide resolved
src/components/NewHathorAlert.js Outdated Show resolved Hide resolved
src/components/tx/Transactions.js Outdated Show resolved Hide resolved
src/screens/AddressDetail.js Outdated Show resolved Hide resolved
src/components/NewUiSortableTable.js Outdated Show resolved Hide resolved
src/components/NewUiAddressDetailExplorer.js Outdated Show resolved Hide resolved
src/components/token/NewUiTokenAutoCompleteField.js Outdated Show resolved Hide resolved
src/components/AddressHistory.js Outdated Show resolved Hide resolved
src/components/NewHathorAlert.js Outdated Show resolved Hide resolved
src/components/NewHathorAlert.js Outdated Show resolved Hide resolved
src/components/NewHathorAlert.js Show resolved Hide resolved
src/components/token/TokenBalances.js Outdated Show resolved Hide resolved
src/components/token/TokenRow.js Outdated Show resolved Hide resolved
src/components/tx/TxRow.js Outdated Show resolved Hide resolved
@julia-eileen julia-eileen force-pushed the feat/revamp-tokens-ui branch from 8be5952 to 6743f41 Compare October 31, 2024 17:19
@tuliomir tuliomir requested review from tuliomir and r4mmer November 1, 2024 18:35
tuliomir
tuliomir previously approved these changes Nov 4, 2024
src/components/token/TokenBalances.js Outdated Show resolved Hide resolved
src/components/token/Tokens.js Outdated Show resolved Hide resolved
@tuliomir tuliomir merged commit 7e684ac into HathorNetwork:dev Nov 5, 2024
1 check passed
@julia-eileen julia-eileen deleted the feat/revamp-tokens-ui branch November 5, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting to be deployed
Development

Successfully merging this pull request may close these issues.

3 participants