Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Using Path.iterdir() for classification labels #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alancleary
Copy link

Path.iterdir() yields paths in an arbitrary order so it needs to be sorted when using it to assign labels for a classifier.

I got burned by this when repurposing the GenomicBenchmarkDataset class for my own data sets. We had to swap the positive and negative samples in the test data for them to get the correct classification labels! This PR fixes that.

Path.iterdir() yields paths in an arbitrary order so it needs to be sorted when using it to assign labels for a classifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant