-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constdb revamp #1088
Constdb revamp #1088
Conversation
Asking @HerculesWS/developers for feedback (and review if possible) |
what about converter? |
- This is necessary for upcoming improvements Signed-off-by: Haru <haru@dotalux.com>
Signed-off-by: Haru <haru@dotalux.com>
Use respectively Job_Alchemist and Job_Alchemist instead. Signed-off-by: Haru <haru@dotalux.com>
Signed-off-by: Haru <haru@dotalux.com>
2ba36d7
to
99f707e
Compare
Updated to add a converter, addressing @4144 's concerns |
Yay ~ 2 of my plugins broken ... well its kinda expected anyway, why not having those value can parse with the source constant ? there are still many members doesn't know OPTION_XMAS is actually a constant ... |
How about we generate (and automatically update through the HerculesWS API bot) a file with all the constant names, in the documentation folder? That way all the constants would be listed in a file, that doesn't need manual maintenance |
good idea |
They were deprecated and replaced by Job_Alchemist and Job_Baby_Alchemist respectively in PR HerculesWS#1088 and commit 3f56ffc in 2016-01-13. Signed-off-by: Haru <haru@dotalux.com>
They were deprecated and replaced by Job_Alchemist and Job_Baby_Alchemist respectively in PR HerculesWS#1088 and commit 3f56ffc in 2016-01-13. Signed-off-by: Haru <haru@dotalux.com>
They were deprecated and replaced by Job_Alchemist and Job_Baby_Alchemist respectively in PR HerculesWS#1088 and commit 3f56ffc in 2016-01-13. Signed-off-by: Haru <haru@dotalux.com>
They were deprecated and replaced by Job_Alchemist and Job_Baby_Alchemist respectively in PR HerculesWS#1088 and commit 3f56ffc in 2016-01-13. Signed-off-by: Haru <haru@dotalux.com>
This converts the constants db (const.txt) to libconfig format (constants.conf). The reason behind the conversion is that it allows implementing new features more easily.
This pull request also implements a new 'Deprecated' field in the converted database. This is useful for example for #908, so that the removed constants may be deprecated instead (and removed at a later time). A silent and immediate removal, as we know, would cause the script parser not to choke on them, and interpret them as a char-reg instead.