Few small optimizations to packets_struct.h #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
look like you put packets for wrong packet versions |
|
HPMDataCheck is an auto generated file using |
4144
requested changes
Jan 11, 2022
4144
requested changes
Jan 16, 2022
4144
reviewed
Jan 16, 2022
Lemongrass3110
force-pushed
the
cleanup/packet_struct_20220111
branch
from
f254885 to
6b76410
Compare
@4144 done :) |
4144
approved these changes
Jan 17, 2022
Lemongrass3110
force-pushed
the
cleanup/packet_struct_20220111
branch
from
6b76410 to
2f62a20
Compare
4144
requested changes
Jan 19, 2022
Asheraf
requested changes
Jan 20, 2022
Lemongrass3110
force-pushed
the
cleanup/packet_struct_20220111
branch
from
2f62a20 to
be0df28
Compare
|
@Asheraf fixed :) |
Asheraf
approved these changes
Jan 20, 2022
Moved some packet headers to correct locations and added their structs Added vending packets with grade Fixed naming for packetLength in PACKET_ZC_REFINE_ADD_ITEM
Lemongrass3110
force-pushed
the
cleanup/packet_struct_20220111
branch
from
be0df28 to
b77a228
Compare
|
Rebased as requested from @4144 :) |
MishimaHaruna
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Moved some packet headers to correct locations and added their structs
Fixed some of the names to names that were leaked previously
Issues addressed: None