Cleanup old deprecated code #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4144
approved these changes
Oct 23, 2022
dastgirp
approved these changes
Oct 26, 2022
The field was replaced with ViewSprite and Subtype in a98b2d9 and PR HerculesWS#1828 (2016-09-04). Signed-off-by: Haru <haru@dotalux.com>
They were deprecated and replaced by Job_Alchemist and Job_Baby_Alchemist respectively in PR HerculesWS#1088 and commit 3f56ffc in 2016-01-13. Signed-off-by: Haru <haru@dotalux.com>
They were deprecated in PR HerculesWS#908 and commit a1310e2 in 2016-01-16. Signed-off-by: Haru <haru@dotalux.com>
The commented out, deprecated, line has been there for over 16 years and won't be missed Signed-off-by: Haru <haru@dotalux.com>
The command was deprecated in PR HerculesWS#1841 on 2017-09-18 Signed-off-by: Haru <haru@dotalux.com>
…al ID in the client BA_FROSTJOKER is left behind as a deprecated constant to help migrating custom code Signed-off-by: Haru <haru@dotalux.com>
MishimaHaruna
force-pushed
the
cleanup-deprecated
branch
from
bd89419 to
97ec06f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This is mostly a maintenance PR to clean up some old deprecated code from several years ago:
Viewfield in the item DB, that was deprecated and replaced withViewSpriteandSubtypein a98b2d9 and PR Item DB: replace numbers with constants and split View into Subtype and ViewSprite #1828 (2016-09-04).Job_AlchemandJob_Baby_Alchem, replaced byJob_AlchemistandJob_Baby_Alchemistrespectively, in PR Constdb revamp #1088 and commit 3f56ffc in (2016-01-13).VAR_*setlook constants, deprecated in PR Add EQP_ = Equipment Position constants #908 and commit a1310e2 (2016-01-16).mob_skill_useleftover in battle.c that has been forgotten for at least 16 years, possibly more.useatcmd()script command, deprecated in PR Deprecate buildin_useatcmd #1841 (2017-09-18)Additionally, the skill ID and constant
BA_FROSTJOKERhas been renamed toBA_FROSTJOKEto match its official client counterpart, since it was triggering me every time I saw the difference. The oldBA_FROSTJOKERvalue has been left behind as a deprecated constant in order to help migrating any custom code that might have been using it.Issues addressed: N/A