Split constdb docs into pre-renewal and renewal #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4144
approved these changes
Oct 23, 2022
dastgirp
approved these changes
Oct 26, 2022
The constants differ greatly between renewal and pre-renewal mode, so it makes sense to generate both files separately Signed-off-by: Haru <haru@dotalux.com>
Signed-off-by: Haru <haru@dotalux.com>
…ons of constants.md Signed-off-by: Haru <haru@dotalux.com>
MishimaHaruna
force-pushed
the
split-constdb-docs
branch
from
9377db9 to
d070b00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
The constants in doc/constants.md always referred to a renewal build of Hercules. When building in pre-renewal mode, the amount of known constants and their values differ greatly (especially mob and item IDs, but also some of the core constants), so it makes sense to have both versions of the file in the repository.
This renames constants.md into constants_re.md and adds a constants_pre-re.md alongside it. This is coherent with how we handle the SQL item/mob/mobskill SQL scripts, generating both the pre-renewal and the renewal versions.
Issues addressed: N/A