Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing commit for (m)atk/(m)def percent implementation and one official behavior fix for BS_OVERTHRUST #3293

Merged

Conversation

skyleo
Copy link
Contributor

@skyleo skyleo commented May 2, 2024

Pull Request Prelude

Changes Proposed

This ensures that ATK/DEF percent is initialized for all bl-types, which it wasn't so it was defaulted to 0, resulting to no damage or 1 damage.

Also implements correct buff for ATK % (not the one of the atk percent behavior, but in general) of BS_OVERTHRUST for party members.

list of commits these are linked to in my private fork, for my own reference:

99f3f988497ad9dbe2143384268eff74fd0dfe14
f356f84d23714dd8c2b5e81301a57769d38cb6e8
d461dec15d97d5572573072073fed236c0ba2877

This PR is a partial followup to #3290

Issues addressed: None.

@skyleo skyleo force-pushed the missing-atkdefpercent-commits branch from 14ad7f3 to 2aacdc8 Compare May 2, 2024 21:11
@skyleo
Copy link
Contributor Author

skyleo commented May 2, 2024

Adjusted to respect that Renewal behavior is different. It's still incorrect as it atm, but I can't confirm nor deny renewal behavior atm with proof, and hopefully @guilherme-gm has caught wind of it in his rebalance.

@skyleo skyleo force-pushed the missing-atkdefpercent-commits branch from 2aacdc8 to 53e0ee4 Compare May 2, 2024 21:18
@MishimaHaruna MishimaHaruna merged commit 599cec3 into HerculesWS:master May 2, 2024
43 of 46 checks passed
@MishimaHaruna
Copy link
Member

The renewal side was altered in 693c4aa so I'll handle the conflict when I merge this into the rebalance branch

@MishimaHaruna MishimaHaruna added this to the Release v2024.05 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants