Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved atCommand(mobinfo) #3328

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Improved atCommand(mobinfo) #3328

merged 1 commit into from
Oct 31, 2024

Conversation

Venseer
Copy link
Contributor

@Venseer Venseer commented Oct 29, 2024

Pull Request Prelude

Changes Proposed

Change mobinfo atcommand. Drop list now users item links.

20241029192904683 - CommonRigidAmurratsnake

MishimaHaruna
MishimaHaruna requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@MishimaHaruna MishimaHaruna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a few suggestions for improvements, please have a look

src/map/atcommand.c Outdated Show resolved Hide resolved
src/map/atcommand.c Outdated Show resolved Hide resolved
@Venseer
Copy link
Contributor Author

Venseer commented Oct 31, 2024

Made some adjustments regarding strbuffer initialization.
New: Added MVP drops item link too.

20241031170441664 - EasyInfantileGonolek

@Venseer Venseer force-pushed the improved-atcommand-mobinfo branch 3 times, most recently from 1931af5 to 45004f9 Compare October 31, 2024 20:16
@MishimaHaruna MishimaHaruna added this to the Release v2024.10 milestone Oct 31, 2024
@MishimaHaruna MishimaHaruna changed the base branch from stable to master October 31, 2024 22:19
@MishimaHaruna MishimaHaruna merged commit 2615a40 into HerculesWS:master Oct 31, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v2024.10
Development

Successfully merging this pull request may close these issues.
2 participants
@Venseer @MishimaHaruna