Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode 16 build issue #778

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ttuygun
Copy link

@ttuygun ttuygun commented Oct 31, 2024

This PR fixes build error for Xcode 16

Closes #776

Copy link

@sergiisukhanov sergiisukhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing it @ttuygun 😍

@ttuygun
Copy link
Author

ttuygun commented Nov 6, 2024

If that's okay, can we move forward? @sergiisukhanov @JoeMatt

@sergiisukhanov
Copy link

If that's okay, can we move forward? @sergiisukhanov @JoeMatt

I'm not a maintainer in this repository, but I'm also waiting for this fix to be able to migrate my projects to Xcode 16.

@JoeMatt could you please take a look on this one, merge it if there are no objections from your side and publish a new version in this repository.

Please-please. 🙏

@aiKrice
Copy link

aiKrice commented Nov 20, 2024

Sometimes, we need to nudge people by waking them.
👋 @JoeMatt

@sergiisukhanov
Copy link

Hey @JoeMatt
Sorry for pinging you again. We need your attention on this PR to make it work with Xcode 16 properly. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hero 1.6.x Xcode 16 Carthage
3 participants