Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Legendary Path not being recognized #781

Closed
WolfangAukang opened this issue Dec 12, 2021 · 3 comments · Fixed by #806
Closed

Alternative Legendary Path not being recognized #781

WolfangAukang opened this issue Dec 12, 2021 · 3 comments · Fixed by #806
Labels
bug:confirmed Something isn't working.

Comments

@WolfangAukang
Copy link

IMPORTANT! Do not erase this template!

Is this a game issue? If YES please use our Discord to get help.

Open here only issues with Heroic like: Heroic doesn't open, some button is out of place, Heroic closes unexpectedly, installs got interrupted, etc.

Try to get help on our Wiki first: https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/wiki/Troubleshooting

Describe the bug

I need to use a custom path for Legendary. I have set it on the Settings and the config file is showing it as expected:

{
  "defaultSettings": {
    "altLegendaryBin": "'/home/bjorn/Projektujo/Aliaj/nixpkgs/result/bin/legendary'",

But when I try to execute a game, it uses another Legendary path. See logs below.

Add Logs

·> ./result/bin/heroic
INFO: Trying to get user information
INFO: Trying to get user information
INFO: Trying to get user information
[43:1211/191240.880478:ERROR:sandbox_linux.cc(374)] InitializeSandbox() called with multiple threads in process gpu-process.
ERROR: Failed to register protocol with OS.
[2:1211/191240.908760:ERROR:browser_main_loop.cc(269)] Gtk: gtk_widget_add_accelerator: assertion 'GTK_IS_ACCEL_GROUP (accel_group)' failed
WARNING: python command not found
INFO: Command 'python3' found. Version: '3.8.12'
INFO: Frontend: Refreshing Library
INFO: Refreshing library...
INFO: Legendary: Refreshing Epic Games...
INFO: Refreshing Epic Games...
[cli] INFO: Logging in...

[Core] INFO: Trying to re-use existing login session...

[cli] INFO: Getting game list... (this may take a while)

INFO: Updating game list
INFO: Game List Updated
INFO: Checking for game updates
INFO: Found 0 game(s) to update
INFO: launching Genshin Impact 41869934302e4b8cafac2d3c0e7c293d
INFO: Trying to get user information
WARNING: GameMode not installed
INFO:
 Launch Command:              /nix/store/dsa4vgnhw0mgknnqd1sanlb0ssaahyy0-heroic-1.10.3-extracted/resources/app.asar.unpacked/build/bin/linux/legendary launch 41869934302e4b8cafac2d3c0e7c293d   --wine /etc/profiles/per-user/bjorn/bin/wine --wine-prefix '/home/bjorn/.wine'
INFO: Trying to get user information
INFO: checking for heroic updates
INFO: Stopping Discord Rich Presence if running...
INFO: Stopped Discord Rich Presence.
INFO: Saving log file to /home/bjorn/.config/heroic/Crash Reports/Sat Dec 11 2021.txt

Crash report is empty. The launch command is executing a legendary path that seems to be the default, that I want to avoid because it won't work on NixOS, that's why I'm using another path for Legendary.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings'
  2. Change value for 'Choose an alternative Legendary Binary to use'
  3. Go to Library
  4. Run any game
  5. Check Launch Command (not using alt path)

Expected behavior
Application will use alternative path to run game.

Screenshots

Desktop (please complete the following information):

  • OS: NixOS
  • Heroic Version 1.10.3
  • Genshin Impact (although it applies to any game)
  • Wine/Proton version: 6.0.2|6.3
  • Hardware specs (RAM, CPU, GPU): I think they wouldn't matter for this case :)

Additional context

Although this is not on an OS that is officially supported, I think that as long as the application can use the alternative path for Legendary, it would be enough to solve the issue.

@flavioislima
Copy link
Member

Can you try this on the beta release?

@flavioislima flavioislima added the bug:confirmed Something isn't working. label Dec 21, 2021
@flavioislima
Copy link
Member

Confirmed the bug, I'll fix it on next release.

@WolfangAukang
Copy link
Author

Thank you very much!

flavioislima added a commit that referenced this issue Dec 22, 2021
* feat: add BE settings and types

* feat: add frontend setting toggle and handlers

* i18n: updated keys

* Fix Alt legendary binary not working #781

* feat: implement oeverlay Scrollbar #691

* chore: tests

* chore: pre-push update

* test: fix constants tests

* fix: UI fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:confirmed Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants