Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable the controller navigation #1222

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Apr 20, 2022

This PR adds a configuration to disable the spatial navigation of Heroic using the gamepad/controller.

It can be problematic if a controller has driffting, so a user can disable the feature to prevent the controller to perfom undesired actions.

Closes #1171


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 20, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit a69e04c into main Apr 21, 2022
@flavioislima flavioislima deleted the feature/disable-gamepad branch April 21, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[General] Add Disable controller input setting
2 participants