[General] Beta-Feature: GOG implementation #872

imLinguin · 2022-01-05T16:04:42Z

WORK IN PROGRESS!

To do List:

Use the following Checklist if you have changed something on the Backend or Frontend:

Tested the feature and it's working on a current and clean install.
Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
Created / Updated Tests (If necessary)
Created / Updated documentation (If necessary)

electron/gog/games.ts

flavioislima

Looks pretty good overall. Great job here! ⚔️
Most of the comments are about improving readability or about missing comments or future improvement.
Looking at the code like this it's hard to find some bug so I didn't focus on that.
I believe the first iteration is amazing, better than we planned at first. So After release we can focus on improving the code, refactoring, etc. :D

electron/gog/setup.ts

electron/gog/library.ts

electron/gog/user.ts

electron/launcher.ts

src/screens/Library/components/GameCard/index.tsx

src/screens/Library/components/InstallModal/index.tsx

src/screens/Settings/index.tsx

src/screens/WebView/index.tsx

src/state/GlobalState.tsx

flavioislima · 2022-02-20T14:54:40Z

Ah, do not forget to generate the i18n keys as well.
Running yarn i18n .

flavioislima · 2022-02-20T15:52:06Z

I believe we also need the platform filter on Linux.

…obably, since it's hard to reproduce)

public/locales/fa/gamepage.json

src/screens/Library/components/GameCard/index.tsx

imLinguin · 2022-02-22T14:50:06Z

Summary of the PR

Features for GOG games

Downloading games using Galaxy API (Windows and MacOS)
Downloading games using offline installers (Linux)
Ability to pick a game language for games that support it
Downloading game DLCs (might not work properly with old V1 Depots)
Ability to run native Linux games using Steam Runtime Scout (fixes issues with Baldur's Gate libssl not found error) Requires Steam

General features

From now on at least one account is required (you don't have to use GOG or Epic if you don't want to 😃 )
Added "runner" (game store) indicator on GamePage

Screenshots

Library Page
Account Manager page
Runner Indicator

Notes

If somebody ever finds game which uses V1 Depots and contains DLCs please contact me.
For Windows and MacOS ETA can show very large numbers, it's due to current way of dealing with decompressing files after each file is downloaded (will try to separate it between threads in the future)
Games that rely on Galaxy SDK for core features (like authentication to play) are not supported, example: Gwent - I suggest to get a Steam version if game is F2P and available there. (please report other games with that kind of stuff)
Cloud Sync for Mac and Windows GOG games is planned for the future (we don't know much about it yet, if somebody wishes to help with that reach out to us on Discord). That feature isn't currently possible for Linux native games due to lack of support on GOG side

… icon

electron/gog/library.ts

flavioislima

Looks Great!
Colossal work! ⚔️ 🛡️

arielj

hey! I added comments mainly on code style, I don't really know how parts of this work to say if anything needs changes, hope the code style suggestions are useful

arielj · 2022-02-23T02:06:29Z

electron/constants.ts

 const icon = fixAsarPath(join(__dirname, '/icon.png'))
 const iconDark = fixAsarPath(join(__dirname, '/icon-dark.png'))
 const iconLight = fixAsarPath(join(__dirname, '/icon-light.png'))
 const installed = `${legendaryConfigPath}/installed.json`
 const libraryPath = `${legendaryConfigPath}/metadata/`
-const loginUrl =
+const fallBackImage =
+  'https://user-images.githubusercontent.com/26871415/103480183-1fb00680-4dd3-11eb-9171-d8c4cc601fba.jpg'


can this use an image inside the project? in case github is down or something weird

arielj · 2022-02-23T02:11:39Z

electron/gog/games.ts

+  public async getExtraInfo(namespace: string): Promise<ExtraInfo> {
+    const gameInfo = GOGLibrary.get().getGameInfo(this.appName)
+    let targetPlatform: 'windows' | 'osx' | 'linux' = 'windows'
+    switch (process.platform) {


maybe we can use the isWindows isMac and isLinux from constants?

like:

let targetPlatform: 'windows' | 'osx' | 'linux' = 'windows' if (isMac && gameInfo.is_mac_native) { targetPlatform = 'osx' } if (isLinux && gameInfo.is_linux_native) { targetPlatform = 'linux' }

arielj · 2022-02-23T02:17:50Z

electron/gog/games.ts

+      })
+  }
+  public async stop(): Promise<void> {
+    const pattern = process.platform === 'linux' ? this.appName : 'gogdl'


same here about using isLinux from constants instead

arielj · 2022-02-23T02:18:08Z

electron/gog/games.ts

+    const pattern = process.platform === 'linux' ? this.appName : 'gogdl'
+    logInfo(['killing', pattern], LogPrefix.Gog)
+
+    if (process.platform === 'win32') {


and isWindows

arielj · 2022-02-23T02:21:41Z

electron/gog/games.ts

+    const logPath = `"${heroicGamesConfigPath}${this.appName}.log"`
+    const writeLog = isWindows ? `2>&1 > ${logPath}` : `|& tee ${logPath}`
+    // In the future we need to add Language select option
+    const command = `${gogdlBin} update ${


I think the code above this line in this method is the same as the lines above line 233 in the repair method, maybe it's worth to extract?

arielj · 2022-02-23T02:51:17Z

electron/gog/library.ts

+   * @param etag (optional) value returned in response, works as checksum so we can check if we have up to date data
+   * @returns object {isUpdated, data}, where isUpdated is true when Etags match
+   */
+  public static async get_gamesdb_data(


same here for the case, getGamesdbData instead of get_gamesdb_data for consistency, and for the rest of the functions in this file

arielj · 2022-02-23T02:54:00Z

electron/gog/setup.ts

+            workingDir ? 'cd ' + workingDir + ' &&' : ''
+          } ${commandPrefix} "${executablePath}" ${exeArguments}`
+          // Requires testing
+          if (process.platform == 'win32') {


maybe use isWindows from constants

arielj · 2022-02-23T02:56:16Z

electron/gog/user.ts

+})
+
+const gogAuthenticateUrl =
+  'https://auth.gog.com/token?client_id=46899977096215655&client_secret=9d85c43b1482497dbbce61f6e4aa173a433796eeae2ca8c5f6129f2dc4de46d9&grant_type=authorization_code&redirect_uri=https%3A%2F%2Fembed.gog.com%2Fon_login_success%3Forigin%3Dclient&code='


is it ok that there's client_id and secret hardcoded like this? maybe it's needed but it looks suspicious to me, just checking (maybe this is the only way)

This is GOG Galaxy's client_id nothing to worry about

arielj · 2022-02-23T03:01:02Z

electron/launcher.ts

+  winePath: string,
+  appName: string
+) {
+  if (platform() === 'darwin') {


if (isMac)

arielj · 2022-02-23T03:06:32Z

electron/main.ts

@@ -971,7 +1026,7 @@ ipcMain.handle('updateGame', async (e, game) => {
  }

  const epicOffline = await isEpicServiceOffline()
-  if (epicOffline) {
+  if (epicOffline && runner == 'legendary') {


maybe the check for the epic status service can be done only if runner === 'legendary'? now it seems to trigger the check for the epic service even if not needed

imLinguin and others added 5 commits December 31, 2021 12:37

Fix wine prefixes not being created

d9177fa

Merge branch 'main' into main

3586733

Merge branch 'Heroic-Games-Launcher:main' into main

a690bcc

Merge branch 'Heroic-Games-Launcher:main' into main

dc1fbb0

Add sidebar GOG button temporarly. Handle login and library sync

ee0bdd6

imLinguin marked this pull request as draft January 5, 2022 17:51

imLinguin and others added 24 commits January 6, 2022 16:57

Merge branch 'Heroic-Games-Launcher:main' into main

1c225d3

Update with latest changes

df1bf00

Merge branch 'Heroic-Games-Launcher:main' into main

8701177

Update to latest fixes

24f6803

Getting images using gamesdb, displaying library

cdfcc75

Merge branch 'Heroic-Games-Launcher:main' into main

e19b473

Pull from upstream

45cf279

Add gog API endpoint, display requirements

eda57b1

Merge branch 'Heroic-Games-Launcher:main' into main

da125a8

Pull latest changes

e1d66ec

Merge branch 'Heroic-Games-Launcher:main' into main

c9c8e9c

Fetch gamepad update

16c6c3f

Merge branch 'Heroic-Games-Launcher:main' into main

69253f6

Pull latest main

c69b558

Basic heroic-gogdl integration (installing, canceling)

9639af7

Merge branch 'Heroic-Games-Launcher:main' into main

ce22792

Pull latest changes

c3b9dc5

Update logging to new naming

5479aae

Launching GOG games, move launching to one unified function

527b03f

Merge branch 'Heroic-Games-Launcher:main' into main

e1b7c2a

Merge from upstream

67a36e0

Fix not enough space issue and library state after authenticating

6d40928

Uninstalling, Repairing

acf593a

Fix gogdl not found in bundled app

a54bb9c

flavioislima reviewed Feb 20, 2022

View reviewed changes

electron/gog/games.ts Outdated Show resolved Hide resolved

flavioislima requested changes Feb 20, 2022

View reviewed changes

Review changes, generate i18n keys

ec7ccea

imLinguin requested a review from flavioislima February 20, 2022 17:41

imLinguin and others added 5 commits February 20, 2022 18:51

Merge branch 'Heroic-Games-Launcher:main' into main

04cf669

Merge with upstream main

6789888

[Fix] Linux native games not installing correctly

1db4088

Add use Steam runtime setting, fix installed state not refreshing (pr…

209490d

…obably, since it's hard to reproduce)

Generate i18n keys

65af599

flavioislima reviewed Feb 21, 2022

View reviewed changes

public/locales/fa/gamepage.json Outdated Show resolved Hide resolved

flavioislima reviewed Feb 21, 2022

View reviewed changes

src/screens/Library/components/GameCard/index.tsx Outdated Show resolved Hide resolved

imLinguin added 3 commits February 22, 2022 13:41

Better importing,Linux DLC support,minor bugs fix

4e5f347

Fix merge conflicts

38daf84

Hide Linux platform filter for non-GOG games

a5a5420

imLinguin added 2 commits February 22, 2022 18:29

Pull upstream

e88b8e0

Fix errors on Windows, make shortcuts on windows display Primary task…

4361f59

… icon

imLinguin requested a review from flavioislima February 22, 2022 18:03

flavioislima reviewed Feb 22, 2022

View reviewed changes

electron/gog/library.ts Show resolved Hide resolved

flavioislima previously approved these changes Feb 22, 2022

View reviewed changes

flavioislima requested a review from arielj February 22, 2022 18:51

arielj reviewed Feb 23, 2022

View reviewed changes

Apply review suggestions

1cd11b1

imLinguin dismissed flavioislima’s stale review via 1cd11b1 February 23, 2022 12:45

Resolve Branch out-of date

f1cbab0

flavioislima approved these changes Feb 23, 2022

View reviewed changes

imLinguin merged commit 1522b3b into Heroic-Games-Launcher:main Feb 23, 2022

imLinguin deleted the gog_support branch February 23, 2022 13:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[General] Beta-Feature: GOG implementation #872

[General] Beta-Feature: GOG implementation #872

imLinguin commented Jan 5, 2022 •

edited

Loading

flavioislima left a comment

flavioislima commented Feb 20, 2022

flavioislima commented Feb 20, 2022

imLinguin commented Feb 22, 2022 •

edited

Loading

flavioislima left a comment

arielj left a comment

arielj Feb 23, 2022

arielj Feb 23, 2022 •

edited

Loading

arielj Feb 23, 2022

arielj Feb 23, 2022

arielj Feb 23, 2022

arielj Feb 23, 2022

arielj Feb 23, 2022

arielj Feb 23, 2022

imLinguin Feb 23, 2022

arielj Feb 23, 2022

arielj Feb 23, 2022

[General] Beta-Feature: GOG implementation #872

[General] Beta-Feature: GOG implementation #872

Conversation

imLinguin commented Jan 5, 2022 • edited Loading

WORK IN PROGRESS!

flavioislima left a comment

Choose a reason for hiding this comment

flavioislima commented Feb 20, 2022

flavioislima commented Feb 20, 2022

imLinguin commented Feb 22, 2022 • edited Loading

Summary of the PR

Features for GOG games

General features

Screenshots

Notes

flavioislima left a comment

Choose a reason for hiding this comment

arielj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arielj Feb 23, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imLinguin commented Jan 5, 2022 •

edited

Loading

imLinguin commented Feb 22, 2022 •

edited

Loading

arielj Feb 23, 2022 •

edited

Loading