Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Removed python check. #925

Merged
merged 2 commits into from
Jan 27, 2022
Merged

[Bugfix] Removed python check. #925

merged 2 commits into from
Jan 27, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Jan 26, 2022

The app was closed if the python version doesn't match the requirement (>=3.8).
Removed python check since legendary executable does not need it.
#924

  • Removed python version check
  • Installed, started and removed a game with wine-ge
  • Login/Logout worked

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer Nocccer requested a review from flavioislima January 26, 2022 13:37
@Nocccer Nocccer linked an issue Jan 26, 2022 that may be closed by this pull request
@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 26, 2022
@flavioislima
Copy link
Member

can you test if this popup is necessary? because Rodney said that Legendary doesn't need python installed at all. Can you test it on a VM or something? so we can totally remove this check.

@Nocccer
Copy link
Collaborator Author

Nocccer commented Jan 26, 2022

I can test it via a script where i remove the path to python. Will do it later.

@flavioislima
Copy link
Member

I can test it via a script where i remove the path to python. Will do it later.

yes that's right. Thanks

@Nocccer
Copy link
Collaborator Author

Nocccer commented Jan 26, 2022

I wonder if wine-ge needs a specific python version ?

@flavioislima
Copy link
Member

I don't think so, and still, that would not interfere with Heroic basics functionalities, like it is today.

@Nocccer Nocccer changed the title [Bugfix] Missmatch of python version, doesn't close app anymore [Bugfix] Removed python check. Jan 26, 2022
@Nocccer
Copy link
Collaborator Author

Nocccer commented Jan 26, 2022

@flavioislima i renamed my python3 executable and tested without python. Seems to work fine, aslong as legendary does not magically find some libraries.

@Nocccer Nocccer merged commit baacca9 into main Jan 27, 2022
@Nocccer Nocccer deleted the python_check_fix branch January 27, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.8 error
2 participants