Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fixed epic service status check. #932

Merged
merged 5 commits into from
Jan 28, 2022
Merged

[Bugfix] Fixed epic service status check. #932

merged 5 commits into from
Jan 28, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Jan 28, 2022 •
edited
Loading

Current epic service check checked for all services (Store, Fortnite, etc.). If one of them is down, we marked epic service as offline.

  • Fixed the check to check for the Epic Games Store instead for all services.
  • Adapt check, which can now check different services independently.
  • Fixed logError where error was not formated correctly which leads to javascript tracebacks.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer
Fixed check if epic service is online
3028fd2 
- fixed also logs where a error was passend,
 without a format wrapper around. Else leads
 to tracebacks
@Nocccer Nocccer linked an issue Jan 28, 2022 that may be closed by this pull request
No Games found on the Library (Epic services check issue) #930
Closed
@Nocccer Nocccer added bug:confirmed Something isn't working. pr:ready-for-review Feature-complete, ready for the grind! :P high priority labels Jan 28, 2022
@Nocccer Nocccer requested a review from flavioislima January 28, 2022 10:21
flavioislima
flavioislima reviewed Jan 28, 2022
View reviewed changes
electron/utils.ts Outdated Show resolved Hide resolved
flavioislima
flavioislima approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks good! 👍🏽

@Nocccer Nocccer merged commit 0ff1d0b into main Jan 28, 2022
@Nocccer Nocccer deleted the fix-epic-service-check branch January 28, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

Assignees
No one assigned
Labels
bug:confirmed Something isn't working. high priority pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No Games found on the Library (Epic services check issue)
2 participants
@Nocccer @flavioislima