-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Added checkbox to uninstall-modal to remove prefix aswell #940
Conversation
Looks good. But I think Uninstall Prefix is not the right way of saying it. Perhaps Removing the prefix instead. |
Sure. "Uninstall prefix aswell" is only the default value for i18n translation |
Yes but in this case, all translations will be based on that. |
e2298ea
to
ff906ec
Compare
@flavioislima added the suggested message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only one last thing that I missed on first review. Leave that checkbox unchecked by default because some people have one prefix for several games. I do that sometimes and keep specific prefixes only for specific games.
Added checkbox to uninstall modal to choose if prefix should be removed aswell.
Checkbox is checked by default.
Use the following Checklist if you have changed something on the Backend or Frontend: