Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Fix DXVK/VKD3D installation #950

Merged
merged 9 commits into from
Feb 5, 2022
Merged

[Linux] Fix DXVK/VKD3D installation #950

merged 9 commits into from
Feb 5, 2022

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Feb 3, 2022

  • Changed from lutris to official repos for DXVK and VKD3D
  • Split DXVK and VKD3D settings
  • Add ZSTD as dependency on package.json
  • Add Dialog with an error message if ZSTD was not found.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 3, 2022
@flavioislima flavioislima requested review from Nocccer, arielj and a user February 3, 2022 18:06
@Nocccer
Copy link
Collaborator

Nocccer commented Feb 4, 2022

LGTM. Maybe we should add tar as dependency, too? What do you think ?

Also i would love to have all the tool stuff (dxvk, vkd3d, ...) in a new folder in the backend.
This folder contains also the ipc functions, so main is getting more cleaned up and readable. But we can do that in a later pr.

@@ -77,21 +77,24 @@
"packageCategory": "games",
"depends": [
"gawk",
"curl"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add tar as dependency, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its impossible for a distro do not have TAR installed since its used to extract basically everything. If this was rar or zip, perhaps we would need unzip or unrar but not tar.

Copy link
Collaborator

@Nocccer Nocccer Feb 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i agree but then curl should also not be on the list :D. I mean it does not hurt if we add tar to the list ? If someone does not have it for some reason he get an error message, else not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its complicated to have dependencies here because this will ask for installing when installing the package.
some time ago I added wine as a dependency here and it broke several installations because some distros have different name for wine. So this is last resource.
I will keep as it is for now and lets see if someone will appear with a missing tar some day.

@flavioislima flavioislima merged commit 8704e23 into main Feb 5, 2022
@flavioislima flavioislima deleted the fix_dxvk_vkd3d branch February 5, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants