-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Fix DXVK/VKD3D installation #950
Conversation
…uncher into fix_dxvk_vkd3d
LGTM. Maybe we should add tar as dependency, too? What do you think ? Also i would love to have all the tool stuff (dxvk, vkd3d, ...) in a new folder in the backend. |
@@ -77,21 +77,24 @@ | |||
"packageCategory": "games", | |||
"depends": [ | |||
"gawk", | |||
"curl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add tar as dependency, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its impossible for a distro do not have TAR installed since its used to extract basically everything. If this was rar or zip, perhaps we would need unzip or unrar but not tar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i agree but then curl should also not be on the list :D. I mean it does not hurt if we add tar to the list ? If someone does not have it for some reason he get an error message, else not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its complicated to have dependencies here because this will ask for installing when installing the package.
some time ago I added wine as a dependency here and it broke several installations because some distros have different name for wine. So this is last resource.
I will keep as it is for now and lets see if someone will appear with a missing tar some day.
Use the following Checklist if you have changed something on the Backend or Frontend: