Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[General] Fix Reset Heroic + Update Electron #995

Merged
merged 4 commits into from
Feb 23, 2022
Merged

[General] Fix Reset Heroic + Update Electron #995

merged 4 commits into from
Feb 23, 2022

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Feb 23, 2022 •
edited
Loading

  • Fixed the Reset Heroic function making it more specific to delete the settings only.
  • Update GOGDL to fix import and install.
  • Update Electron to v17 (tested on PopOS and it seems the issue on v16 was fixed)

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

imLinguin
imLinguin approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@imLinguin imLinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have no objections

@flavioislima flavioislima merged commit 8d00b74 into main Feb 23, 2022
@flavioislima flavioislima deleted the few_fixes2 branch February 23, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imLinguin imLinguin imLinguin approved these changes

@Nocccer Nocccer Awaiting requested review from Nocccer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flavioislima @imLinguin