Follow-up cleanups after clangd#728

- The disposables passed in to install.activate() were not saved for cleanup - config.get() is not async
HighCommander4 · Nov 20, 2024 · baca5f8 · baca5f8
1 parent ea588aa
commit baca5f8
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/clangd-context.ts b/src/clangd-context.ts
@@ -57,7 +57,7 @@ class EnableEditsNearCursorFeature implements vscodelc.StaticFeature {
 }
 
 export class ClangdContext implements vscode.Disposable {
-  subscriptions: vscode.Disposable[] = [];
+  subscriptions: vscode.Disposable[];
   client: ClangdLanguageClient;
 
   static async create(globalStoragePath: string,
@@ -68,10 +68,12 @@ export class ClangdContext implements vscode.Disposable {
     if (!clangdPath)
       return null;
 
-    return new ClangdContext(clangdPath, outputChannel);
+    return new ClangdContext(subscriptions, clangdPath, outputChannel);
   }
 
-  private constructor(clangdPath: string, outputChannel: vscode.OutputChannel) {
+  private constructor(subscriptions: vscode.Disposable[], clangdPath: string,
+                      outputChannel: vscode.OutputChannel) {
+    this.subscriptions = subscriptions;
     const useScriptAsExecutable = config.get<boolean>('useScriptAsExecutable');
     let clangdArguments = config.get<string[]>('arguments');
     if (useScriptAsExecutable) {