tests: remove unnecessary cache clearing #16988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes all remaining unnecessary cache clearing in tests from the codebase since we now clear all cachable classes between tests making this functionally unnecessary. Original PR to automatically clear caches: - #16746 I also moved the `Utils::Analytics` module to use cachable so that we don't have to clear caches specifically in tests anymore.
apainintheneck
commented
Apr 1, 2024
Comment on lines
+19
to
22
| extend Cachable | ||
|
|
||
| class << self | ||
| include Context |
There was a problem hiding this comment.
We could potentially remove the class << self here for consistency but that would blow up the size of the diff a lot.
There was a problem hiding this comment.
@apainintheneck Worth doing in follow-up PR! In general I think it's not worth blowing up size of diff if disabling whitespace changes can hide it 👍🏻
MikeMcQuaid
approved these changes
Apr 1, 2024
Comment on lines
+19
to
22
| extend Cachable | ||
|
|
||
| class << self | ||
| include Context |
There was a problem hiding this comment.
@apainintheneck Worth doing in follow-up PR! In general I think it's not worth blowing up size of diff if disabling whitespace changes can hide it 👍🏻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This PR removes all remaining unnecessary cache clearing in tests from the codebase since we now clear all cachable classes between tests making this functionally unnecessary.
Original PR to automatically clear caches:
I also moved the
Utils::Analyticsmodule to use cachable so that we don't have to clear caches specifically in tests anymore.