Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keg: mkpath on main postgresql@X directories #17071

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 11, 2024

Fix logic in #16966 as it only matched subdirectories

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I didn't realize pattern missed top directory.

A stricter regex would be %r{^postgresql@\d+[$/]} but I doubt anything would use a directory name like postgresql@16<some-extra-text> and the change matches our other regex patterns (e.g. Python's /^python[23]\.\d+/)


Example of problem with previous logic:

$ brew link temporal_tables
Linking /usr/local/Cellar/temporal_tables/1.2.2_1... 3 symlinks created.

$ realpath /usr/local/share/postgresql@16
/usr/local/Cellar/temporal_tables/1.2.2_1/share/postgresql@16

$ realpath /usr/local/share/postgresql@16/extension
/usr/local/Cellar/temporal_tables/1.2.2_1/share/postgresql@16/extension

Fix logic in Homebrew#16966 as it only matched subdirectories

Signed-off-by: Michael Cho <michael@michaelcho.dev>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @cho-m!

@MikeMcQuaid MikeMcQuaid merged commit 707abc9 into Homebrew:master Apr 11, 2024
25 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label May 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants