From a1853fc975961c1ea6241805786b99af5299ce6c Mon Sep 17 00:00:00 2001 From: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Date: Fri, 1 Nov 2024 12:26:50 +0800 Subject: [PATCH] github_runner_matrix: extend timeout for dependent tests on arm64 We give our ARM runners half the timeout of the Intel runners because the ARM runners are faster. However, this is no longer true for dependent testing because we test recursive dependents on ARM but skip them on Intel. This means that we can often hit the timeout on ARM but have all jobs finish on Intel. We can re-run these with the long build label, but that's a bit wasteful of our limited long build slots. Instead, let's just use the same timeout value across ARM and Intel runners when testing dependents: 2 hours. --- Library/Homebrew/github_runner_matrix.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Library/Homebrew/github_runner_matrix.rb b/Library/Homebrew/github_runner_matrix.rb index 70ccfe07c2b22..492faf73c4eb4 100644 --- a/Library/Homebrew/github_runner_matrix.rb +++ b/Library/Homebrew/github_runner_matrix.rb @@ -169,6 +169,8 @@ def generate_runners! ["#{version}-arm64", runner_timeout] end + # We test recursive dependents on ARM macOS, so they can be slower than our Intel runners. + timeout *= 2 if @dependent_matrix && timeout < GITHUB_ACTIONS_RUNNER_TIMEOUT spec = MacOSRunnerSpec.new( name: "macOS #{version}-arm64", runner:,