-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement methods for shim scripts #18809
Comments
https://github.com/caskroom/homebrew-cask/blob/master/Casks/minecraft-server.rb - add comment, based on instructions from http://minecraft.gamepedia.com/Tutorials/Setting_up_a_server#OS_X_instructions |
#15876 doesn’t apply, because the shim isn’t necessary (the tool officially creates the necessary script). |
@vitorgalvao thanks for the heads up and for quickly merging #18827 -- I'll see if I can contribute a test and shim script |
A thought occurs: is it even possible to add some sort of test to ensure that the shim script works correctly? I'm thinking of something along the lines of the |
@psibre No, we don’t have anything like that. Shim scripts should be discouraged, though (and only used in specific situations). This is not really related to this issue at hand (this issue is about deciding on an interface for shim scripts), so I ask that you open a new issue for further questions (every caskroom mantainer is likely getting an email to each reply to this issue, so we should really stay on topic). |
What's the official comment for a shim script? |
I guess |
Puts `google-chrome` in the path. Refs: Homebrew#18809
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@caskroom/maintainers This replaces #9203. Everyone agrees shim scripts are desirable, so lets allow them.
On a first phase, if anyone submits a cask that employs a shim script (usually inside a
preflight
and using ruby methods to write to a file), we should (after determining it is indeed necessary and we have no other way to fix the problem) accept it and add a comment mentioning it’s a shim (this will allow us to find them easier to study/replace).On a second phase (the point of this issue), we should implement something to make those easier to make. So, two points:
The text was updated successfully, but these errors were encountered: