Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apcupsd 3.14.13 #15095

Closed
wants to merge 1 commit into from
Closed

Add Apcupsd 3.14.13 #15095

wants to merge 1 commit into from

Conversation

reitermarkus
Copy link
Member

No description provided.

@fanquake fanquake added enhancement cask awaiting maintainer feedback Issue needs response from a maintainer. labels Nov 11, 2015
@adidalal
Copy link
Contributor

This relies on a decision being made about #9203 - the "shim script" in this case is an installer_choices.xml that allows for unattended install.

This actually doesn't seem like a very uncommon scenario, so the choice might be to either a) implement this as core functionality (extend cask DSL) or b) allow scripts like this (because of the relative stagnation of the main codebase at the moment)

cc @caskroom/maintainers

@vitorgalvao
Copy link
Member

@reitermarkus What is the preflight intending to accomplish, exactly?

@reitermarkus
Copy link
Member Author

The preflight unchecks the daemon in the PKG installer, otherwise the installer would fail under El Capitan.

@vitorgalvao
Copy link
Member

Yeah, this is one of those cases. This is a bad way to fix the issue. The correct way is to contact the developers / fix it upstream. Crippling the cask / building workarounds in homebrew-cask when the issue is an upstream one is never the solution.

Please remove the preflight and caveats, and instead have a depends_on that’ll prevent it from installing in El Capitan. That is the correct course of action. Unless you know this will never be fixed upstream (perhaps there’s a technical reason that can’t be fixed), in which case it’s not worth adding at all.

@vitorgalvao vitorgalvao added awaiting user reply Issue needs response from a user. and removed awaiting maintainer feedback Issue needs response from a maintainer. labels Nov 16, 2015
@reitermarkus
Copy link
Member Author

Ok, then I better remove it completely and close this because I have added it to Homebrew/legacy-homebrew#45899.

@reitermarkus reitermarkus deleted the apcupsd branch November 16, 2015 18:30
@vitorgalvao
Copy link
Member

Even better! In the spirit of #14384, not having duplicates between the projects starts to be desirable.

@adidalal adidalal removed the awaiting user reply Issue needs response from a user. label Jan 3, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants