workflows: publish approved PRs on CI completion #128817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automerge-skip
ZhongRuoyu
reviewed
Apr 20, 2023
carlocab
force-pushed
the
automerge-on-approval
branch
from
dac92b8 to
055a66f
Compare
carlocab
force-pushed
the
automerge-on-approval
branch
from
055a66f to
1b3f464
Compare
ZhongRuoyu
reviewed
Apr 20, 2023
|
Sorry, didn't intend to click that. (I was using the mobile app.) |
carlocab
force-pushed
the
automerge-on-approval
branch
2 times, most recently
from
9abf80b to
4047253
Compare
ZhongRuoyu
reviewed
Apr 20, 2023
This is based on one of @MikeMcQuaid's suggestions on Slack. We add an `automerge.yml` workflow that is triggered by the `workflow_run` event. We need this in order to escalate access of `GITHUB_TOKEN` from the `pull_request` and `pull_request_review` events, which can only have read access to the GitHub API. The `automerge` workflow is triggered by two events: - completion of a `CI` workflow on a pull request - approval of a pull request Because both of these events are required in order to merge, we allow the workflow to wait for a while to check if the other event occurs. The basic idea of this workflow was borrowed from the documentation on `workflow_run` events [1]. [1] https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run
carlocab
force-pushed
the
automerge-on-approval
branch
from
4047253 to
b763256
Compare
ZhongRuoyu
approved these changes
Apr 20, 2023
|
Ok, let's merge this while I have a few hours to watch the queue to make sure nothing 💥 |
|
For the record, if anything 💥, it's easy enough to disable the automerge workflow without having to do any reverts:
|
|
We're seeing a number of failures, because the (outdated) CI workflow did not produce the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #128697 and #128544.
We need to now check the PR's
mergeable_stateto make sure we're merging something with a green approval (rather than a grey one).See octokit/octokit.net#1763 for more details on
mergeable_state.