Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python@3.{9,10,11}: fix a syntax error in sitecustomize.py #133490

Merged
merged 6 commits into from
Jun 19, 2023

Conversation

IzumiSy
Copy link
Contributor

@IzumiSy IzumiSy commented Jun 13, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fix: #133488

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 13, 2023
@IzumiSy IzumiSy force-pushed the fix-133488 branch 2 times, most recently from 323d6e1 to 5bd59ec Compare June 13, 2023 08:59
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed automerge-skip `brew pr-automerge` will skip this pull request labels Jun 13, 2023
@IzumiSy IzumiSy changed the title Fix a syntax error in sitecustomize.py Fix a syntax error in sitecustomize.py provided by Python@3.9/3.10/3.11 fomulae Jun 13, 2023
@carlocab carlocab changed the title Fix a syntax error in sitecustomize.py provided by Python@3.9/3.10/3.11 fomulae python@3.{9,10,11}: fix a syntax error in sitecustomize.py Jun 13, 2023
@carlocab
Copy link
Member

Please use Homebrew style when writing your commit messages, as indicated in the style guide. For example:

python@3.11: fix syntax error in sitecustomize.py

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 13, 2023
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the correct fix. The second site.PREFIXES line should reference new_exec_prefix instead.

@IzumiSy
Copy link
Contributor Author

IzumiSy commented Jun 13, 2023

I don't think this is the correct fix. The second site.PREFIXES line should reference new_exec_prefix instead.

This PR just aims at fixing runtime errors, so I'm not really familiar with those code around my changes 🙏

I am fine to get more commits by others with knowledge to make this PR valid.

`new_prefix` variable referenced in the out-of-scope if clause.
`new_prefix` variable referenced in the out-of-scope if clause.
`new_prefix` variable referenced in the out-of-scope if clause.
@IzumiSy
Copy link
Contributor Author

IzumiSy commented Jun 13, 2023

@Bo98
I have added commits using new_exec_prefix as you commented so please review the new changes.

@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs here.

@IzumiSy
Copy link
Contributor Author

IzumiSy commented Jun 15, 2023

@Bo98 @carlocab
It looks like CI jobs are cancelled in the middle of running. How do I rerun them?

@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jun 15, 2023
@IzumiSy
Copy link
Contributor Author

IzumiSy commented Jun 19, 2023

@Bo98
Ping. Could you review and merge this PR? 🙏

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 19, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 19, 2023
Merged via the queue into Homebrew:master with commit 3d43083 Jun 19, 2023
@IzumiSy IzumiSy deleted the fix-133488 branch June 21, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-dependents Pass --skip-dependents to brew test-bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install python3 creates sitecustomize.py with syntax error
4 participants