Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelcol-contrib 0.92.0 (new formula) #160730

Closed
wants to merge 1 commit into from

Conversation

edigaryev
Copy link

@edigaryev edigaryev commented Jan 23, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Jan 23, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@p-linnane
Copy link
Member

Thanks for the PR @edigaryev. I'm a little concerned about this notice on the upstream repo:

⚠️ Important note: Git tags in this repository may change at any time to fix any issues found during a release. They are only meant to trigger Github releases and should not be relied upon.

If this is upstream's policy, this formula will regularly break if they alter tags after release. The manual for git states that re-tagging is "the insane thing" to do, and we agree with that. It becomes very hard to rule out malicious behavior with checksums changing, so I'm not sure we can accept this unfortunately.

@p-linnane p-linnane closed this Jan 23, 2024
@SMillerDev
Copy link
Member

@mx-psi
Copy link

mx-psi commented Jan 24, 2024

Thanks for the PR @edigaryev. I'm a little concerned about this notice on the upstream repo:

⚠️ Important note: Git tags in this repository may change at any time to fix any issues found during a release. They are only meant to trigger Github releases and should not be relied upon.

If this is upstream's policy, this formula will regularly break if they alter tags after release. The manual for git states that re-tagging is "the insane thing" to do, and we agree with that. It becomes very hard to rule out malicious behavior with checksums changing, so I'm not sure we can accept this unfortunately.

Let me clarify a few points, speaking as the person that wrote that warning:

In summary: the warning is meant to express that if an issue happens from the tagging up until the Github release happens, we can change the release pipeline code to make sure the release happens smoothly; it does not mean that we will republish any of the binaries published via Github releases

I am happy to clarify this on the README from our repository if necessary. I am also happy to revisit the policy if necessary, but to be clear the Git tags on that repository are in practical terms meaningless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants