-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelcol-contrib 0.92.0 (new formula) #160730
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
9e3f5cf
to
5dfc54c
Compare
5dfc54c
to
b8eb3d7
Compare
b8eb3d7
to
29f5a8d
Compare
Thanks for the PR @edigaryev. I'm a little concerned about this notice on the upstream repo:
If this is upstream's policy, this formula will regularly break if they alter tags after release. The manual for git states that re-tagging is "the insane thing" to do, and we agree with that. It becomes very hard to rule out malicious behavior with checksums changing, so I'm not sure we can accept this unfortunately. |
It also violates: https://docs.brew.sh/Acceptable-Formulae#stable-versions |
Let me clarify a few points, speaking as the person that wrote that warning:
In summary: the warning is meant to express that if an issue happens from the tagging up until the Github release happens, we can change the release pipeline code to make sure the release happens smoothly; it does not mean that we will republish any of the binaries published via Github releases I am happy to clarify this on the README from our repository if necessary. I am also happy to revisit the policy if necessary, but to be clear the Git tags on that repository are in practical terms meaningless. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?