Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgconf: add system directories #199271

Merged
merged 2 commits into from
Dec 2, 2024
Merged

pkgconf: add system directories #199271

merged 2 commits into from
Dec 2, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 27, 2024 •
edited
Loading

Particularly important to avoid -L/usr/lib from Homebrew/brew pkg-config files as it can impact formulae that need non-brew copies (e.g. when linking to readline with -lreadline, the -L/usr/lib from another dependency like curl can mix them).

Mostly similar to original pkg-config formula but I didn't add the extra /lib
https://gitlab.freedesktop.org/pkg-config/pkg-config/-/blob/master/configure.ac?ref_type=heads#L98

Wasn't sure if needed:

  • macOS doesn't use /lib directory
  • Distros like Alpine and Arch Linux only use default value based on /usr installation (i.e. /usr/lib and /usr/include).
  • Debian may add extra directories.

This was referenced Nov 27, 2024
Merged
Merged
@cho-m cho-m added CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. long dependent tests Set a long timeout for dependent testing CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner labels Nov 27, 2024
@cho-m cho-m mentioned this pull request Nov 28, 2024
Merged
7 tasks
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 2, 2024
@BrewTestBot BrewTestBot enabled auto-merge December 2, 2024 20:43
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit de68626 Dec 2, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the pkgconf-system-dirs branch December 2, 2024 20:55
@cho-m cho-m mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-linnane p-linnane p-linnane approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long dependent tests Set a long timeout for dependent testing ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cho-m @p-linnane @BrewTestBot