Upgrade to nodejs-v4.0.0

[hmalphettes]

Cheers!

[asparagui]

See also #43714.

[kwo]

+1

[geoff-nixon]

Why has this been added as a separate option?

[hmalphettes]

It reflects this choice when configuring node:
https://github.com/nodejs/node#intl-ecma-402-support

I ported what we were doing for iojs here: https://github.com/aredridel/homebrew-iojs/blob/master/Formula/iojs.rb

[geoff-nixon]

It reflects this choice when configuring node:
https://github.com/nodejs/node#intl-ecma-402-support

I see. I like that there are a few different options now.

I ported what we were doing for iojs here: https://github.com/aredridel/homebrew-iojs/blob/master/Formula/iojs.rb

So if I understanding correctly, the "default" is becoming --with-intl=system-icu, (a decision which I heartily concur with; I think its the best option), and the homebrew install flag '-with-icu4c is to force the build to link with homebrew's 'icu4c' package? May I suggest then that the option be changed to --with-brewed-icu4c, a la the git.rb formula's options for openssl, ssl, and curl?

[geoff-nixon]

Or simply remove this as an option altogether, since I don't see much reason why one should wan't to not link to the system lib, as it's perfectly adequate?

[MikeMcQuaid]

@geoff-codes I appreciate that you deleted your comment but everyone watching this thread still saw it. Please read our Code of Conduct: https://github.com/Homebrew/homebrew/blob/master/CODEOFCONDUCT.md

[geoff-nixon]

@MikeMcQuaid All I can really say is that,

1. I am only human, as are those whom I criticized
2. I removed it as soon as I realized what I said (within minutes), but, alas, the internet has no true 'delete' key
3. I apologize

[MikeMcQuaid]

@geoff-codes That's 🆗, we appreciate the apology, thanks.

[geoff-nixon]

Thanks. Having had a proper good refresher on said Code of Conduct, I quite appreciate your criticism as laid out therein:

Our community is based on mutual respect, tolerance, and encouragement, and we are working to help each other live up to these principles.

I think if everyone held each other to account as well as you have with me just now, I'd reckon the internet would be a much more civilized place. 👍 😉 🍻

[hmalphettes]

@asparagui I apologize for the duplicate effort: somehow I missed #43714 in the list of PRs.
@geoff-codes thanks for the review.

[hmalphettes]

Reviewing the earlier PR by @killswitch my feeling is that the discussions and reviews are more advanced over there.
I'm closing this one and will focus on #43714

[DomT4]

@hmalphettes Thanks for closing this one up, and submitting the PR. Do appreciate the submission.

I'm going to lock this thread as keeping tabs on two active discussion threads is enough for everyone, let alone three, but welcome politely-toned discussion in the other threads.