Adds flag to patch npm install for iojs compatibility #36357
Conversation
| // now download the node tarball | ||
| var tarPath = gyp.opts['tarball'] | ||
| - var tarballUrl = tarPath ? tarPath : distUrl + '/v' + version + '/node-v' + version + '.tar.gz' | ||
| + var tarballUrl = tarPath ? tarPath : distUrl + '/v' + version + '/iojs-v' + version + '.tar.gz' |
There was a problem hiding this comment.
This patch looks way too iojs specific; it's literally just overriding node urls with iojs ones.
There was a problem hiding this comment.
It should be only temporary until node-gyp can decide where to download from on its own. This only touches the npm portion of the install and this is how npm devs are currently dealing with iojs compatibility. It also doesn't break joyent node compatibility.
There was a problem hiding this comment.
I'd rather wait until this patch is accepted for this reason. It looks like it could cause issues if that node fallback is just removed.
|
Ok, fixed the |
| resource("npm").stage buildpath/"npm_install" | ||
|
|
||
| npm_buildpath = buildpath/"npm_install" | ||
| resource("npm").stage npm_buildpath |
There was a problem hiding this comment.
I'm not sure there's a huge amount of benefit in splitting this onto two lines? Purely IMO.
|
That last commit was an oops. |
This PR - takes iojs out of keg-only - conflicts node and iojs - patches iojs’s installed npm - currently leaves in the iojs patch flag from Homebrew#36357
bcomnes
changed the title
bcomnes
changed the title
|
Is it still a no on patching the current npm install process, even when its behind a flag? I'm not sure if people missed this or not. Adding the flag would really make the existing keg-only iojs install more useful. |
For now, for me: yes. The patch doesn't seem to be adding iojs compatability as much as just changing some node strings to |
|
Ok, I understand. Closing for now. |
I extracted the relevant patches from nodejs/node@d1fc9c6 2015-01-24 io.js v1.0.4 Release
So that now the npm homebrew installs can work with the keg-only iojs for now.
Current iojs formula discussions
Node, iojs and npm formula resolution #36343 Node, iojs and npm formula resolutionworking iojs taps
Past iojs formula discussions
npm formula issues: