apcupsd 3.14.13 (new formula) #45899
Conversation
|
It's trying to write directly to Any way to change that? |
|
Where should it install instead? To |
|
Yeah, app bundles should be installed to |
| def install | ||
| cd "src/apcagent" do | ||
| # Install "apcagent" to prefix instead of /Applications | ||
| inreplace "Makefile", "Applications", "#{prefix}".gsub(/^\//, "") |
There was a problem hiding this comment.
What's the best way to write this without getting audit problems?
|
Anything else I need to change or can this be merged? |
|
|
||
| depends_on "libusb-compat" | ||
|
|
||
| if build.with?("cgi") |
There was a problem hiding this comment.
This doesn't need a block. depends_on "gd" if build.with?("cgi") is fine.
There was a problem hiding this comment.
Technically speaking, depends_on "gd" if build.with? "cgi" is fine as well 😉
|
Ok, I have removed the Also removed the |
|
|
||
| option "with-cgi", "Compile CGI programs" | ||
| option "with-usb", "Compile USB UPS code" | ||
| option "with-modbus-usb", "Compile MODBUS/USB driver code" |
There was a problem hiding this comment.
Is it maybe worth just doing these all by default?
|
Ok, I removed the part about SIP and added a disclaimer. |
| url "https://downloads.sourceforge.net/project/apcupsd/apcupsd%20-%20Stable/3.14.13/apcupsd-3.14.13.tar.gz" | ||
| sha256 "57ecbde01d0448bf8c4dbfe0ad016724ae66ab98adf2de955bf2be553c5d03f9" | ||
|
|
||
| option "with-usb", "Build with support for USB UPSes." |
There was a problem hiding this comment.
Maybe just worth enabling this by default?
|
Can you suggest how I can test that the kernel module loads correctly on OS X 10.11? Thanks! |
|
I don't know of a way without an actual APC UPS to test with, but here are my test results: On my Mac mini Server (OS X 10.10), it works without any problems (kext check enabled). On my iMac (OS X 10.11):
So it seems as if Just to make sure, I tried if it would work without the kext (It didn't.), so the kext is working, but only partially. Apparently my assumption that SIP is responsible for the kext not working was wrong. |
|
Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! |
No description provided.