Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small times overrides are broken #33

Closed
aaylward opened this issue Jun 23, 2013 · 0 comments
Closed

small times overrides are broken #33

aaylward opened this issue Jun 23, 2013 · 0 comments
Labels
bug

Comments

@aaylward
Copy link
Contributor

Humanize.times(2, {2: 'twump'}) should return twump, but instead:

> Humanize.times(2, {2:'twump'})
true
aaylward added a commit that referenced this issue Jun 23, 2013
@aaylward
add failing test for #33
faae0d8
aaylward added a commit that referenced this issue Jun 23, 2013
@aaylward
better test for #33 fixes #33
d4724a4
@aaylward aaylward mentioned this issue Jun 23, 2013
Closed
@aaylward aaylward mentioned this issue Jun 23, 2013
Merged
aaylward added a commit that referenced this issue Jun 23, 2013
@aaylward
Merge pull request #35 from HubSpot/timesHotFix
59711c3 
v1.3.4 fixes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaylward