Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added welsh (cy) #1533

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Added welsh (cy) #1533

wants to merge 6 commits into from

Conversation

IeuanWalker
Copy link

@IeuanWalker IeuanWalker commented Aug 16, 2024

#1529

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@IeuanWalker
Copy link
Author

IeuanWalker commented Aug 16, 2024

Hi, 2 things I'd like to do before changing this draft PR into a complete PR -

  • Is there a way to get an output of all the translations being used by the library?
  • Is there a standard set of tests you expect?
    • Or do you only expect tests if languages have implemented their own code?

@hangy
Copy link
Contributor

hangy commented Aug 24, 2024

* Is there a way to get an output of all the translations being used by the library?
  
  * I see some languages have custom code to handle their unique differences - https://github.com/Humanizr/Humanizer/tree/main/src/Humanizer/Localisation
  * So I'd like to send an output of what this library would generate to our translation team and they can verify if everything looks ok as is, or if we'd need to look at doing something similar to what other languages have done

Not that I know of. Creating all permutations for some languages with support for NumberOfWords, ByteSize, and so on sounds like a lot of information. I wonder if it might be possible to generate that with reflection, though.

* Is there a standard set of tests you expect?
  
  * Or do you only expect tests if languages have implemented their own code?

As far as I've seen, it's good practice to add some tests with new translations. You're correct that it might seem unnecessary if there's no custom code, but since the strings are also run through string.Format or are potentially concatenated in another way, having a test ensures that a change in the base code doesn't break the specific translation.

Do note that I'm just a random contributor and don't speak in any official capacity for the project. :)

@IeuanWalker IeuanWalker marked this pull request as ready for review November 23, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants