Refactored the getSysUserId Method into a Single Class #1303
Conversation
There was a problem hiding this comment.
Thanks @Ariho-Seth for attempting this.
You need only to create a new Class ControllerUtills under the util sub-folder and move the getSysUserId there . We could add more commnUtils there
The new ControllerUtills Class shoud not implement IActionConstants . Leave that for or the BaseController
Then let the BaseController and BaseRestController Classes extend the new ControllerUtills .
The rest of the controller Classes should only Extend either BaseController or BaseRestController respectively as it has been.
|
Hello @mozzy11 , please checkout that and tell me whether the solution is okay now! Thanks |
| @@ -29,7 +29,7 @@ | |||
| import org.springframework.web.bind.annotation.RestController; | |||
|
|
|||
| @RestController | |||
| public class ViewNonConformEventsRestController { | |||
| public class ViewNonConformEventsRestController extends ControllerUtills { | |||
There was a problem hiding this comment.
This is a Rest Controller oler so it should extend the BaseRestController instead
| @@ -33,7 +33,7 @@ | |||
| import org.springframework.web.bind.annotation.RestController; | |||
|
|
|||
| @RestController | |||
| public class ReportNonConformEventsRestController { | |||
| public class ReportNonConformEventsRestController extends ControllerUtills { | |||
There was a problem hiding this comment.
This is a Rest Controller oler so it should extend the BaseRestController instead
| @@ -26,12 +26,10 @@ | |||
|
|
|||
| @RestController | |||
| @RequestMapping(value = "/rest") | |||
| public class NonConformingEventsCorrectionActionRestController { | |||
| public class NonConformingEventsCorrectionActionRestController extends ControllerUtills { | |||
There was a problem hiding this comment.
This is a Rest Controller oler so it should extend the BaseRestController instead
| @@ -31,12 +31,11 @@ | |||
|
|
|||
| @RequestMapping("/rest") | |||
| @RestController | |||
| public class NotificationRestController { | |||
| public class NotificationRestController extends ControllerUtills { | |||
There was a problem hiding this comment.
This is a Rest Controller oler so it should extend the BaseRestController instead
|
|
||
| public class ControllerUtills { | ||
|
|
||
| private static final String USER_SESSION_DATA = "userSessionData"; |
There was a problem hiding this comment.
you dont need to declare this variable again just import as
import org.openelisglobal.common.action.IActionConstants;
| private static final String USER_SESSION_DATA = "userSessionData"; | ||
|
|
||
| protected String getSysUserId(HttpServletRequest request) { | ||
| UserSessionData usd = (UserSessionData) request.getSession().getAttribute(USER_SESSION_DATA); |
There was a problem hiding this comment.
just import this as IActionConstants.USER_SESSION_DATA
|
Hello @mozzy11 I added the requested changes, Is it now good to go? |
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
Screenshots
Refactor getSysUserId into a Separate Class
#1222
Other
Created a new class ie ControllerUtills and moved the
protected String getSysUserIdmethod into the new class. Then refactored all the classes that were initialy extending the BaseRestController to extend the ControllerUtills class