-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewritten Export Routine CSV report in the new Rect UI #766
Rewritten Export Routine CSV report in the new Rect UI #766
Conversation
Hello @mozzy11 and @rahul6603 Could you please review this? Additionally, I'm encountering trouble adding a new item to the sideNav. Are sideNav items fetched from the backend? Also, could you suggest better names for the route and component related to this? Thank you. |
Thanks @konavivekramakrishna , |
Which menu item did you need to add ?? And also for consistency , you can make use of this component that's already created to render the specific report based on the report type . In other words |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above comments
Thanks for the clarification @mozzy11 Got it, I will get it done |
actually, use the |
I have implemented the changes and attached the screenshot could you please review |
can you please review |
@@ -82,8 +82,7 @@ export const RoutineReportsMenu = { | |||
icon: IbmWatsonNaturalLanguageUnderstanding, | |||
SideNavMenuItem: [ | |||
{ | |||
link: | |||
config.serverBaseUrl + "/Report?type=patient&report=referredOut", | |||
link:"/RoutineReport?type=patient&report=referredOut", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@konavivekramakrishna ,
@mherman22 is right . you worked on the wrong report menu item .
You were supposed to work on this ie it should become
"/RoutineReport?type=patient&report=CISampleRoutineExport",
@@ -88,6 +89,11 @@ const RoutineIndex = () => { | |||
{type === "indicator" && | |||
report === "indicatorCDILNSPHIV" && | |||
(<HIVTestSummary/>)} | |||
{ | |||
type === "patient" && | |||
report === "referredOut" && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reort is supposed to be CISampleRoutineExport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the right report menu item
👋 Hi, @konavivekramakrishna, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
closing duplicate of #833 |
This pr adds the Export Routine CSV report page
fixes : #762
Before:
After: