Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New drop schema options don't work for Oauth and JBatch schemas #1167

Closed
lmsurpre opened this issue May 29, 2020 · 6 comments
Closed

New drop schema options don't work for Oauth and JBatch schemas #1167

lmsurpre opened this issue May 29, 2020 · 6 comments
Assignees
Labels
bug Something isn't working P2 Priority 2 - Should Have

Comments

@lmsurpre
Copy link
Member

Describe the bug
For 4.2.2 we introduced --drop-schema-fhir, --drop-schema-oauth, and --drop-schema-batch actions on the fhir-persistence-schema cli app.
However, based on the current implementation, it seems like the --drop-schema-oauth and --drop-schema-batch options don't work.

To Reproduce
Steps to reproduce the behavior:

  1. java -jar ./fhir-persistence-schema-${VERSION}-cli.jar --prop-file db2.properties --schema-name FHIRDATA --create-schemas
  2. java -jar ./fhir-persistence-schema-${VERSION}-cli.jar --prop-file db2.properties --drop-schema --drop-schema-oauth --drop-schema-batch --confirm-drop

Expected behavior
It drops the FHIR_OAUTH and FHIR_JBATCH schemas.

@lmsurpre lmsurpre added the bug Something isn't working label May 29, 2020
@prb112
Copy link
Contributor

prb112 commented May 29, 2020

Related to this... #1129

@prb112
Copy link
Contributor

prb112 commented May 29, 2020

the code underneath is not implemented, when 1129 is implemented it should resolve the above as well

@lmsurpre
Copy link
Member Author

lmsurpre commented May 29, 2020

I think this one is a little different. dropSchema vs dropTenant. We think this one has more to do with the fact that PhysicalDataModel.drop is only dropping objects with a "SCHEMA_GROUP_TAG" tag of FHIRDATA or FHIR_ADMIN, whereas the objects in these schemas aren't tagged in this way (I think)

@holger-stenzhorn
Copy link
Contributor

Just for curiosity... Is this also related to #1795?

@kmbarton423 kmbarton423 added the P2 Priority 2 - Should Have label Feb 18, 2021
@tbieste tbieste assigned tbieste and unassigned tbieste Mar 16, 2021
@prb112
Copy link
Contributor

prb112 commented Sep 17, 2021

PR #2775 addresses the drop. The tags were missing.

@d0roppe
Copy link
Collaborator

d0roppe commented Sep 21, 2021

With the latest changes to main, the fhir_jbatch and fhir_oauth schemas are cleaned out. No tables remain in those schemas now with the --drop-schema-batch and --drop-schema-oauth. But the actual schema is not dropped. closing this issue. and opening a new issue for empty schemas not being dropped.

@d0roppe d0roppe closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 Priority 2 - Should Have
Projects
None yet
Development

No branches or pull requests

6 participants