-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token search should be case-insensitive when the system being searched is case-insensitive #1551
Comments
A few implementation considerations:
|
After discussion with the team, it was agreed that the general approach would be to store indexed token values as they were specified for code systems which specify caseSensitive=true, and as normalized strings for code systems which specify caseSensitive=false, or which don't specify case sensitivity, or where no code system was specified. The following tables summarize the actions taken during indexing and searching for each code system case sensitivity setting: When indexing tokens:
When searching tokens:
Search results:
|
Signed-off-by: Mike Schroeder <mschroed@us.ibm.com>
Signed-off-by: Mike Schroeder <mschroed@us.ibm.com>
Signed-off-by: Mike Schroeder <mschroed@us.ibm.com>
Issue #1551 - perform token search based on codeSystem case-sensitivity
FYI. I was able to verify the following searches: Patient?identifier:of-type=MR|12345 [FOUND] |
Confirmed Troy search coverage of the following cases: Verified one additional case: required configuration setting ... fhirServer/core/serverRegistryResourceProviderEnabled=true |
Describe the bug
https://www.hl7.org/fhir/search.html#token says
Currently, our token search is ALWAYS case-sensitive.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
the resource is found
Additional context
https://www.hl7.org/fhir/codesystem-definitions.html#CodeSystem.caseSensitive says this:
In my opinion, that conflicts with the guidance from https://www.hl7.org/fhir/search.html#token which says search should be case-sensitive by default. However, I think we should still use the guidance from https://www.hl7.org/fhir/search.html#token and only use case-insensitive search when it is explicitly set in the corresponding CodeSystem.
The text was updated successfully, but these errors were encountered: