Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support static configuration of external FHIR base URL (in favor of originalRequestUriHeader) #1965

Closed
d0roppe opened this issue Feb 17, 2021 · 2 comments
Assignees
Labels
configuration cp P2 Priority 2 - Should Have

Comments

@d0roppe
Copy link
Collaborator

d0roppe commented Feb 17, 2021

Is your feature request related to a problem? Please describe.
The current implementation of the originalRequestUriHeader is a little more complicated than it should be. we can pass in a full uri including search criteria, and the fhir server needs to figure out what it should replace.

Describe the solution you'd like
I propose that the use of the originalRequestUriHeader should expect the [base] part of a URI, and replace the [base] part of the result url's with the value entered no matter what was entered, as it is a user provided header for text replacement of the [base] part of the url only. this will keep the code more simple and will result in predictable replacement.

Describe alternatives you've considered
no change from current implementation

Acceptance Criteria

  1. If implemented test that only the [base] part of the result url is affected and is directly replaced with what is passed in on the header.

Additional context

@prb112 prb112 added bug Something isn't working configuration labels Mar 16, 2021
@lmsurpre lmsurpre removed the bug Something isn't working label Mar 29, 2021
@lmsurpre lmsurpre changed the title use of originalRequestUriHeader should request only the [base] part of a uri and do a direct replace Support static configuration of external FHIR base URL (in favor of originalRequestUriHeader) Apr 12, 2021
@lmsurpre lmsurpre added the P2 Priority 2 - Should Have label Apr 27, 2021
@lmsurpre
Copy link
Member

Suggestion is to continue supporting the current method which is to get this value from an incoming header IN ADDITION to this new method.
However, the two are a little different because the header will contain the full url (with or without query parameters) whereas this config option would be just the BASE url. (typically https://host:port/fhir-server/api/v4 for us)

@prb112 prb112 added this to the Sprint 2021-09 milestone Jun 25, 2021
@prb112 prb112 added the cp label Jun 25, 2021
@prb112 prb112 added cp and removed cp labels Jul 19, 2021
@prb112 prb112 self-assigned this Jul 21, 2021
@d0roppe
Copy link
Collaborator Author

d0roppe commented Aug 4, 2021

This is working using the "externalBaseUrl" and the text entered in the value is directly replaced. So as long as you provide a valid [base] url it is working just fine. Closing issue.

@d0roppe d0roppe closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration cp P2 Priority 2 - Should Have
Projects
None yet
Development

No branches or pull requests

3 participants