-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw an exception when a value set include filter cannot be applied or a concept filter cannot be created #2163
Comments
Discussed this one with John a bit and we think that we can add special case logic to handle |
The special case logic would also be required for |
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Issue #2163 - throw exception when filter cannot be applied / created
@JohnTimm is this one done? |
John confirmed that this should be under QA because the corresponding change has already been merged. |
During QA I found that our valueset-expand operation doesn't support input parameters at this time (as expected) and that, when passed, it leads to a 500 server error. I think we should change that to a 4xx error with an OperationOutcome.issue of "not-supported" (which is currently mapped to a 400 bad request error at this time). Sample request that was failing: |
I posted the following to https://localhost:9443/fhir-server/api/v4/ValueSet/$expand
The result was a 400 bad request:
This part seems to be working as desired. |
Confirmed that, with the latest change, this one now returns a 400 Bad Request with a body like the following:
|
In
GraphTermServiceProvider
andCodeSystem
we currently log a warning when a value set include filter cannot be applied or a concept filter cannot be created. A better approach would be to throw aFHIRTermException
and/or aFHIRTermServiceException
. One issue that I ran into with throwing an exception is something I found in the spec artifacts:https://chat.fhir.org/#narrow/stream/179202-terminology/topic/ValueSet.20with.20is-not-a.20filter.20refers.20to.20a.20CodeSystem.20that.20do
The text was updated successfully, but these errors were encountered: