Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperationDefinition.name and OperationDefinition.code inconsistent between FHIRRestHelpers and FHIROperationRegistry #2505

Closed
prb112 opened this issue Jun 14, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@prb112
Copy link
Contributor

prb112 commented Jun 14, 2021

Describe the bug
OperationDefinition.name and OperationDefinition.code inconsistent between FHIRRestHelpers and FHIROperationRegistry

Environment
Which version of IBM FHIR Server? 4.8.3

To Reproduce
Steps to reproduce the behavior:

  1. Create an OperationDefintion with a mismatch between code and name.
  2. Add an instance type support = true, with resource: [Resource]
  3. Execute a call
  4. Check the Logs
                                 com.ibm.fhir.exception.FHIROperationException: Operation with name: 'reindex:Patient' was not found  [probeId=c0-a8-56-14-00683e0c-88e3-460a-982e-80308d9507b9]
	at com.ibm.fhir.server.operation.FHIROperationRegistry.getOperation(FHIROperationRegistry.java:131)
	at com.ibm.fhir.server.util.FHIRRestHelper.doInvoke(FHIRRestHelper.java:1139)

Expected behavior
This should work since it has the same code.

Additional context
Discovered in $reindex support
Asked John/Lee to confirm this behavior is expected or not.

Update
Note, core problem was System-Type-Instance handling in FHIROperationRegistry
Changed the lines to reflect use of code

@prb112 prb112 added the bug Something isn't working label Jun 14, 2021
@prb112 prb112 added this to the Sprint 2021-08 milestone Jun 14, 2021
@prb112 prb112 self-assigned this Jun 14, 2021
@lmsurpre
Copy link
Member

Mostly a code cleanup thing, no QA outside of the unit tests and #1751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants